From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 758C284A2F for ; Mon, 13 Jan 2025 19:16:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736795804; cv=none; b=nIzPspKMoJwekqbxGvRCoBx4FPqXWD+WJldimRNP2dCOyu3Z7oC1Tnt9hScZIiD5YC1cdn2YtEIohmvRX1CMqEzg8WufKX8P57F+meVvxBX88Xa0cueCZfV29qEwtxBexpqgVLXcmnGRoaBYhH4xFPa8E3g/c4aKw5gEtLZebh0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736795804; c=relaxed/simple; bh=atnnXGSQpqPkSRjCQ3FAGdcrXpuklRZ7wuOi7YTU5OY=; h=Message-ID:Content-Type:MIME-Version:In-Reply-To:References: Subject:From:Cc:To:Date; b=Dh4h3Or36V3tPxv/pUBRrrcK0OCL11CBnyyZ9mbGzCuPTjvZEUIXv/V3jUKwtxIaEY0DwBaovcyS/qRIS5cPcL6FY1gM5wT+vzd9z5zEtUIlvJ7bZ8tsA63NZ8YjGc57Bf5r1bJhb1FCbC4c9dQSK53xt0oH6uDBc6PbO9BFhhw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=i2J3zhTt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="i2J3zhTt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2A10C4CED6; Mon, 13 Jan 2025 19:16:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736795804; bh=atnnXGSQpqPkSRjCQ3FAGdcrXpuklRZ7wuOi7YTU5OY=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=i2J3zhTtj72+sNDIR5IA1f0oEEV1uDW+XLJUMNyCMzwz2j7QC66sZN8YScm4c+OXq tpyZtP+HO5h9PzQXcWdCD3iDFn1DC5/VaMpify261Dz1R4MKfnHbabntX11lgGWl32 Kmis/vO3sfUrPddrPYyrQy8YHVFJNOExW5ngn3HNE0r6oimNlBkSxV0aF3BdmAeTWu Zgql5puG8KJpW1Q2d77MIv1PYqwexy/ISHrxv+N16TizWW9EMSCH6znuh+dznxOD8j zTL2+mrHRdkDN96fR+TUtA1X77bVXuHiwIkro4YDwDfTys2a0ViSnERam2LueQBOxq TCHZzIStazPBA== Message-ID: Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20250111-topic-spmi_node_breakage-v1-1-3f60111a1d19@oss.qualcomm.com> References: <20250111-topic-spmi_node_breakage-v1-1-3f60111a1d19@oss.qualcomm.com> Subject: Re: [PATCH] spmi: Fix controller->node != parent->node breakage From: Stephen Boyd Cc: Marijn Suijten , linux-kernel@vger.kernel.org, Bjorn Andersson , Abel Vesa , Johan Hovold , Konrad Dybcio To: Joe Hattori , Konrad Dybcio , Mauro Carvalho Chehab Date: Mon, 13 Jan 2025 11:16:41 -0800 User-Agent: alot/0.12.dev1+gaa8c22fdeedb Quoting Konrad Dybcio (2025-01-11 03:21:00) > From: Konrad Dybcio >=20 > On some platforms, like recent Qualcomm SoCs with multi-bus SPMI > arbiters, controller->node must be assigned to the individual buses' > subnodes, as the slave devices are children of these, like so: >=20 > arbiter@c400000 > spmi@c42d000 > pmic@0 >=20 > spmi@c432000 > pmic@0 >=20 > The commit referenced in Fixes changed that assignment, such that > spmi_controller_alloc() always assumes the PMICs come directly under > the arbiter node (which is true when there's only a single bus per > controller). >=20 > Make controller->node specifiable to both benefit from Joe's refcount > improvements and un-break the aforementioned platforms. >=20 > Fixes: 821b07853e32 ("spmi: hisi-spmi-controller: manage the OF node refe= rence in device initialization and cleanup") I'll drop that patch. It sounds like it's not ready. > Signed-off-by: Konrad Dybcio