From: Chris Clayton <chris2553@googlemail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: ricky_wu@realtek.com, arnd@arndb.de, bhelgaas@google.com,
vaibhavgupta40@gmail.com, rui_feng@realsil.com.cn, kdlnx@doth.eu,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: rtsx: do not setting OC_POWER_DOWN reg in rtsx_pci_init_ocp()
Date: Fri, 18 Sep 2020 15:35:48 +0100 [thread overview]
Message-ID: <e52d7258-e760-81ac-9093-abe7c3504ee2@googlemail.com> (raw)
In-Reply-To: <20200914155830.GA3525000@kroah.com>
Mmm, gmail on android seems to have snuck some html into my reply, so here goes again...
On 14/09/2020 16:58, Greg KH wrote:
> On Sun, Sep 13, 2020 at 09:40:56AM +0100, Chris Clayton wrote:
>> Hi Greg and Arnd,
>>
>> On 24/08/2020 04:00, ricky_wu@realtek.com wrote:
>>> From: Ricky Wu <ricky_wu@realtek.com>
>>>
>>> this power saving action in rtsx_pci_init_ocp() cause INTEL-NUC6 platform
>>> missing card reader
>>>
>>
>> In his changelog above, Ricky didn't mention that this patch fixes a regression that was introduced (in 5.1) by commit
>> bede03a579b3.
>>
>> The patch that I posted to LKML contained the appropriate Fixes, etc tags. After discussion, the patch was changed to
>> remove the code that effectively disables the RTS5229 cardreader on (at least some) Intel NUC boxes. I prepared the
>> patch that Ricky submitted but he didn't include my Signed-off-by or the Fixes tag. I think the following needs to be
>> added to the changelog.
>>
>> Fixes: bede03a579b3 ("misc: rtsx: Enable OCP for rts522a rts524a rts525a rts5260")
>> Link: https://marc.info/?l=linux-kernel&m=159105912832257
>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=204003
>> Signed-off-by: Chris Clayton <chris2553@googlemail.com>
>>
>> bede03a579b3 introduced a bug which leaves the rts5229 PCI Express card reader on the Intel NUC6CAYH box.
>>
>> My main point, however, is that the patch is also needed in the 5.4 (longterm) and 5.8 (stable) series kernels.
>
> It's too late to change the commit log now that it is in my tree, but
> once it hits Linus's tree for 5.9-rc1, I can backport it to those stable
> trees if someone reminds me :)
>
Thanks, Greg. I'll send the reminder.
Chris
> thanks,
>
> greg k-h
>
next prev parent reply other threads:[~2020-09-18 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 3:00 [PATCH] misc: rtsx: do not setting OC_POWER_DOWN reg in rtsx_pci_init_ocp() ricky_wu
2020-09-13 8:40 ` Chris Clayton
2020-09-13 16:49 ` Bjorn Helgaas
2020-09-14 7:55 ` Chris Clayton
2020-09-14 15:58 ` Greg KH
2020-09-18 14:35 ` Chris Clayton [this message]
2020-10-15 18:20 ` Chris Clayton
2020-10-31 10:34 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e52d7258-e760-81ac-9093-abe7c3504ee2@googlemail.com \
--to=chris2553@googlemail.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kdlnx@doth.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=ricky_wu@realtek.com \
--cc=rui_feng@realsil.com.cn \
--cc=vaibhavgupta40@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox