public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Louis Kotze <loukot@gmail.com>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	Louis Kotze <loukot@gmail.com>
Subject: [PATCH 3/4] wifi: rtw89: advertise MLD TID-to-link mapping and link reconfiguration
Date: Mon,  4 May 2026 06:48:16 +0200	[thread overview]
Message-ID: <e53bb65233faeb67a5f26eb178b479fda0721e50.1777832019.git.loukot@gmail.com> (raw)
In-Reply-To: <cover.1777832019.git.loukot@gmail.com>

Wi-Fi Alliance Certificate WFA129313 (RTL8922AE 802.11be and Bluetooth
combo module, 2024-05-23, FW 6102.24.109.0) certifies both "Advertised
TID-to-link mapping" and "Multi-link reconfiguration (AP removal/restart)"
as Wi-Fi 7 features for this chip. The driver currently sets
mld_capa_and_ops = 0, so the STA negotiates neither capability with the
AP.

Use FIELD_PREP_CONST() (already used elsewhere in this driver, see
usb.c:784-787) to set IEEE80211_MLD_CAP_OP_TID_TO_LINK_MAP_NEG_SUPP_SAME
in the TID-to-link-map-neg-supp field, plus
IEEE80211_MLD_CAP_OP_LINK_RECONF_SUPPORT. This matches the value used by
iwlwifi for its Wi-Fi 7 STA mode (see drivers/net/wireless/intel/iwlwifi/
mld/mac80211.c IWL_MLD_CAPA_OPS macro and mvm/mac80211.c
IWL_MVM_MLD_CAPA_OPS macro), which is the established in-tree precedent
for this exact bit pattern on a Wi-Fi 7 STA.

The IEEE80211_MLD_CAP_OP_MAX_SIMUL_LINKS field is left at 0 (= 1 max
simultaneous link, matching the EMLSR-only operating mode the driver
implements per enum rtw89_mlo_mode {MLSR, EMLSR}).

These two capabilities are orthogonal to MLO operating mode (EMLSR
remains the negotiated mode per the previous patch in this series); they
let the AP perform online TID-to-link reassignments and remove or restart
links without a full assoc cycle on the STA side.

Tested on RTL8922AU (USB variant, same MAC + RF as cert'd PCIe AE)
against TP-Link Deco BE63 mesh; assoc remains stable, no regression in
EMLSR multi-link assoc behavior, all 11 wifi-health-check probes pass.

Link: https://api.cert.wi-fi.org/api/certificate/download/public?variantId=129706 [WFA cert WFA129313]
Signed-off-by: Louis Kotze <loukot@gmail.com>
---
 drivers/net/wireless/realtek/rtw89/core.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtw89/core.c b/drivers/net/wireless/realtek/rtw89/core.c
index 986deb2c1384..aedb2a284cd4 100644
--- a/drivers/net/wireless/realtek/rtw89/core.c
+++ b/drivers/net/wireless/realtek/rtw89/core.c
@@ -221,7 +221,10 @@ static const struct wiphy_iftype_ext_capab rtw89_iftypes_ext_capa[] = {
 			IEEE80211_EML_CAP_EMLSR_SUPP |
 			(IEEE80211_EML_CAP_EML_PADDING_DELAY_256US << 1) |
 			(IEEE80211_EML_CAP_EMLSR_TRANSITION_DELAY_32US << 4),
-		.mld_capa_and_ops = 0,
+		.mld_capa_and_ops =
+			FIELD_PREP_CONST(IEEE80211_MLD_CAP_OP_TID_TO_LINK_MAP_NEG_SUPP,
+					 IEEE80211_MLD_CAP_OP_TID_TO_LINK_MAP_NEG_SUPP_SAME) |
+			IEEE80211_MLD_CAP_OP_LINK_RECONF_SUPPORT,
 	},
 };
 
-- 
2.54.0


  parent reply	other threads:[~2026-05-04  4:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04  4:48 [PATCH 0/4] wifi: rtw89: advertise WFA-certified EHT capabilities for 8922a Louis Kotze
2026-05-04  4:48 ` [PATCH 1/4] wifi: rtw89: advertise EML Capabilities and Restricted TWT " Louis Kotze
2026-05-04  4:48 ` [PATCH 2/4] wifi: rtw89: advertise Multi-RU OFDMA receive for 8922a per WFA cert Louis Kotze
2026-05-04  4:48 ` Louis Kotze [this message]
2026-05-04  4:48 ` [PATCH 4/4] wifi: rtw89: advertise EHT OM Control " Louis Kotze
2026-05-06  9:12 ` [PATCH 0/4] wifi: rtw89: advertise WFA-certified EHT capabilities for 8922a Ping-Ke Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e53bb65233faeb67a5f26eb178b479fda0721e50.1777832019.git.loukot@gmail.com \
    --to=loukot@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox