From: Xing Zhengjun <zhengjun.xing@linux.intel.com>
To: Rong Chen <rong.a.chen@intel.com>, Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>, LKML <linux-kernel@vger.kernel.org>,
lkp@lists.01.org
Subject: Re: [LKP] Re: [fsnotify] c738fbabb0: will-it-scale.per_process_ops -9.5% regression
Date: Mon, 27 Jul 2020 10:07:39 +0800 [thread overview]
Message-ID: <e54b662d-4a21-7b80-31ea-530cd2d40160@linux.intel.com> (raw)
In-Reply-To: <9a2a4086-fbad-b4f8-9c00-2b7606441022@intel.com>
On 7/24/2020 10:44 AM, Rong Chen wrote:
>
>
> On 7/21/20 11:59 PM, Amir Goldstein wrote:
>> On Tue, Jul 21, 2020 at 3:15 AM kernel test robot
>> <rong.a.chen@intel.com> wrote:
>>> Greeting,
>>>
>>> FYI, we noticed a -9.5% regression of will-it-scale.per_process_ops
>>> due to commit:
>>>
>>>
>>> commit: c738fbabb0ff62d0f9a9572e56e65d05a1b34c6a ("fsnotify: fold
>>> fsnotify() call into fsnotify_parent()")
>> Strange, that's a pretty dumb patch moving some inlined code from one
>> function to
>> another (assuming there are no fsnotify marks in this test).
>>
>> Unless I am missing something the only thing that changes slightly is
>> an extra d_inode(file->f_path.dentry) deference.
>> I can get rid of it.
>>
>> Is it possible to ask for a re-test with fix patch (attached)?
>
I apply the fix patch, the regression still exists.
=========================================================================================
tbox_group/testcase/rootfs/kconfig/compiler/nr_task/mode/test/cpufreq_governor/ucode:
lkp-csl-2ap2/will-it-scale/debian-10.4-x86_64-20200603.cgz/x86_64-rhel-8.3/gcc-9/16/process/open1/performance/0x5002f01
commit:
71d734103edfa2b4c6657578a3082ee0e51d767e
c738fbabb0ff62d0f9a9572e56e65d05a1b34c6a
5c32fe90f2a57e7c4da06be51f705aec6affceb6 (the commit which the fix
patch apply based on)
7f66797f773621d0ef6718df0ef2cf849814d114 (the fix patch)
71d734103edfa2b4 c738fbabb0ff62d0f9a9572e56e 5c32fe90f2a57e7c4da06be51f7
7f66797f773621d0ef6718df0ef
---------------- --------------------------- ---------------------------
---------------------------
%stddev %change %stddev %change
%stddev %change %stddev
\ | \ | \
| \
229940 -9.8% 207333 -13.0% 199996
-11.7% 202927 will-it-scale.per_process_ops
3679048 -9.8% 3317347 -13.0% 3199942
-11.7% 3246851 will-it-scale.workload
> Hi Amir,
>
> We failed to apply this patch, could you tell us the base commit or the
> base branch?
>
> Best Regards,
> Rong Chen
> _______________________________________________
> LKP mailing list -- lkp@lists.01.org
> To unsubscribe send an email to lkp-leave@lists.01.org
--
Zhengjun Xing
prev parent reply other threads:[~2020-07-27 2:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 0:15 [fsnotify] c738fbabb0: will-it-scale.per_process_ops -9.5% regression kernel test robot
2020-07-21 15:59 ` Amir Goldstein
2020-07-24 2:44 ` Rong Chen
2020-07-24 3:47 ` Amir Goldstein
2020-07-26 11:52 ` Amir Goldstein
2020-07-27 10:52 ` Jan Kara
2020-07-27 2:07 ` Xing Zhengjun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e54b662d-4a21-7b80-31ea-530cd2d40160@linux.intel.com \
--to=zhengjun.xing@linux.intel.com \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@lists.01.org \
--cc=rong.a.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox