From: Felix Kuehling <felix.kuehling@amd.com>
To: Souptick Joarder <jrdr.linux@gmail.com>,
alexander.deucher@amd.com, christian.koenig@amd.com,
airlied@linux.ie, daniel@ffwll.ch
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/amdgpu: Added missing prototype
Date: Sat, 24 Apr 2021 14:29:07 -0400 [thread overview]
Message-ID: <e58be0d4-5a4a-e631-169b-ffb547d066da@amd.com> (raw)
In-Reply-To: <1619257220-3905-1-git-send-email-jrdr.linux@gmail.com>
Am 2021-04-24 um 5:40 a.m. schrieb Souptick Joarder:
> Kernel test robot throws below warning ->
>
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c:125:5: warning:
>>> no previous prototype for 'kgd_arcturus_hqd_sdma_load'
>>> [-Wmissing-prototypes]
> 125 | int kgd_arcturus_hqd_sdma_load(struct kgd_dev *kgd, void
> *mqd,
>
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c:195:5: warning:
>>> no previous prototype for 'kgd_arcturus_hqd_sdma_dump'
>>> [-Wmissing-prototypes]
> 195 | int kgd_arcturus_hqd_sdma_dump(struct kgd_dev *kgd,
>
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c:227:6: warning:
>>> no previous prototype for 'kgd_arcturus_hqd_sdma_is_occupied'
>>> [-Wmissing-prototypes]
> 227 | bool kgd_arcturus_hqd_sdma_is_occupied(struct kgd_dev *kgd,
> void *mqd)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c:246:5: warning:
>>> no previous prototype for 'kgd_arcturus_hqd_sdma_destroy'
>>> [-Wmissing-prototypes]
> 246 | int kgd_arcturus_hqd_sdma_destroy(struct kgd_dev *kgd, void
> *mqd,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Added prototype for these functions.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Applied to amd-staging-drm-next.
Thanks,
Felix
> ---
> v2:
> Added header which has the function declarations.
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c
> index 9ef9f3d..6409d6b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c
> @@ -25,6 +25,7 @@
> #include <linux/firmware.h>
> #include "amdgpu.h"
> #include "amdgpu_amdkfd.h"
> +#include "amdgpu_amdkfd_arcturus.h"
> #include "sdma0/sdma0_4_2_2_offset.h"
> #include "sdma0/sdma0_4_2_2_sh_mask.h"
> #include "sdma1/sdma1_4_2_2_offset.h"
prev parent reply other threads:[~2021-04-24 18:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-24 9:40 [PATCH v2] drm/amdgpu: Added missing prototype Souptick Joarder
2021-04-24 18:29 ` Felix Kuehling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e58be0d4-5a4a-e631-169b-ffb547d066da@amd.com \
--to=felix.kuehling@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox