From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C70836D4E8 for ; Tue, 25 Nov 2025 01:01:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764032510; cv=none; b=OALYbzldspQXFznyKCzzNCLBk5mnebKnnINIgFNCNxUWcwYXLpfZdCAkIGSRPESmHuStI9oS0UwPXHviF+DEWoEcrcK+dx+KJC0XXFC77dbVdan7mknyUMx98v25bN5LJb+sEnT3zDCIlFUnyyxUgGU85+gbm6JZLQGxWDn4uMQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764032510; c=relaxed/simple; bh=aS+1cJa75nrWpjPePFv55yi2LEwUdzX1MEm1hb7W8f4=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=AfOKKyNh5g80UY6XcuLGAuWVWBqt3uwqJ3y4A/yOxVulv8q2JsskigTMkvi3xRoIGk55D7WYaGzOQ30sFe5TXRzcASxEVBQgdIZl1tUD02JyVvAxJXT750oxy2EY9T9CC6T4531ObgEnQZ8FgqR1IjB/tWnbW2lHK09hnwHnT4A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DR5GJ8US; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=tpEczuDZ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DR5GJ8US"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="tpEczuDZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764032506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Krdw59DF8mDry2N50mIsRLclxBge7cgrOeMU5xjuesc=; b=DR5GJ8US/ACb9nurPcRmPfjveg6+HN8PBdaJfEHbhpznznfsYIXTLLcTa6Pa0di7jw6qov 6vYBh7nWwX7q4LLqlF9789R283fI2uRcWLpG+C4yxr2vFxq7LQInarTNLwiCX4nviinU/A gvtGFyuHLrRZ6f0KFnRyl/FgZ2Qm0Tg= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-63-1wlIQ1_0Py6uUi33-YA16A-1; Mon, 24 Nov 2025 20:01:44 -0500 X-MC-Unique: 1wlIQ1_0Py6uUi33-YA16A-1 X-Mimecast-MFC-AGG-ID: 1wlIQ1_0Py6uUi33-YA16A_1764032504 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4ee4a0ad6a6so102788641cf.0 for ; Mon, 24 Nov 2025 17:01:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764032504; x=1764637304; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=Krdw59DF8mDry2N50mIsRLclxBge7cgrOeMU5xjuesc=; b=tpEczuDZMitPaaC64nmtIo9o69kwBGB21vIry9+XoSW5TAS9axjJ8BoEqG/3jvZi8N 1kZv+80lpihsSa1XQQz+QaaiDiXmk+xjQrUghsn8g2fKBbWSmADipS6FhcaXmd7wHZ0j yPfh6ykVot861XeYKI0wXz06vcTcP4OdDQZmRPoc8zXNFmfuJD/XtsmJDm0B2WSwX4Qx 3gIiwZVJPJAzTLZ4hywheAPU44QjX7DdysxpccBFId7gSAtAKiprQ1vuHWf9FeOxm6Et LeqtciS+ohzMlRI5v1CFZY44n//ksc0e2eCh6zbkmxWcYktZ0gzeFcK0Eq/kRb6xnik/ 5P9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764032504; x=1764637304; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Krdw59DF8mDry2N50mIsRLclxBge7cgrOeMU5xjuesc=; b=wYHLpdV2EnnV9u5/g6+k6cofa9ecv30sJ76D6UdbEZuykEIZ/UWvLNkf3dfE4WlqW8 Ygcl5VcgdZmwxMAkk2V7t9zRpYHNuPnEkCNprpXzE+rBvUCbI4VGAIG1o8jninCQxzLU 0Joa/3VoJJrDIksb0i7RrzAyMM1jrR/LvSrBKaPLxEouqVPjQDf7g+T1lHwcmELtk2bQ 8FqOnJiZf+hm6fLRRo/EKOsIyuW6kXS0HPYaJF/FZfqMWIS2rmyNwAY/uzVaRzVGzC+i Vab4uVuBnugXFq7ArBshao6+5IFQo0OImIYwCjx+HuHxTSiClahgDRCPX6HueMkSwY8E oSRw== X-Forwarded-Encrypted: i=1; AJvYcCUE8J/kyrV1xdPSjg0ti1vIkc8xJ3MCt+2pPejwjlxPkq1lhKqC8H2VxwNqmigpxYwKnhCxBmAy2AOLmBg=@vger.kernel.org X-Gm-Message-State: AOJu0YyuXR5vXeQcKeU2I5zshdMRkeFrgG7ed0U9tH0CGHDk6m/Ib96x gCWfxgZzZ0vUbKFsbEb6+mIbmkm4lhv1mz+4/eQY58YRZcoZIdH7hMWZfoxq6aQRqZhLkLD+J32 6+TGmWa1H1Zsy6YAfmOJoQ3rjoXRR+IhcBIQVr96OI5LPma2lzAf0GThb084rIqN5zQ== X-Gm-Gg: ASbGncsVMH6VOxktqcCQfLtyIGMe4yck/6REj5jajI3qfyFuS3dGfWhabgGn3cG9By3 4O+Kk4ZlSK0V65wJdqh1oQbT91qHYIQrILXNnwksJ8ASg5HuV5tbxoHlQ6fnlT7o421QKOxUmWp 5cIYb5rxmBSnFllnnL0LX3ZIIF4u2DgumvzoHplJlNND0OxOKMh2Zqn+1M1QvNlOYIalLQcDjNA xdoekRBKyktv0b7AmWBABOKAcHw1Umpi76Rg1vG4lNRQ92IRG69UhaKln5Iuerd5n44nmz7S8Ik Kz1NsVKHhJUFa5hI2SW1yqtWf9BGatXPUPIlf17547D19bRDspGnHQ3BUNXY3VIaZZSrH4/km+h +/i7PFeju0m1F2Gpi01Jlc2GlYvLKla0uDgYz3ipncg== X-Received: by 2002:ac8:5f84:0:b0:4ee:2c3c:6e with SMTP id d75a77b69052e-4efbda49e09mr15667301cf.30.1764032503820; Mon, 24 Nov 2025 17:01:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IHF3NXobiMfICuyWEqcwkYMU0xyrtWHnGIXntf9dW3FH87Z1BqC8via9eZBQaJyMrtfaj5VyQ== X-Received: by 2002:ac8:5f84:0:b0:4ee:2c3c:6e with SMTP id d75a77b69052e-4efbda49e09mr15666251cf.30.1764032502882; Mon, 24 Nov 2025 17:01:42 -0800 (PST) Received: from crwood-thinkpadp16vgen1.minnmso.csb ([2601:447:c680:2b50:ee6f:85c2:7e3e:ee98]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4ee48e8cdebsm97590441cf.31.2025.11.24.17.01.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 17:01:42 -0800 (PST) Message-ID: Subject: Re: [PATCH v1 0/8] tools/rtla: Consolidate common command line options From: Crystal Wood To: Costa Shulyupin , Steven Rostedt , Tomas Glozar , Wander Lairson Costa , Ivan Pravdin , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 24 Nov 2025 19:01:41 -0600 In-Reply-To: <20251121174504.519230-1-costa.shul@redhat.com> References: <20251121174504.519230-1-costa.shul@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2025-11-21 at 19:44 +0200, Costa Shulyupin wrote: > Argument parsing functions are the longest functions of the project: >=20 > lizard --warnings_only --sort nloc -L100 | head -n 4 > ./src/timerlat_hist.c:766: warning: timerlat_hist_parse_args has 247 NLOC= , 76 CCN, 1579 token, 1 PARAM, 287 length, 0 ND > ./src/timerlat_top.c:538: warning: timerlat_top_parse_args has 217 NLOC, = 64 CCN, 1338 token, 2 PARAM, 262 length, 0 ND > ./src/osnoise_hist.c:469: warning: osnoise_hist_parse_args has 195 NLOC, = 56 CCN, 1225 token, 1 PARAM, 216 length, 0 ND > ./src/osnoise_top.c:322: warning: osnoise_top_parse_args has 169 NLOC, 46= CCN, 1019 token, 2 PARAM, 191 length, 0 ND >=20 > Moreover, they contain a lot of duplicate code and growing. >=20 > Refactor these functions to reduce code duplication. >=20 > Benefits: > - Single implementation for common options > - Easier maintenance and consistent behavior >=20 > Costa Shulyupin (8): > tools/rtla: Add common_parse_options() > tools/rtla: Consolidate -c/--cpus option parsing > tools/rtla: Consolidate -C/--cgroup option parsing > tools/rtla: Consolidate -D/--debug option parsing > tools/rtla: Consolidate -d/--duration option parsing > tools/rtla: Consolidate -e/--event option parsing > tools/rtla: Consolidate -P/--priority option parsing > tools/rtla: Consolidate -H/--house-keeping option parsing >=20 > tools/tracing/rtla/src/common.c | 78 ++++++++++++++++++++++++++ > tools/tracing/rtla/src/common.h | 1 + > tools/tracing/rtla/src/osnoise_hist.c | 53 ++--------------- > tools/tracing/rtla/src/osnoise_top.c | 53 ++--------------- > tools/tracing/rtla/src/timerlat_hist.c | 53 ++--------------- > tools/tracing/rtla/src/timerlat_top.c | 52 ++--------------- > 6 files changed, 95 insertions(+), 195 deletions(-) Reviewed-by: Crystal Wood -Crystal