Re: [PATCH] Input: hgpk - remove protocol support

[Andres Salomon <dilinger@queued.net>]

That seems fair. I haven't had access to OLPC hardware in just about as 
long. If you need it:

Acked-by: Andres Salomon <dilinger@queued.net>


On 3/10/26 20:43, Dmitry Torokhov wrote:
> The protocol flavor for ALPS touchpads found in OLPC laptops has been
> broken since 2015 commit c378b5119eb0 ("Input: psmouse - factor out
> common protocol probing code") that forgot to add hgpk_init() to HGPK
> entry in psmouse_protocols array.
> 
> Since nobody complained for 10 years let's remove it.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>   drivers/input/mouse/Kconfig        |   10 -
>   drivers/input/mouse/Makefile       |    1 -
>   drivers/input/mouse/hgpk.c         | 1063 ----------------------------
>   drivers/input/mouse/hgpk.h         |   61 --
>   drivers/input/mouse/psmouse-base.c |   21 +-
>   drivers/input/mouse/psmouse.h      |    2 +-
>   6 files changed, 2 insertions(+), 1156 deletions(-)
> 
> diff --git a/drivers/input/mouse/Kconfig b/drivers/input/mouse/Kconfig
> index 833b643f0616..30d119d4634b 100644
> --- a/drivers/input/mouse/Kconfig
> +++ b/drivers/input/mouse/Kconfig
> @@ -164,16 +164,6 @@ config MOUSE_PS2_TOUCHKIT
>   
>   	  If unsure, say N.
>   
> -config MOUSE_PS2_OLPC
> -	bool "OLPC PS/2 mouse protocol extension"
> -	depends on MOUSE_PS2 && OLPC
> -	help
> -	  Say Y here if you have an OLPC XO-1 laptop (with built-in
> -	  PS/2 touchpad/tablet device).  The manufacturer calls the
> -	  touchpad an HGPK.
> -
> -	  If unsure, say N.
> -
>   config MOUSE_PS2_FOCALTECH
>   	bool "FocalTech PS/2 mouse protocol extension" if EXPERT
>   	default y
> diff --git a/drivers/input/mouse/Makefile b/drivers/input/mouse/Makefile
> index a1336d5bee6f..137ed0c32d90 100644