From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751288AbdJWF6K (ORCPT ); Mon, 23 Oct 2017 01:58:10 -0400 Received: from mout.web.de ([212.227.15.14]:57572 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751043AbdJWF6J (ORCPT ); Mon, 23 Oct 2017 01:58:09 -0400 Subject: Re: extcon: max14577: Use common error handling code in max14577_muic_set_path() To: Chanwoo Choi , kernel-janitors@vger.kernel.org Cc: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , MyungJoo Ham , LKML References: <5cdefd84-066d-5379-43c8-76f5d3b8f7c4@users.sourceforge.net> <59ED3E72.7010401@samsung.com> <59ED83FA.5000701@samsung.com> From: SF Markus Elfring Message-ID: Date: Mon, 23 Oct 2017 07:57:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <59ED83FA.5000701@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Rjm8lgU3ZlIvTPfnb87RRqbioqJUlPiD2WCkRURccEO4wOrbW0S 6xA2ebplunsIIAbj8v09FsJJ227jcgwmrdZkKutaJ+2Chl8uO0O8yydU1QWAI7FqE3yDdGH XBDJFEilIyhiy5o7cZ07nKRa5PDTSX8SJaedSkEdc86vJ2WBj4pQH39HuG/5h+RHuOR2utr FZ02SRoY8L2LNogrYE/fw== X-UI-Out-Filterresults: notjunk:1;V01:K0:/HVen2kwLkc=:1FZCWrSZkwc6R7symZIhxa mgpWOrM7stmBx9h+gVwphjbDwjIWBnC1ejpumjOBvfq8LzOs1E/1aFal5eXDovtPNiDD1lvZK pg5Y2FvmEW4XTfWXkW6EdKLZ55Jlp0WkAI2cUrWZZgAbvN2ZY6lGKsPVweXzvzHqYvy3chdWv ldxoo7in81En0qk7klFtT3eHVWSR4EFYdn8mM0oV/+xnxQ0oEO0saJR4fEyLoOAxiBi+9A5NE NGuCEu01cfqeekOXCOd8E2B52NitGabiS9VTqa//tl3U6+lImALW4uKbzmna2whfXwUyjrdSp h8wNWZazcswwg2MsLwzPN/GPaG74mMjNqmfJfu8h2NSfS++cnmricEibXH6ZMLnrhW1NgV12b bhcFjwBX8sgJ0Hi0QX9SKE09XTiWFc6Lk5/Y0s/xyL4pxSU9Nxu/HOY3SuQ7wy9Z+S1rHZvnS ES2FkdQbdJ1O0qxMbhypiGTBTVbH+J8CQ7i1ncRYpVgU5IqnZwM9vPIZKji+ATiFbJhwOFLdE k0CpG34ZerZKugtj7dSNH+tMOVQyiArAHjo1ReN3qWD+5Dd9Uz4KZFLjTHdh8u5Q3vuhKrR30 6yk0VIBN+Sz11o88Au7qGFTG/Hz1LBi5KXeAn3uB7W3L05KOmKgF6f3vUHLW12tj5YJSF0Cbd eF+tIShudN/ohLISA4M6zDhZwuDDMnssGxSCA36/bVHX5PJZWsS2I6CBt3x4OYoYb77Co2dDj HnBu8meQwkvKubkdCK8yWq7f320z2gwAb0yksozBA8CCWx3/iBN66DDl9RGKVSx1r/0Gi07E4 r5lqijdarqI8C9HySzt2yTRLFt5jMxcJv4jlvfVBujjtOU3LHo= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I think that there is any benefit of this patch. > Also, as I commented, it make the code more complicated. We have got different software development opinions about the shown change possibilities then. Regards, Markus