From: Edward Cree <ecree.xilinx@gmail.com>
To: Moon Yeounsu <yyyynoom@gmail.com>, Eric Dumazet <edumazet@google.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
linux@weissschuh.net, j.granados@samsung.com,
judyhsiao@chromium.org, James.Z.Li@dell.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Simon Horman <horms@kernel.org>,
linux-sparse@vger.kernel.org
Subject: Re: [PATCH net] net: add inline annotation to fix the build warning
Date: Thu, 3 Oct 2024 17:11:26 +0100 [thread overview]
Message-ID: <e5cb1a17-72e1-529c-0f46-404dcdb3e5f3@gmail.com> (raw)
In-Reply-To: <CAAjsZQxkH8nmHchtFFPm5VouLEaViR5HTRCCnrP0d9jSF2pGAQ@mail.gmail.com>
On 03/10/2024 16:33, Moon Yeounsu wrote:
> On 03/10/2024 15:19, Eric Dumazet wrote:
>> It also does not know about conditional locking, it is quite useless.
> So... What do you think about who wants to send the patch to silence
> the Sparse's warning message, nevertheless?
Fwiw, my experience is that if I can't explain the locking to sparse
that's usually a sign that the code is too complex and needs to be
rewritten.
In general I'm in favour of patches to fix sparse warnings. In this
case it looks like what's needed is __cond_acquires, but the patch
to implement that in sparse[1] doesn't seem to have gotten anywhere
near Luc's tree. (Yet it's present and occasionally used in the
kernel...) CCing the sparse ML to find out why.
-ed
[1]: https://lore.kernel.org/all/CAHk-=wjZfO9hGqJ2_hGQG3U_XzSh9_XaXze=HgPdvJbgrvASfA@mail.gmail.com/#t
next prev parent reply other threads:[~2024-10-03 16:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 19:33 [PATCH net] net: add inline annotation to fix the build warning Moon Yeounsu
[not found] ` <CAAjsZQx1NFdx8HyBmDqDxQbUvcxbaag5y-ft+feWLgQeb1Qfdw@mail.gmail.com>
2024-10-02 14:41 ` Eric Dumazet
2024-10-03 13:56 ` Moon Yeounsu
2024-10-03 14:19 ` Eric Dumazet
2024-10-03 15:33 ` Moon Yeounsu
2024-10-03 16:11 ` Edward Cree [this message]
2024-10-03 18:39 ` Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2024-09-19 14:21 Moon Yeounsu
2024-09-19 14:56 ` Simon Horman
2024-09-20 7:27 ` Moon Yeounsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5cb1a17-72e1-529c-0f46-404dcdb3e5f3@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=James.Z.Li@dell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=j.granados@samsung.com \
--cc=judyhsiao@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yyyynoom@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox