From: Dennis Dalessandro <dennis.dalessandro@intel.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
Mike Marciniszyn <infinipath@intel.com>,
Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IB/qib: remove duplicate code
Date: Thu, 8 Jun 2017 09:14:44 -0400 [thread overview]
Message-ID: <e5d9e8ea-460c-5318-e218-44449e6a3af7@intel.com> (raw)
In-Reply-To: <20170607204202.GA29640@embeddedgus>
On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote:
> Remove duplicate code.
>
> Addresses-Coverity-ID: 1226951
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/infiniband/hw/qib/qib_mad.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/qib/qib_mad.c b/drivers/infiniband/hw/qib/qib_mad.c
> index da295e0..c5eaa3c 100644
> --- a/drivers/infiniband/hw/qib/qib_mad.c
> +++ b/drivers/infiniband/hw/qib/qib_mad.c
> @@ -874,8 +874,6 @@ static int subn_set_portinfo(struct ib_smp *smp, struct ib_device *ibdev,
> ib_dispatch_event(&event);
> }
>
> - ret = subn_get_portinfo(smp, ibdev, port);
> -
> /* restore re-reg bit per o14-12.2.1 */
> pip->clientrereg_resv_subnetto |= clientrereg;
>
>
Would be nice to see a few more words in the commit message rather than
having to go look for Coverity.
Regardless, patch seems fine to me code wise.
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
next prev parent reply other threads:[~2017-06-08 13:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 20:42 [PATCH] IB/qib: remove duplicate code Gustavo A. R. Silva
2017-06-08 10:37 ` Leon Romanovsky
2017-06-08 13:14 ` Dennis Dalessandro [this message]
2017-06-08 19:52 ` Gustavo A. R. Silva
2017-07-22 17:20 ` Doug Ledford
2017-07-22 17:22 ` Doug Ledford
2017-07-22 17:29 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5d9e8ea-460c-5318-e218-44449e6a3af7@intel.com \
--to=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=garsilva@embeddedor.com \
--cc=hal.rosenstock@gmail.com \
--cc=infinipath@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox