From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 1603F367F3A
	for <linux-kernel@vger.kernel.org>; Wed,  6 May 2026 10:51:09 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1778064671; cv=none; b=d1gkMcS7mHreCeThJNMBPLIHPxiWdEBt7R/ZxFTvvS37c1iAPKhcgI4LC3CYfhCI+dkJ4yVyAbBHKqQleRY5asN4nUWgUeJUG98lU7eo9EXEln647I7ttDwgfJO9dZ84bNWhDSMaYLr2sltKPfnxiP7FijAnhAO5N1z8vx6GEo4=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1778064671; c=relaxed/simple;
	bh=PZ1iUB0RxbPS8q6Nb8xA/1Bvd/Xi1nF2JHa2HPakoCk=;
	h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:
	 MIME-Version:Content-Type; b=Nj1Piwrm2WpomMV7XZN45SlWlByfkcL9qKodcG4jNXIf5UbvQVT3ujKdHo9NK6GmjPjzoXWWAUyE9EnTwj3Uu/m0UW3MIi5A3SwEM8ImgrnYOrbmk4DEzYTsCf0z5euamkZJdP+uVXW3twBH/uz2Ul8/hIWUdfvrqAMdTVeFcfE=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=kusQ4HiX; arc=none smtp.client-ip=13.77.154.182
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="kusQ4HiX"
Received: by linux.microsoft.com (Postfix, from userid 1241)
	id 426CB20B7165; Wed,  6 May 2026 03:51:07 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 426CB20B7165
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1778064667;
	bh=zI1hkKPltBSit8ayPUyw9h14Py8v3FaTivUchg53AOk=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=kusQ4HiXykMA/hgSWJLc6Y6vhxd5FVAOx8aSWJkOpeZ8HHGv6PHywmCKwhIlkxB+G
	 5Pu0NXOhpsiTJLLLjzY7ZyeBpX+wUa18e3yr7w620v0FHQBTvxyvYL6Yo1K9pmrj5f
	 cQKs6VAZwvmPQrPR56XFYdvHowJNq1Qe25fCBUJU=
Received: from localhost (localhost [127.0.0.1])
	by linux.microsoft.com (Postfix) with ESMTP id 404A430705A3;
	Wed,  6 May 2026 03:51:07 -0700 (PDT)
Date: Wed, 6 May 2026 03:51:07 -0700 (PDT)
From: Jork Loeser <jloeser@linux.microsoft.com>
To: Pratyush Yadav <pratyush@kernel.org>
cc: Mike Rapoport <rppt@kernel.org>, 
    Pasha Tatashin <pasha.tatashin@soleen.com>, 
    Alexander Graf <graf@amazon.com>, Muchun Song <muchun.song@linux.dev>, 
    Oscar Salvador <osalvador@suse.de>, David Hildenbrand <david@kernel.org>, 
    Andrew Morton <akpm@linux-foundation.org>, Jason Miu <jasonmiu@google.com>, 
    kexec@lists.infradead.org, linux-mm@kvack.org, 
    linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/12] kho: add kho_radix_init_tree()
In-Reply-To: <20260429133928.850721-9-pratyush@kernel.org>
Message-ID: <e5e9c15f-a030-423e-de79-757c20d084e1@linux.microsoft.com>
References: <20260429133928.850721-1-pratyush@kernel.org> <20260429133928.850721-9-pratyush@kernel.org>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed

On Wed, 29 Apr 2026, Pratyush Yadav wrote:

> From: "Pratyush Yadav (Google)" <pratyush@kernel.org>
>
> Move the initialization logic of the radix tree into
> kho_radix_init_tree() instead of having users open-code it. Makes the
> boundaries cleaner and reduces code duplication when a new user of the
> radix tree will be added in a future commit.

Consider using kho_radix_init_tree() in kho_init() as well. This will also 
remove the kzalloc() one-off use. Similar for kho_radix_destroy_tree().

Best,
Jork