From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41703C33CAF for ; Thu, 23 Jan 2020 19:15:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D08920718 for ; Thu, 23 Jan 2020 19:15:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729019AbgAWTPv (ORCPT ); Thu, 23 Jan 2020 14:15:51 -0500 Received: from foss.arm.com ([217.140.110.172]:43574 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727590AbgAWTPv (ORCPT ); Thu, 23 Jan 2020 14:15:51 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A28A71FB; Thu, 23 Jan 2020 11:15:50 -0800 (PST) Received: from [192.168.0.7] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B70123F52E; Thu, 23 Jan 2020 11:15:48 -0800 (PST) Subject: Re: [Patch v8 1/7] sched/pelt: Add support to track thermal pressure To: Peter Zijlstra , Thara Gopinath Cc: mingo@redhat.com, ionela.voinescu@arm.com, vincent.guittot@linaro.org, rui.zhang@intel.com, qperret@google.com, daniel.lezcano@linaro.org, viresh.kumar@linaro.org, linux-kernel@vger.kernel.org, amit.kachhap@gmail.com, javi.merino@kernel.org, amit.kucheria@verdurent.com References: <1579031859-18692-1-git-send-email-thara.gopinath@linaro.org> <1579031859-18692-2-git-send-email-thara.gopinath@linaro.org> <20200116151724.GR2827@hirez.programming.kicks-ass.net> From: Dietmar Eggemann Message-ID: Date: Thu, 23 Jan 2020 20:15:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200116151724.GR2827@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/01/2020 16:17, Peter Zijlstra wrote: > On Tue, Jan 14, 2020 at 02:57:33PM -0500, Thara Gopinath wrote: > >> diff --git a/kernel/sched/pelt.h b/kernel/sched/pelt.h >> index afff644..bf1e17b 100644 >> --- a/kernel/sched/pelt.h >> +++ b/kernel/sched/pelt.h >> @@ -7,6 +7,16 @@ int __update_load_avg_cfs_rq(u64 now, struct cfs_rq *cfs_rq); >> int update_rt_rq_load_avg(u64 now, struct rq *rq, int running); >> int update_dl_rq_load_avg(u64 now, struct rq *rq, int running); >> >> +#ifdef CONFIG_HAVE_SCHED_THERMAL_PRESSURE I assume your plan is to enable this for Arm and Arm64? Otherwise the code in 3/7 should also be guarded by this. diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index e688dfad0b72..9eb414b2c8b9 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -164,6 +164,7 @@ config ARM64 select HAVE_FUNCTION_ARG_ACCESS_API select HAVE_RCU_TABLE_FREE select HAVE_RSEQ + select HAVE_SCHED_THERMAL_PRESSURE select HAVE_STACKPROTECTOR select HAVE_SYSCALL_TRACEPOINTS Currently it lives in the 'CPU/Task time and stats accounting' of .config which doesn't feel right to me. [...]