From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7594C393DE2; Mon, 25 Aug 2025 05:47:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756100834; cv=none; b=diNgbjQhdoDBGq6SOJ4SXq058HfdUINMmHgcHEVCGEwYYnzFAHxRVKPSa8thMG9hrespyABAIbOfeod4KhYZOvPFCQg0LN84UdtECdEu0+6Nq/rMM8fMLsbIUiC1xFVuLx0tJnVsFlisW5H3cH11cEhow0YbBLskC2rFD+JXepI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756100834; c=relaxed/simple; bh=KIpZrilMyDhMs2KjP9vVMOlzp7ua5A9NIoB9V+D8X5w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pc6VvhTYimF/O+0PtFiPOo0L1kAVjnT9RFBn8zIsrbikOX1D93xmGOyzIYvqQbMhy4ajra/irc0v9/5sP5FztYcpWM9ZS8j4qq7j8aQ2zMakKjSEvbDdXDtjxdpIzRbzK6LxJsH2NCSp52wA9yawNAGDEnSa/Y5AA1sz9pJyR1w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XCm/YHhD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XCm/YHhD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5DE9C4CEED; Mon, 25 Aug 2025 05:47:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756100833; bh=KIpZrilMyDhMs2KjP9vVMOlzp7ua5A9NIoB9V+D8X5w=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=XCm/YHhDqpTRviNCUdUMpF2rm8QP466vjAKbuiE9jjqBSA5d+2Asnn571rJ9azQZI vtc1t0vLIyfA5bYcBGqKqQ9hTcvEMUbVZjl8d0EqwyLjnpgWTdwyrQZV9vY3ta5TZi B5VHeoFlOjdfds2wZp+eudBGMdMEyWhbf4NLgMzs2ydxYpCNwWj0jyemu0/8uhfTl2 wV0xfca8ZiZ3XP+dDzUxYTyCUHLxCHpKq0/uNK4C1l0ELrbFWHfmLH4nwEbG/qm685 PGKl+PmgnICx3DUeA/e9EYzFE3rA0JvjrakyAbUzl1Kf0Liehzy1vYaOdElLuh5muM JFqyKGeOyz1JQ== Message-ID: Date: Mon, 25 Aug 2025 07:47:10 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] vt: add support for smput/rmput escape codes To: Calixte Pernot , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org References: <20250824142016.47219-1-calixte.pernot@grenoble-inp.org> Content-Language: en-US From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <20250824142016.47219-1-calixte.pernot@grenoble-inp.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 24. 08. 25, 16:20, Calixte Pernot wrote: > Support "\e[?1049h" and "\e[?1049l" escape codes. > This patch allows programs to enter and leave alternate screens. > This feature is widely available in graphical terminal emulators and mostly > used by fullscreen terminal-based user interfaces such as text editors. > Most editors such as vim and nano assume this escape code in not supported > and will not try to print the escape sequence if TERM=linux. > To try out this patch, run `TERM=xterm-256color vim` inside a VT. > > Signed-off-by: Calixte Pernot ... > --- a/drivers/tty/vt/vt.c > +++ b/drivers/tty/vt/vt.c ... > @@ -1878,6 +1883,46 @@ static int get_bracketed_paste(struct tty_struct *tty) > return vc->vc_bracketed_paste; > } > > +/* console_lock is held */ > +static void enter_alt_screen(struct vc_data *vc) > +{ > + unsigned int size = vc->vc_rows * vc->vc_cols * 2; > + > + if (vc->vc_saved_screen != NULL) > + return; /* Already inside an alt-screen */ All this is protected by console_lock, right? > + vc->vc_saved_screen = kzalloc(size, GFP_NOWAIT); Why GFP_NOWAIT? > + if (vc->vc_saved_screen == NULL) > + return; > + memcpy(vc->vc_saved_screen, (u16 *)vc->vc_origin, size); kmemdup(); > + vc->vc_saved_rows = vc->vc_rows; > + vc->vc_saved_cols = vc->vc_cols; > + save_cur(vc); > + /* clear entire screen */ > + csi_J(vc, CSI_J_FULL); > +} > + > +/* console_lock is held */ > +static void leave_alt_screen(struct vc_data *vc) > +{ > + unsigned int rows = min(vc->vc_saved_rows, vc->vc_rows); > + unsigned int cols = min(vc->vc_saved_cols, vc->vc_cols); > + unsigned short *src, *dest; u16 > + > + if (vc->vc_saved_screen == NULL) > + return; /* Not inside an alt-screen */ > + for (int r = 0; r < rows; r++) { unsigned > + src = vc->vc_saved_screen + r * vc->vc_saved_cols; > + dest = ((u16 *)vc->vc_origin) + r * vc->vc_cols; > + memcpy(dest, src, 2 * cols); > + } > + restore_cur(vc); > + /* Update the entire screen */ > + if (con_should_update(vc)) > + do_update_region(vc, vc->vc_origin, vc->vc_screenbuf_size / 2); > + kfree(vc->vc_saved_screen); > + vc->vc_saved_screen = NULL; > +} ... > --- a/include/linux/console_struct.h > +++ b/include/linux/console_struct.h > @@ -159,6 +159,9 @@ struct vc_data { > struct uni_pagedict *uni_pagedict; > struct uni_pagedict **uni_pagedict_loc; /* [!] Location of uni_pagedict variable for this console */ > u32 **vc_uni_lines; /* unicode screen content */ > + unsigned short *vc_saved_screen; u16 * > + unsigned int vc_saved_cols; > + unsigned int vc_saved_rows; > /* additional information is in vt_kern.h */ > }; > thanks, -- js suse labs