From: Joe Perches <joe@perches.com>
To: Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC 1/3] checkpatch: add verbose mode
Date: Tue, 26 Jan 2021 14:44:20 -0800 [thread overview]
Message-ID: <e5fcdc9ff8b165ed142340135e2124d013b79ac9.camel@perches.com> (raw)
In-Reply-To: <CABJPP5Ap2=-suEZv+6OVONBPZjLEJEszG=O5ikDxHPiCcBRbFA@mail.gmail.com>
On Wed, 2021-01-27 at 01:57 +0530, Dwaipayan Ray wrote:
> On Wed, Jan 27, 2021 at 1:41 AM Joe Perches <joe@perches.com> wrote:
> > On Wed, 2021-01-27 at 00:05 +0530, Dwaipayan Ray wrote:
> > > Add a new verbose mode to checkpatch.pl to emit additional verbose
> > > test descriptions.
> > >
> > > The verbose mode is optional and can be enabled by the flag
> > > --verbose.
[]
> > > Documentation/dev-tools/checkpatch.rst:
> > >
> > > .. CHECKPATCH_START
> >
> > Nak on the keyword uses.
> >
> > This should really just parse the input file whenever TYPE is found
> > via some fixed format and save the verbose description after that.
> >
> > Use .rst Field Lists instead, and ideally, keep the list in alphabetic
> > order or group by similar use.
> >
> > https://docutils.sourceforge.io/docs/user/rst/quickref.html#field-lists
> >
> > e.g.:
> >
> > :LINE_SPACING:
> > Vertical space is wasted given the limited number of lines an
> > editor window can display when multiple blank lines are used.
> >
> > :SPACING:
> > Whitespace style used in the kernel sources is described in
> > ref:`Documentation/process/Coding-Style.rst section 3.1.
> >
> > :TRAILING_WHITESPACE:
> > Trailing whitespace should always be removed.
> > Some editors highlight the trailing whitespace and cause visual
> > distractions when editing files.
> >
> > etc...
[]
> for the output part can we do something to make the text
> look a bit more nice? I think some of the verbose descriptions
> can go a bit long.
Which is why verbose should be optional.
> Also will the verbose descriptions be limited to say single
> paragraphs?
Ideally, no.
> If there are multiple paragraphs then the output
> does appear a bit messy.
I fail to see how that's a problem but play with it and see what
you can do.
next prev parent reply other threads:[~2021-01-27 13:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 18:35 [PATCH RFC 0/3] checkpatch: add verbose mode Dwaipayan Ray
2021-01-26 18:35 ` [PATCH RFC 1/3] " Dwaipayan Ray
2021-01-26 20:11 ` Joe Perches
2021-01-26 20:27 ` Dwaipayan Ray
2021-01-26 22:44 ` Joe Perches [this message]
2021-01-26 18:35 ` [PATCH RFC 2/3] docs: add documentation for checkpatch Dwaipayan Ray
2021-01-26 18:35 ` [PATCH RFC 3/3] " Dwaipayan Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5fcdc9ff8b165ed142340135e2124d013b79ac9.camel@perches.com \
--to=joe@perches.com \
--cc=dwaipayanray1@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox