From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71F5F409137 for ; Tue, 30 Jun 2026 12:00:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782820830; cv=none; b=IRXGvDmF0MbviUTvoiE3wxp1rbSbL7I3mNjbwPJQAc1t+zMm5LqRTXgD11zq065EgQk8dPnkc8EAl4OALSKLAu8zyhYoEUFDYIOXZiQJKeR6PCAQmqjFXontQPqtjoxVm+npmVzIZPaxgPAENmDuRH16nCldnSiXW/hPIYz1n3c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782820830; c=relaxed/simple; bh=w7L5Tp+hZz2TDhwz1Qm9WD2gfKZhpAFFy+VHrf2oVjM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jLLwUKvfpXf0U5LwAtQ8h+mjWz6Nfl7VXj9PEc2IIezYFvnePmwRjj2wUUuNcybp7VKPiPQzKvZdlcMuPfguPWnO3WEkEdRnXMqhgIUbLRyiqsERSUweXXRNjh4BiJnY77gA6zhCEmoAsGkPOjtBBW8ldz8zVypDuuZWFIhrz+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZLn9+zh6; arc=none smtp.client-ip=209.85.215.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZLn9+zh6" Received: by mail-pg1-f193.google.com with SMTP id 41be03b00d2f7-c99eaa1f020so1519543a12.2 for ; Tue, 30 Jun 2026 05:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782820828; x=1783425628; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rQJzhkIkVPlkRxcrVSAS1/qxSmuU/Saa7J0AIvXGGuk=; b=ZLn9+zh6g7s09kkYTNvmo1mjC93ewFZ1NNf/pGFLSP8YEcFiLLbKg2y4J36FstXMjN zaWlxvV3TCkFcU/TfPZGmtG+oYc7NHPrKTFCeFQd0vVxraGYHNizWL9j8nlTH588v0yW snZ+oUffLP323FPkVHlklgoQnS2r8aKlJ7kuoP7iNNK7DcbnApOhNXEfmso0SVTdfJ7W Mwfq9XpGvobs6DDBiDXv4kPTMrCBxfE0aEBR9k3LDS/RVtF/f83DiDybAO79FaVj/rIq fKyktX3CMqSWEiM6sprJRF0fVsxSOxfugjw3pS9K14QDp5uH/fVByi5/8yKb3iGKPzib 2PHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782820828; x=1783425628; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rQJzhkIkVPlkRxcrVSAS1/qxSmuU/Saa7J0AIvXGGuk=; b=Oz7aayB5f9kgcHwHY/K9dK1KTb6Xc84U+D8yeFwTrQUq1HJPHUW+84Fyvh5Pka2eDv TAdEbUVlxxxhLmpCYl2A0yyQ7IXDmxl7iSu9OCepnZsLpOYzPVfaCvyPfw4KQ2/RxwPf VW5ZaS2w72+oQ5GIYM3FIc25Fn/RbVDX8qh1rw6GGWneiwE3PbGr90go2SOzjZXhjHw9 xHqtZNyEP4Q8F5Q/a/SD55wBPRAqjeJ4mTJJhP3q1MGiFWxcKLs7TVycgkzxONJSF10u ni3s2IcC5ecRWkb63UiE0kv1SZyKeCVm1yQiZvWPzxYaOh9LFsSpJUNId+xBnJnDHomV UmAA== X-Forwarded-Encrypted: i=1; AHgh+RpUX4OMa7GhLqUy6Hbkbr5E3yndpCONpcv+1Y9IBaMiu1Mu6UkkZ1TVJx234UPyfFBfGQKkei/NvWh++YI=@vger.kernel.org X-Gm-Message-State: AOJu0YzxE2V+MeVYHXpQ+J1eJDqQq214SATT1qU7AelWIA2Agz/u6gVQ rfo7ckuiw/3J/6lz5YnEFM9iWqx0eL/h0DGx7PVDYATYjxbXknPyc6yd X-Gm-Gg: AfdE7ck1uN61ycMDoZ9KbeaiEduUFoETe5zkLF19Uy3nd5PNiqvYTSDQ/eHl1Idq3iy Ga3LgZZSjum7qP0N3hfSrBL+azNAfDAAkHn+DL1ynVkvFsE7J58ia4TjpQkzz6t/SRkTy9GaUy2 7Iuy8OR7P6oTIfnT4dmZrrjXGRsHMImn2ph8uXOW8xiCUK9Qn0C8neieIcp9DzeHckRITC57nqu iS8Vw5XGsefmwETBy8jVZ9lWk6u1wxPmFalywFihzhJfuuiCcorf68BXdffRuLiwqqDThjvC+Af WdLm9EBv/faM2Ne4tx7EnZD7sBqqGGNVVwD162G4K+fr21YgqOpAWBie1o62BkoWQZJz+X9RN7l 1hBFsiJSgUqSOCevAjSRPKZXjURmdjHRRh/bPUh/E/2LwzFxfBTtGAkAokhAxvKk9MKBrhjelCP fjY/4Yr+gyZFyCNB7OA1xG X-Received: by 2002:a05:6a00:1ca1:b0:847:902a:57b5 with SMTP id d2e1a72fcca58-8479f2175cbmr2758259b3a.35.1782820827394; Tue, 30 Jun 2026 05:00:27 -0700 (PDT) Received: from [10.125.112.20] ([210.184.73.204]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847a02cd39asm1834294b3a.34.2026.06.30.05.00.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 05:00:26 -0700 (PDT) Message-ID: Date: Tue, 30 Jun 2026 20:00:16 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 09/10] riscv: kdump: exclude non-dumpable reserved memory regions from vmcore To: Pratyush Yadav Cc: chenhuacai@kernel.org, kernel@xen0n.name, pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, robh@kernel.org, saravanak@kernel.org, bhe@redhat.com, rppt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, kexec@lists.infradead.org, iommu@lists.linux.dev, zhaomeijing@lixiang.com, catalin.marinas@arm.com, will@kernel.org, alex@ghiti.fr, akpm@linux-foundation.org, pasha.tatashin@soleen.com, ruirui.yang@linux.dev, m.szyprowski@samsung.com, robin.murphy@arm.com References: <20260630074715.4126796-1-chenwandun1@gmail.com> <20260630074715.4126796-10-chenwandun1@gmail.com> <2vxzechoi8o0.fsf@kernel.org> Content-Language: en-US From: Wandun In-Reply-To: <2vxzechoi8o0.fsf@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/30/26 19:12, Pratyush Yadav wrote: > On Tue, Jun 30 2026, Wandun Chen wrote: > >> From: Wandun Chen >> >> Apply the same non-dumpable reserved memory filtering to RISC-V kdump >> as was done for arm64. Use of_reserved_mem_kdump_exclude() to drop >> flagged regions from the elfcorehdr PT_LOAD segments, and >> of_reserved_mem_kdump_nr_ranges() to pre-size the crash_mem array. >> >> Signed-off-by: Wandun Chen >> --- >> arch/riscv/kernel/machine_kexec_file.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/riscv/kernel/machine_kexec_file.c b/arch/riscv/kernel/machine_kexec_file.c >> index 59d4bbc848a8..25359d583bc3 100644 >> --- a/arch/riscv/kernel/machine_kexec_file.c >> +++ b/arch/riscv/kernel/machine_kexec_file.c >> @@ -10,6 +10,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -64,6 +65,7 @@ static int prepare_elf_headers(void **addr, unsigned long *sz) >> >> nr_ranges = 1; /* For exclusion of crashkernel region */ >> walk_system_ram_res(0, -1, &nr_ranges, get_nr_ram_ranges_callback); >> + nr_ranges += of_reserved_mem_kdump_nr_ranges(); >> >> cmem = kmalloc_flex(*cmem, ranges, nr_ranges); >> if (!cmem) >> @@ -77,6 +79,8 @@ static int prepare_elf_headers(void **addr, unsigned long *sz) >> >> /* Exclude crashkernel region */ >> ret = crash_exclude_mem_range(cmem, crashk_res.start, crashk_res.end); >> + if (!ret) >> + ret = of_reserved_mem_kdump_exclude(cmem); >> if (!ret) >> ret = crash_prepare_elf64_headers(cmem, true, addr, sz); > > Nit: can you do the usual pattern of if (err) goto err; instead? > Sure, will fix in the next version. Best regards, Wandun > So this would look like: > > /* Exclude crashkernel region */ > ret = crash_exclude_mem_range(cmem, crashk_res.start, crashk_res.end); > if (ret) > goto out; > > ret = of_reserved_mem_kdump_exclude(cmem); > if (ret) > goto out; > > ret = crash_prepare_elf64_headers(cmem, true, addr, sz); > out: > ... > > With this, > > Acked-by: Pratyush Yadav >