From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0624A15531A for ; Sat, 5 Oct 2024 16:58:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728147515; cv=none; b=ErS2OPARTQk5XK541dJ8bB+Y09aJLoiEtCpFPYCkjRpJZ/Dir+yzRCbQTAXaUBkqIRTyOsGwTXJuQTefBmQVk8ewdClclS8jv+YpB3UvkPEPX//5BsThBpGxXtF2SEmlYuxcYFK0lb71WU/uZkoB1YIMGG2w/ao/buzEnMzf4js= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728147515; c=relaxed/simple; bh=5T4U1UHrigNQBk+mJQwGMPE/eTCGy/9RZiUgKQnFmlQ=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=JjGHBmbXl8agh1K0p/n9YUQpTeyTnJh3LjfKhzycutS8X9zcfT/7YbZgo2Eiw8HgkN9ltIW0Gq2KEYGAr55KiVUwlBfYeEJ3c7PhzbZvC+4tDgzJDAb19I+QZ7a/5rOtS5T0KXBLzTKEa437oiKrkCgSMDg/YaFC1iQNA6vWaiI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=marek.ca; spf=pass smtp.mailfrom=marek.ca; dkim=pass (2048-bit key) header.d=marek.ca header.i=@marek.ca header.b=fo9g685j; arc=none smtp.client-ip=209.85.219.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=marek.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=marek.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marek.ca header.i=@marek.ca header.b="fo9g685j" Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-6cb27e974ceso21152786d6.1 for ; Sat, 05 Oct 2024 09:58:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marek.ca; s=google; t=1728147513; x=1728752313; darn=vger.kernel.org; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc :subject:date:message-id:reply-to; bh=534BF0P5lE7Sw6EXBB2MdGwppSsVFm73Tau4PbJd3Pc=; b=fo9g685jiYKwVwKPeGyQPpTLyL/6Ndbzovf7A4GMg0SnJA0Qrzr4V6h4SrpWDF5v5S T0+9M616riiO3Pwr0RRdH3V/4bbAs61naERXXRaRNgP1tkGjT6TswbpEBtLaqDaJ5CZN mdYHIDbukQe9RU11/cnB+StAuktNA6znDUU/LrtTpslF8knQAvCqw1mgGWsTyox+R/iT Z1azhSgGScz/sQ8LFouJlyzGQfrF7qTOHbGFrYHhoR37zERqz/f//NzKplYCqAag2lgK ah3SBMlq4MmGxe9iHMnRznsm/FkN86V1omcIcnrMnAnm0nam5O2znF8B3Jb6Zu98lvkV v57w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728147513; x=1728752313; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=534BF0P5lE7Sw6EXBB2MdGwppSsVFm73Tau4PbJd3Pc=; b=R/gSTDRK48ihYmXEJrJ8tikj6C9W3wT6XUXbAXmz3h+C93h+Y+TzUIFGV+cNWZ79CW 9lfiSj+cNPLnJYNYORPnqozxcqLIlgq/G45HorpJsrPZZzOZqMINPQdekA6VQXuIGp83 YqU5AG2JcjWrs1fKKTuCVQS5PFsEH9lJA6buNrifZY1/pWeG5owX04yCnOqH8DFY5+/u SSYRvR+uYyRJxtZuJeVhRTFjOP4BQYAWxcPt7+70LqOAuJqhlzQzMGpKF3tR7mZCO/Jg ueM5uKZe8vB8egcNEaSJZ7wx/RONPBgGWOV5UJW3aFQocTFZiubFnhDg44YD7WRpptPp whZA== X-Forwarded-Encrypted: i=1; AJvYcCVq3MhHTYbIsjkS+jFpsp2fHZtIFYQf45JXQQb8EjHZkqhlqOyKuWT0Iq3bcuJOcu2GOf2/b2f6JuEfyV0=@vger.kernel.org X-Gm-Message-State: AOJu0Ywwmz4ykFifCN3habJ8MKIOe3n3JVK6lErbY9tBwJnUsCqOIUYd eG+lv8qbK9ozx+8/9J6XBdez8xsEqcs6p6PgdNKaL8xbE/ZR7SH6TmGa5OrKpGPgK2G/GnxV40l Zivk= X-Google-Smtp-Source: AGHT+IHNX/nlmxQbI/WqWLEEy+/8YLvtUS/jHRIC7aZ58AdVpv3bsRE62Z/GKH7EQ1/OcMHcCRnZww== X-Received: by 2002:a05:6214:5709:b0:6cb:46ce:744a with SMTP id 6a1803df08f44-6cb9a4fa3b0mr78469376d6.48.1728147512903; Sat, 05 Oct 2024 09:58:32 -0700 (PDT) Received: from [192.168.0.189] (modemcable125.110-19-135.mc.videotron.ca. [135.19.110.125]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cba46efed1sm9795796d6.68.2024.10.05.09.58.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 05 Oct 2024 09:58:32 -0700 (PDT) Subject: Re: [PATCH 1/2] drm/msm/dsi: improve/fix dsc pclk calculation To: Konrad Dybcio , freedreno@lists.freedesktop.org Cc: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang , Konrad Dybcio , "open list:DRM DRIVER for Qualcomm display hardware" , "open list:DRM DRIVER for Qualcomm display hardware" , open list References: <20241005143818.2036-1-jonathan@marek.ca> From: Jonathan Marek Message-ID: Date: Sat, 5 Oct 2024 12:55:10 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/5/24 12:31 PM, Konrad Dybcio wrote: > On 5.10.2024 4:38 PM, Jonathan Marek wrote: >> drm_mode_vrefresh() can introduce a large rounding error, avoid it. >> >> Signed-off-by: Jonathan Marek >> --- >> drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c >> index 185d7de0bf376..1205aa398e445 100644 >> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c >> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c >> @@ -542,7 +542,7 @@ static unsigned long dsi_adjust_pclk_for_compression(const struct drm_display_mo >> >> int new_htotal = mode->htotal - mode->hdisplay + new_hdisplay; >> >> - return new_htotal * mode->vtotal * drm_mode_vrefresh(mode); >> + return mult_frac(mode->clock * 1000u, new_htotal, mode->htotal); > > This seems to ignore mult/div by two on certain mode flags.. is that > intended? > > Konrad > It is intended - those flags are not relevant to DSI panels, and DSC pclk adjustment is only about how DSC affects htotal.