From: Thomas Zimmermann <tzimmermann@suse.de>
To: "Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Dave Airlie" <airlied@redhat.com>
Cc: Jocelyn Falempe <jfalempe@redhat.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Markus Schneider-Pargmann <msp@baylibre.com>
Subject: Re: [PATCH v1 3/3] drm/mgag200: Drop unused include of <drm/drm_pciids.h>
Date: Mon, 4 May 2026 15:42:16 +0200 [thread overview]
Message-ID: <e616084f-a627-4ab7-bb26-06ba7af048f2@suse.de> (raw)
In-Reply-To: <b81a4830b3c287e9360197693a823a0dc72c674c.1777545446.git.u.kleine-koenig@baylibre.com>
Hi
Am 30.04.26 um 12:45 schrieb Uwe Kleine-König (The Capable Hub):
> The <drm/drm_pciids.h> header only defines radeon_PCI_IDS which isn't
> used in the mgag200 driver. So drop the useless include statement.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
I'll merge this patch into drm-misc-next.
Best regards
Thomas
> ---
> drivers/gpu/drm/mgag200/mgag200_drv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
> index c180dc3c7a58..bb315490964f 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_drv.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
> @@ -19,7 +19,6 @@
> #include <drm/drm_ioctl.h>
> #include <drm/drm_managed.h>
> #include <drm/drm_module.h>
> -#include <drm/drm_pciids.h>
> #include <drm/drm_print.h>
>
> #include "mgag200_drv.h"
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
prev parent reply other threads:[~2026-05-04 13:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 10:45 [PATCH v1 0/3] drm: Drop unused include of <drm/drm_pciids.h> Uwe Kleine-König (The Capable Hub)
2026-04-30 10:45 ` [PATCH v1 1/3] drm/amdgpu: " Uwe Kleine-König (The Capable Hub)
2026-04-30 10:45 ` [PATCH v1 2/3] drm/gma500: " Uwe Kleine-König (The Capable Hub)
2026-04-30 10:45 ` [PATCH v1 3/3] drm/mgag200: " Uwe Kleine-König (The Capable Hub)
2026-05-04 13:42 ` Thomas Zimmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e616084f-a627-4ab7-bb26-06ba7af048f2@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jfalempe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=msp@baylibre.com \
--cc=simona@ffwll.ch \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox