Re: [PATCH v2] ALSA: hda/realtek - Fix 2 front mics of codec 0x623

Hui Wang
2019-10-24T11:30:35Z

On 2019/10/24 下午7:18, Aaron Ma wrote:
> These 2 ThinkCentres installed a new realtek codec ID 0x623,
> it has 2 front mics with the same location on pin 0x18 and 0x19.
>
> Apply fixup ALC283_FIXUP_HEADSET_MIC to change 1 front mic
> location to right, then pulseaudio can handle them.
> One "Front Mic" and one "Mic" will be shown, and audio output works
> fine.
>
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
> ---
> sound/pci/hda/patch_realtek.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index a0c237cc13d4..173a7867bb45 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -7221,6 +7221,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
> SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
> SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
> + SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
> + SND_PCI_QUIRK(0x17aa, 0x3176, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),

Please sort them in numerical order, 0x3176 is ahead of 0x3178.

thanks

> SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
> SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
> SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70", ALC269_FIXUP_DMIC_THINKPAD_ACPI),