From: Nick Piggin <npiggin@gmail.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Nick Piggin <npiggin@suse.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: Is module refcounting racy?
Date: Tue, 30 Mar 2010 03:58:49 +1100 [thread overview]
Message-ID: <e619185d1003290958w23037176uc869c7dbc0a48bcc@mail.gmail.com> (raw)
In-Reply-To: <201003291942.56706.rusty@rustcorp.com.au>
On Mon, Mar 29, 2010 at 8:12 PM, Rusty Russell <rusty@rustcorp.com.au> wrote:
> On Thu, 18 Mar 2010 09:25:34 pm Nick Piggin wrote:
>> Hey,
>>
>> I've been looking at weird and wonderful ways to do scalable refcounting,
>> for the vfs...
>>
>> Sadly, module refcounting doesn't fit my bill. But as far as I could see,
>> it is racy.
>
> Other than for advisory purposes, the refcount is only checked against zero
> under stop_machine. For exactly this reason.
There definitely looks to me like there is code that checks the refcount
*without* stop_machine. module_refcount is an exported function, and you
expect drivers to get this right (scsi_device_put for a trivial example), but
it even looks like it is used in a racy way in kernel/module.c code.
Either we need to take my patch, or audit t, and put a WARN_ON
if it is called while not under stop_machine.
next prev parent reply other threads:[~2010-03-29 16:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 10:55 Is module refcounting racy? Nick Piggin
2010-03-29 9:12 ` Rusty Russell
2010-03-29 16:58 ` Nick Piggin [this message]
2010-03-31 3:44 ` Rusty Russell
2010-04-01 8:09 ` Nick Piggin
2010-04-01 15:55 ` Linus Torvalds
2010-04-06 2:39 ` Rusty Russell
2010-04-06 5:05 ` Nick Piggin
2010-04-06 6:19 ` Eric Dumazet
2010-04-06 7:38 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e619185d1003290958w23037176uc869c7dbc0a48bcc@mail.gmail.com \
--to=npiggin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).