From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5D0DC433E8 for ; Tue, 28 Jul 2020 06:40:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B04F5207F5 for ; Tue, 28 Jul 2020 06:40:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595918430; bh=zzH03DpWgyNFdY3mafOfXiycjdgHC99DBNRZc9ELN14=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=IlLkdEGKllMk54HEU528pdf6Z2ocxg6vilkoXucXgs+mc+H9hM6bCjAYb6Emo/AkC WNgmIIJkh2EVboKbmzUBQPjuaujyG3JCeMB7vjW5okEtlQZiR/iNTWH8jMRnbi1yYM mqzG6/o6E2CX/6QkztRPUexnC8MuX+Hr9IF2CTkY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727033AbgG1Gk3 (ORCPT ); Tue, 28 Jul 2020 02:40:29 -0400 Received: from mail-ej1-f67.google.com ([209.85.218.67]:45629 "EHLO mail-ej1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726883AbgG1Gk3 (ORCPT ); Tue, 28 Jul 2020 02:40:29 -0400 Received: by mail-ej1-f67.google.com with SMTP id g7so11223151ejw.12 for ; Mon, 27 Jul 2020 23:40:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9LDJcbP5EY7Qv6Dknlse8srXZlwMpETG/crjtwF3dQ0=; b=Rm84MPPkujjuan8nmZsDOSQGdqnNxRaGzj8v/aLpQIcmcFsVVvokCsuJjCmwPHEoFm 5qPk2RUAhucciSZO/T2ndNQeGQoBe4q5PRHgUnuLSXklDfHoGLOkHscZb9EBEj+rHYwK uyr137aQRXCWEALZpvfGV2s63HMakrfT44mbkR1uRg8bqHTiqNjf9CPx4MAhqd4STJLo dYpxO7x6rKrCDzXDaQQBHHUahgOOJFXHCutYsWbM6e5CDqDVKjk76h69qJjsYWdJgggE 0espYvlXVcPW67N6ViydCckaUuObad5zxoeKUheTSEVcpijGaqI+gEqgPtHt6H+m9i+5 UEBQ== X-Gm-Message-State: AOAM531cm3f2I1veOW/gjk4EUVsEuCXDnv6Th2G31azl32e0fvPHd/31 pT6TZFfyHQFgaIxyWO9wV1hSG3wM X-Google-Smtp-Source: ABdhPJwvKK+zNmouhE1GaJQ/7eY23PxXYX+9Lb+Ocbwc44jtTyDnTwWpNHVswyeX8MIswlnZkJrYNg== X-Received: by 2002:a17:906:1c84:: with SMTP id g4mr10244448ejh.59.1595918426508; Mon, 27 Jul 2020 23:40:26 -0700 (PDT) Received: from [192.168.1.49] (185-219-167-24-static.vivo.cz. [185.219.167.24]) by smtp.gmail.com with ESMTPSA id sb3sm5001981ejb.113.2020.07.27.23.40.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jul 2020 23:40:25 -0700 (PDT) Subject: Re: [PATCH] tty/synclink: remove leftover bits of non-PCI card support To: Christoph Hellwig Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org References: <20200727130501.31005-1-hch@lst.de> <8a015ca4-e837-8fa5-684c-46fca8104ea5@kernel.org> <20200728062045.GA20992@lst.de> From: Jiri Slaby Message-ID: Date: Tue, 28 Jul 2020 08:40:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200728062045.GA20992@lst.de> Content-Type: text/plain; charset=iso-8859-2 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28. 07. 20, 8:20, Christoph Hellwig wrote: > On Tue, Jul 28, 2020 at 08:05:36AM +0200, Jiri Slaby wrote: >> On 27. 07. 20, 15:05, Christoph Hellwig wrote: >>> Since commit 1355cba9c3ba ("tty/synclink: remove ISA support"), the >>> synlink driver only supports PCI card. Remove any leftover dead code >>> to support other cards. >> >> So now you can remove also the defines and bus_type completely: >> $ git grep -E 'MGSL_BUS_TYPE_(E?ISA|PCI)' >> drivers/tty/synclink_gt.c: info->bus_type = MGSL_BUS_TYPE_PCI; >> drivers/tty/synclinkmp.c: info->bus_type = MGSL_BUS_TYPE_PCI; >> include/uapi/linux/synclink.h:#define MGSL_BUS_TYPE_ISA 1 >> include/uapi/linux/synclink.h:#define MGSL_BUS_TYPE_EISA 2 >> include/uapi/linux/synclink.h:#define MGSL_BUS_TYPE_PCI 5 > > This is in a uapi header, so I didn't dare to touch it. Ah, sure. Then OK. Just wondering, who would place this into a uapi header? >> $ git grep -w bus_type drivers/tty/synclink* >> drivers/tty/synclink_gt.c: unsigned int bus_type; >> drivers/tty/synclink_gt.c: info->bus_type = MGSL_BUS_TYPE_PCI; >> drivers/tty/synclinkmp.c: unsigned int bus_type; >> /* expansion bus type (ISA,EISA,PCI) */ >> drivers/tty/synclinkmp.c: info->bus_type = MGSL_BUS_TYPE_PCI; > > Despite the similar names these are actually two drivers entirely > separate form the main synclink one. I know, but it's set-but-unused field in both of them. So if the defines went away, this could go too. But given the defines stay, it doesn't matter. All 3 drivers are old unmaintained crap anyway: $ git log --oneline --no-merges drivers/tty/synclink*|wc -l 79 thanks, -- js