public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Magenheimer <dan.magenheimer@oracle.com>
To: Seth Jennings <sjenning@linux.vnet.ibm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Dan Magenheimer <dan.magenheimer@oracle.com>,
	Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Nitin Gupta <ngupta@vflare.org>,
	Robert Jennings <rcj@linux.vnet.ibm.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: RE: [PATCH] staging: zcache: make zcache builtin only
Date: Mon, 5 Mar 2012 11:02:46 -0800 (PST)	[thread overview]
Message-ID: <e64cd1fe-2fcc-4cab-a437-84b2c2939b6d@default> (raw)
In-Reply-To: <<1330965998-12116-1-git-send-email-sjenning@linux.vnet.ibm.com>>

> From: Seth Jennings [mailto:sjenning@linux.vnet.ibm.com]
> Sent: Monday, March 05, 2012 9:47 AM
> To: Greg Kroah-Hartman
> Cc: Seth Jennings; Dan Magenheimer; Thadeu Lima de Souza Cascardo; Konrad Rzeszutek Wilk; Nitin Gupta;
> Robert Jennings; devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] staging: zcache: make zcache builtin only
> 
> zcache cannot currently be loaded as a module.  However
> the Kconfig allows it to be built as a module; something that
> the user probably does not intend since the module is not
> loadable.
> 
> This patch switches zcache from a tristate to a bool in the Kconfig
> 
> Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>

Acked-by: Dan Magenheimer <dan.magenheimer@oracle.com>

> ---
>  drivers/staging/zcache/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig
> index 5a36fcf..3ed2c8f 100644
> --- a/drivers/staging/zcache/Kconfig
> +++ b/drivers/staging/zcache/Kconfig
> @@ -1,5 +1,5 @@
>  config ZCACHE
> -	tristate "Dynamic compression of swap pages and clean pagecache pages"
> +	bool "Dynamic compression of swap pages and clean pagecache pages"
>  	# X86 dependency is because zsmalloc uses non-portable pte/tlb
>  	# functions
>  	depends on (CLEANCACHE || FRONTSWAP) && CRYPTO && X86
> --
> 1.7.5.4

       reply	other threads:[~2012-03-05 19:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <<1330965998-12116-1-git-send-email-sjenning@linux.vnet.ibm.com>
2012-03-05 19:02 ` Dan Magenheimer [this message]
2012-03-05 16:46 [PATCH] staging: zcache: make zcache builtin only Seth Jennings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e64cd1fe-2fcc-4cab-a437-84b2c2939b6d@default \
    --to=dan.magenheimer@oracle.com \
    --cc=cascardo@holoscopio.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ngupta@vflare.org \
    --cc=rcj@linux.vnet.ibm.com \
    --cc=sjenning@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox