RE: [PATCH] staging: zcache: make zcache builtin only

RE: [PATCH] staging: zcache: make zcache builtin only

[Dan Magenheimer]

> From: Seth Jennings [mailto:sjenning@linux.vnet.ibm.com]
> Sent: Monday, March 05, 2012 9:47 AM
> To: Greg Kroah-Hartman
> Cc: Seth Jennings; Dan Magenheimer; Thadeu Lima de Souza Cascardo; Konrad Rzeszutek Wilk; Nitin Gupta;
> Robert Jennings; devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] staging: zcache: make zcache builtin only
> 
> zcache cannot currently be loaded as a module.  However
> the Kconfig allows it to be built as a module; something that
> the user probably does not intend since the module is not
> loadable.
> 
> This patch switches zcache from a tristate to a bool in the Kconfig
> 
> Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>

Acked-by: Dan Magenheimer <dan.magenheimer@oracle.com>

> ---
>  drivers/staging/zcache/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig
> index 5a36fcf..3ed2c8f 100644
> --- a/drivers/staging/zcache/Kconfig
> +++ b/drivers/staging/zcache/Kconfig
> @@ -1,5 +1,5 @@
>  config ZCACHE
> -	tristate "Dynamic compression of swap pages and clean pagecache pages"
> +	bool "Dynamic compression of swap pages and clean pagecache pages"
>  	# X86 dependency is because zsmalloc uses non-portable pte/tlb
>  	# functions
>  	depends on (CLEANCACHE || FRONTSWAP) && CRYPTO && X86
> --
> 1.7.5.4

[PATCH] staging: zcache: make zcache builtin only

[Seth Jennings]

zcache cannot currently be loaded as a module.  However
the Kconfig allows it to be built as a module; something that
the user probably does not intend since the module is not
loadable.

This patch switches zcache from a tristate to a bool in the Kconfig

Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
---
 drivers/staging/zcache/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig
index 5a36fcf..3ed2c8f 100644
--- a/drivers/staging/zcache/Kconfig
+++ b/drivers/staging/zcache/Kconfig
@@ -1,5 +1,5 @@
 config ZCACHE
-	tristate "Dynamic compression of swap pages and clean pagecache pages"
+	bool "Dynamic compression of swap pages and clean pagecache pages"
 	# X86 dependency is because zsmalloc uses non-portable pte/tlb
 	# functions
 	depends on (CLEANCACHE || FRONTSWAP) && CRYPTO && X86
-- 
1.7.5.4