From: Jens Axboe <axboe@kernel.dk>
To: Xu Wang <vulab@iscas.ac.cn>, linux-ide@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: ahci: use ata_link_info() instead of ata_link_printk()
Date: Sun, 16 Aug 2020 20:09:06 -0700 [thread overview]
Message-ID: <e64e363a-55e5-7a71-ced7-fd28fc32aaa8@kernel.dk> (raw)
In-Reply-To: <20200817011854.9668-1-vulab@iscas.ac.cn>
On 8/16/20 6:18 PM, Xu Wang wrote:
> Using ata_link_info() instead of ata_link_printk().
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
> drivers/ata/ahci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 0c0a736eb861..9d72d907b4ee 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -807,7 +807,7 @@ static int ahci_avn_hardreset(struct ata_link *link, unsigned int *class,
> (sstatus & 0xf) != 1)
> break;
>
> - ata_link_printk(link, KERN_INFO, "avn bounce port%d\n",
> + ata_link_info(link, "avn bounce port%d\n",
> port);
Why not collapse that into one line as well when making that change, as
it now fits just fine?
Apart from that, looks fine to me.
--
Jens Axboe
next prev parent reply other threads:[~2020-08-17 3:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 1:18 [PATCH] ata: ahci: use ata_link_info() instead of ata_link_printk() Xu Wang
2020-08-17 3:09 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-08-17 3:29 Xu Wang
2020-08-17 3:45 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e64e363a-55e5-7a71-ced7-fd28fc32aaa8@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox