* [PATCH] ata: ahci: use ata_link_info() instead of ata_link_printk()
@ 2020-08-17 1:18 Xu Wang
2020-08-17 3:09 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Xu Wang @ 2020-08-17 1:18 UTC (permalink / raw)
To: axboe, linux-ide; +Cc: linux-kernel, Xu Wang
Using ata_link_info() instead of ata_link_printk().
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
drivers/ata/ahci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 0c0a736eb861..9d72d907b4ee 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -807,7 +807,7 @@ static int ahci_avn_hardreset(struct ata_link *link, unsigned int *class,
(sstatus & 0xf) != 1)
break;
- ata_link_printk(link, KERN_INFO, "avn bounce port%d\n",
+ ata_link_info(link, "avn bounce port%d\n",
port);
pci_read_config_word(pdev, 0x92, &val);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ata: ahci: use ata_link_info() instead of ata_link_printk()
2020-08-17 1:18 [PATCH] ata: ahci: use ata_link_info() instead of ata_link_printk() Xu Wang
@ 2020-08-17 3:09 ` Jens Axboe
0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2020-08-17 3:09 UTC (permalink / raw)
To: Xu Wang, linux-ide; +Cc: linux-kernel
On 8/16/20 6:18 PM, Xu Wang wrote:
> Using ata_link_info() instead of ata_link_printk().
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
> drivers/ata/ahci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 0c0a736eb861..9d72d907b4ee 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -807,7 +807,7 @@ static int ahci_avn_hardreset(struct ata_link *link, unsigned int *class,
> (sstatus & 0xf) != 1)
> break;
>
> - ata_link_printk(link, KERN_INFO, "avn bounce port%d\n",
> + ata_link_info(link, "avn bounce port%d\n",
> port);
Why not collapse that into one line as well when making that change, as
it now fits just fine?
Apart from that, looks fine to me.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ata: ahci: use ata_link_info() instead of ata_link_printk()
@ 2020-08-17 3:29 Xu Wang
2020-08-17 3:45 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Xu Wang @ 2020-08-17 3:29 UTC (permalink / raw)
To: axboe, linux-ide; +Cc: linux-kernel, Xu Wang
Using ata_link_info() instead of ata_link_printk().
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
drivers/ata/ahci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 0c0a736eb861..fbd8eaa32d32 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -807,8 +807,7 @@ static int ahci_avn_hardreset(struct ata_link *link, unsigned int *class,
(sstatus & 0xf) != 1)
break;
- ata_link_printk(link, KERN_INFO, "avn bounce port%d\n",
- port);
+ ata_link_info(link, "avn bounce port%d\n", port);
pci_read_config_word(pdev, 0x92, &val);
val &= ~(1 << port);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-17 3:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-17 1:18 [PATCH] ata: ahci: use ata_link_info() instead of ata_link_printk() Xu Wang
2020-08-17 3:09 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2020-08-17 3:29 Xu Wang
2020-08-17 3:45 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox