From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F06B27472 for ; Tue, 23 Dec 2025 16:02:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766505734; cv=none; b=dk4+13a8RqnKGOvZTSkzAWpWJEQsqYvZW3Pyb7lU46Fkt9fK87DwdkIraxIyX+ky8uaORxmaGe1gmyZBga3b2jZXaBLDk1JzlUpOVcI5l9cGz0EOVSSt9N7YCi6Zvit0GXShK8zJcH2JdqoBP3471PXwKRj9n4N2HxM8kHjZut4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766505734; c=relaxed/simple; bh=Wgw4lUnhbAK2SuJREsC/TLvjP8fweiX3DpQoJ132GsY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Kz1nOqycMeJOwimxdDn8pd9Fh5HWUj7ybNcRxUZxbi4aWZEPCkBUYdwLNie3ESHgdLGUgn6fKhtOYDgjaBbIzj1oWvdm0I+Pt1JihjQ3u8o6iDxamgH+3FtJNDQ8H7U8TNqKo1hHwwAyTmpzdhHuacGRjVYsZF5p1IfTkra7CG8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=nhvZcaWb; arc=none smtp.client-ip=91.218.175.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="nhvZcaWb" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1766505729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6qno5Lv3o0et1YFZD/NDGPUTfKtUpErsqjsFbBj2QXc=; b=nhvZcaWbCkPRdE86r1kgT0agSrWwo6rlvqVYLuoQhkSt8ygvvx4rNsMSfSoP0fwdvTrWw7 HPpMlFz2EyMqIdFj3rDJvdXyBb2qK3blUQPLfJJnLpnelJitBpekyCwHQEzj/JXbYlt6AG RbtYaK4uIlFjLT9Cyv3rhoNUz3CYXT4= Date: Tue, 23 Dec 2025 08:02:01 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v3 1/1] RDMA/rxe: Avoid -Wflex-array-member-not-at-end warnings To: "Gustavo A. R. Silva" , zyjzyj2000@gmail.com, jgg@ziepe.ca, leon@kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Gustavo A. R. Silva" References: <20251223044129.6232-1-yanjun.zhu@linux.dev> <4a8e3365-cb74-4531-99dc-9d2911045d4b@linux.dev> <1bf3f157-54b7-49ed-8dc2-6948dbcf670a@embeddedor.com> <7de9609c-afa2-4536-a65c-67e623885870@linux.dev> <77f7670a-db1f-41a2-afe8-58397e888118@embeddedor.com> <24901de5-f7dc-4070-8745-df114ce1ff75@linux.dev> <256da54b-519f-461d-9586-10b26ef7568e@embeddedor.com> <061c81dd-c582-414e-999c-7256a98ced42@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Zhu Yanjun In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT 在 2025/12/23 1:28, Gustavo A. R. Silva 写道: > > > On 12/23/25 15:46, Zhu Yanjun wrote: >> >> 在 2025/12/22 21:54, Gustavo A. R. Silva 写道: >>> >>> >>> On 12/23/25 14:44, Zhu Yanjun wrote: >>>> >>>> 在 2025/12/22 21:34, Gustavo A. R. Silva 写道: >>>>> >>>>>>>>>> V2->V3: Replace struct ib_sge with struct rxe_sge >>>>>>>>> >>>>>>>>> What are you doing? >>>>>>>> >>>>>>>> Because struct rxe_sge differs from struct ib_sge, I aligned it >>>>>>>> to use the same structure. >>>>>>> >>>>>>> Listen, this is not how things are done upstream. Read what I >>>>>>> previously commented: >>>>>>> >>>>>>>>> You're making a mess of this whole thing. Please, don't make >>>>>>>>> changes >>>>>>>>> to my patches on your own. >>>>>>> >>>>>>> and please, learn how to properly submit patch series. >>>>>>> >>>>>>> Lastly, do the changes that you want/need to implement in your >>>>>>> code, and don't >>>>>>> submit my patch as part of those changes again. >>>>>> >>>>>> You can correct this patch by yourself. >>>>> >>>>> https://lore.kernel.org/linux-hardening/ad8987ae-b7fe-47af- >>>>> a1d2-5055749011c0@embeddedor.com/ >>>> >>>> You need to do some changes in your commit. >>> >>> This is what you haven't understood yet. If the original code is >>> wrong (e.g. is >>> currently using struct ib_sge instead of struct rxe_sge or the other >>> way around), >>> then _that_ code should be fixed _first_, regardless of any other >>> patch that might >>> be applied on top of it. >> >> Your commit should align the 2 structs. > > No. It should not. To understand why, read my previous responses. There is something wrong in your commit. Please correct it. I have already pointed it out. Yanjun.Zhu > > -Gustavo >