From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933262AbdEVLep (ORCPT <rfc822;w@1wt.eu>);
        Mon, 22 May 2017 07:34:45 -0400
Received: from mout.web.de ([212.227.15.3]:52914 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932463AbdEVLen (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 22 May 2017 07:34:43 -0400
Subject: Re: vhost/scsi: Delete error messages for failed memory allocations
 in five functions
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kvm@vger.kernel.org, netdev@vger.kernel.org,
        virtualization@lists.linux-foundation.org,
        kernel-janitors@vger.kernel.org, Jason Wang <jasowang@redhat.com>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, Wolfram Sang <wsa@the-dreams.de>
References: <bafa65e4-08fe-efdb-d836-7657e8a64749@users.sourceforge.net>
 <babc429d-6440-92aa-e1d0-eee2636a8d0f@users.sourceforge.net>
 <20170522094320.GE12205@stefanha-x1.localdomain>
 <557bdff4-6dc2-756d-0d59-9f688ef11f0a@users.sourceforge.net>
 <20170522112320.GA22806@stefanha-x1.localdomain>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <e6658e56-a2b0-4ecc-0a95-0ba193ff2c97@users.sourceforge.net>
Date: Mon, 22 May 2017 13:34:34 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <20170522112320.GA22806@stefanha-x1.localdomain>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:ZagEqr83U1PGTVPC6Iv+u9/E2Hjj8gB+oI7HmwNFIGfUQUBinll
 Su4IVeqtMiNlBXy7fXrrGRNzAiEm6ZOS7tzRJMfJi4qJ/QE+mPAmGT1HNEVbMSo3pYfUlNQ
 w5ADdOm27XMaAm2R/5YngKc09KdEFTg3i547lLF6YSApyl/mcba0QZtHQoABgQYSbGw4xa5
 fjQWtyloQA9ZR46NaTexg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:X8LpZyhyQOU=:z8QiiTKVUEamI38XlCZgDg
 XWrVUVdZ65Ht3gMhSxV30Z7RWvqSB1jSlBH0atHTRHbivFOsLU8k7pZh/oHMgHjRtdepU+d4+
 BhxaCPDG21ucMQRAYvatXqD+qkQ4h6/nRy0U9f3qelQuTtGWiXgDAaP1b0jELTT5CwvAHw8CI
 3wLa+AQUwqfi7d0Ln7x86QwOpuaqkHwgRPxeInR/XstTJNP2CBISnUEaSt/kHEeLFerVVBlkg
 KiWOUoC+LKQ9lA6feynt9GdFNVAbwLQip9z+Jjm0l4BAutIPJBbjQbaMS3qO333zY5+kvI7tX
 OkKXykUBgpvJLcsPUGXMsfIfkqWDdr33NKEozLwaySgvJAUaV0X6fX+5p2wW/XPAUeQEKWjWR
 bIOesSq9D5P3v8Bx+X5a1kZoWM1z4JVGfBTtxr0z6BHoqiBcpuChJIjYithwGj2xQq0lLiJ3v
 q9CpJnd97v9Yr7S86NFvtWV+i2Yq7azU4NmJZ9KGYZYOggSQ5f4MebpiKTNJhmY2xr2HgZp0t
 yUaFFe/BW4cIw3soitbgCv3xQfxMxTKStnOk0AoNILV1K8UzCQxwW/E9xBmcFL2PlrCHTFwYt
 Y0OfJPVAL0Fny04y80MLecPFNO7ZAF62xo01E3hh1tDKy4d89C7RvSj/A4VTq52HhHIyca7UA
 j22L8WpvbZOJTt6qrtSRUzm2SChfxz0nCWq9Zt9a2wVgjOj1quMIZ1C4fxzIx0KLJIFV2ALNV
 rX5JTtJ14ec1r7crob8qyM0ikFWIasVC5B6z9fGmUTUCweBsAclVKfjJGj6ZtBLo25sZ/WS0O
 UiDQexZ
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> Do you find information from a Linux allocation failure report sufficient
>> for any function implementations here?
> 
> If kmalloc() and friends guarantee to print a warning and backtrace on
> every allocation failure, then there's no need for error messages in
> callers.
> 
> That seems like good justification that can go in the commit
> description, but I'm not sure if kmalloc() and friends guarantee to show
> a message (not just the first time, but for every failed allocation)?

I am also looking for a more complete and easier accessible documentation
for this aspect of the desired exception handling.
How would we like to resolve any remaining open issues there?

Regards,
Markus