From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 660C51DED49; Fri, 20 Feb 2026 07:44:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771573446; cv=none; b=CrMt0mS6U/exCX49VSvOT4KVh2/1IHiIopEJ3fFO9vRW5p+q+DMUhXQKYS0gT3793Eq5DK9PCCDn0t4DrAymCfMWri7+zLeWSBvdRumdD8gBV0G2zUOuIm2istrybLhjAU51KZ3cCQu74pd/Pt5zEWexRVLylsG4mFz/jK0N+oM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771573446; c=relaxed/simple; bh=k425gDc7aLt8H/wpp06Zvg8FcXXbgWIzcofhwZlUGGI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cuWl1BRRAdPKvxMjaWsMW89vKnFjHqMJGjWIS5yvQQmg8WAJoE+acxb3nLVjxViHQjyVkFlQZXdARRdi76x0fHYwaW6WGxqj4Ac/op0obKDW2jbpn0yAVl0tXz/iy6sMgQx+u65ezvUj9uCsUp9mQhq/kteitHN4mCK0CVslIYg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=I7h8AQ8/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="I7h8AQ8/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 695BEC116D0; Fri, 20 Feb 2026 07:44:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771573446; bh=k425gDc7aLt8H/wpp06Zvg8FcXXbgWIzcofhwZlUGGI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=I7h8AQ8//e7HpYjyXSbdxlpcDJlASZNE1CsqT89rNmfdsZ8Otfghlip8g1DbYcv+T bjDpK0YNWGbzHbfTSw6YEDolRJyJ1FbWOIZfZd3at+D8DrM865ScDJKSjrTCl/KCl4 AanQ5I4GLFoo7nziDWW6+beb/3omq/WSFofqSEKjRCg7GHIK+A8DAaUVlfE2335cEy /IYUNAkBuhuR5JO9O0cz1kq9cAxQYRUG5dWthZrQw1OhbwJB/1IdlRd6nrsMy2lhT2 Kr9H0YBofhpBrGnigRmeTiGeMZ7wSQ2seDm7MCpIPMfzKpAHFry7ogb3CMnIQ2akD1 7yoViQuBy4mmw== Message-ID: Date: Fri, 20 Feb 2026 08:44:00 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/8] dt-bindings: thermal: Add qcom,qmi-cooling yaml bindings To: Gaurav Kohli Cc: andersson@kernel.org, mathieu.poirier@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, rui.zhang@intel.com, lukasz.luba@arm.com, konradybcio@kernel.org, mani@kernel.org, casey.connolly@linaro.org, amit.kucheria@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, manaf.pallikunhi@oss.qualcomm.com References: <20260127155722.2797783-1-gaurav.kohli@oss.qualcomm.com> <20260127155722.2797783-3-gaurav.kohli@oss.qualcomm.com> <20260128-whispering-caracal-of-respect-a26638@quoll> <36706481-2549-4716-8e6d-0e4db42591a2@oss.qualcomm.com> <546faeda-d896-403c-a449-5c9b0cd7159e@kernel.org> <17474333-bb82-49d7-bc04-45ab21095c38@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 20/02/2026 08:29, Gaurav Kohli wrote: > > > On 2/11/2026 1:43 PM, Krzysztof Kozlowski wrote: >> On 11/02/2026 08:37, Gaurav Kohli wrote: >>> >>> >>> On 2/8/2026 3:36 PM, Krzysztof Kozlowski wrote: >>>> On 29/01/2026 13:06, Gaurav Kohli wrote: >>>>> >>>>> On 1/28/2026 4:57 PM, Krzysztof Kozlowski wrote: >>>>>> On Tue, Jan 27, 2026 at 09:27:16PM +0530, Gaurav Kohli wrote: >>>>>>> The cooling subnode of a remoteproc represents a client of the Thermal >>>>>>> Mitigation Device QMI service running on it. Each subnode of the cooling >>>>>>> node represents a single control exposed by the service. >>>>>>> >>>>>>> Signed-off-by: Gaurav Kohli >>>>>>> --- >>>>>>> .../bindings/remoteproc/qcom,pas-common.yaml | 6 ++ >>>>>>> .../bindings/thermal/qcom,qmi-cooling.yaml | 72 +++++++++++++++++++ >>>>>>> 2 files changed, 78 insertions(+) >>>>>>> create mode 100644 Documentation/devicetree/bindings/thermal/qcom,qmi-cooling.yaml >>>>>>> >>>>>>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml >>>>>>> index 68c17bf18987..6a736161d5ae 100644 >>>>>>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml >>>>>>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml >>>>>>> @@ -80,6 +80,12 @@ properties: >>>>>>> and devices related to the ADSP. >>>>>>> unevaluatedProperties: false >>>>>>> >>>>>>> + cooling: >>>>>>> + $ref: /schemas/thermal/qcom,qmi-cooling.yaml# >>>>>>> + description: >>>>>>> + Cooling subnode which represents the cooling devices exposed by the Modem. >>>>>> I do not see the reason why you need 3 (!!!) children here. Everything >>>>>> should be folded here. >>>>> >>>>> >>>>> Thanks Krzysztof for review. >>>>> >>>>> Each subsystem may support multiple thermal mitigation devices through >>>>> remote TMD service. >>>>> >>>>> Because of this multiplicity, introduced separate binding file. >>>> >>>> This explains nothing. Subsystem does not matter for the binding. My >>>> comment stays. >>>> >>> >>> thanks for this suggestion, we will use qcom,pas-common.yaml to define >>> bindings and avoid creating new file. >> >> I asked not to create any children nodes. >> > > We have multiple cores within a subsystem(cdsp) and each core has its > own independent DCVS. And also we have dedicated TSENS sensor placed on > each core within the subsystem. Your own example in this patch had only one device, so how do you imagine to convince us with incomplete or half baked code? > As a result, each core requires its own cooling device, which must be > linked to its TSENS thermal zone. Because of this, we introduced > multiple child nodes—one for each cooling device. So you have one device with cooling cells=1+2, no? > Best regards, Krzysztof