From: Timur Tabi <timur@codeaurora.org>
To: Sinan Kaya <okaya@codeaurora.org>, dmaengine@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 2/3] dmaengine: qcom_hidma: add support for the new revision
Date: Wed, 8 Nov 2017 10:49:28 -0600 [thread overview]
Message-ID: <e673a03d-1707-fe4a-7f5d-df1466981893@codeaurora.org> (raw)
In-Reply-To: <1510158582-5343-2-git-send-email-okaya@codeaurora.org>
On 11/08/2017 10:29 AM, Sinan Kaya wrote:
> +#define HIDMA_MAX_DEV_MATCH 10
> +
> +struct hidma_cap {
> + const struct of_device_id of[HIDMA_MAX_DEV_MATCH];
> + const struct acpi_device_id acpi[HIDMA_MAX_DEV_MATCH];
> +};
This seems wrong. You're defining an array of size 10, but it only has
three elements. And the third element is a sentinel, which is typically
used to avoid specifying the size of the array.
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2017-11-08 16:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 16:29 [PATCH V2 1/3] Documentation: DT: qcom_hidma: bump HW revision for the bugfixed HW Sinan Kaya
2017-11-08 16:29 ` [PATCH V2 2/3] dmaengine: qcom_hidma: add support for the new revision Sinan Kaya
2017-11-08 16:49 ` Timur Tabi [this message]
2017-11-08 16:58 ` Sinan Kaya
2017-11-08 17:12 ` Timur Tabi
2017-11-08 17:37 ` Sinan Kaya
2017-11-08 17:51 ` Timur Tabi
2017-11-08 17:51 ` Robin Murphy
2017-11-10 14:03 ` Sinan Kaya
2017-11-10 14:14 ` Timur Tabi
2017-11-10 14:17 ` Robin Murphy
2017-11-08 16:29 ` [PATCH V2 3/3] dmaengine: qcom_hidma: add identity register support Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e673a03d-1707-fe4a-7f5d-df1466981893@codeaurora.org \
--to=timur@codeaurora.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=okaya@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox