Re: I request inclusion of reiser4 in the mainline kernel

Horst von Brand
2005-09-20T15:36:50Z

Nikita Danilov <nikita@clusterfs.com> wrote:
> Stephen Pollei writes:
> > On 9/19/05, Horst von Brand <vonbrand@inf.utfsm.cl> wrote:
> > > Nikita Danilov <nikita@clusterfs.com> wrote:
> > > > It's other way around: declaration is guarded by the preprocessor
> > > > conditional so that nobody accidentally use znode_is_loaded()
> > > > outside of the debugging mode.

> > > Since when has a missing declaration prevented anyone calling a
> > > function in C?!

> It issues a warning, which is enough, given that reiser4 code was
> warning-free most of the time.

It is supposed to go into the kernel, which is not exactly warning-free.
Besides, you don't know what idiotic new warnings the gcc people might
dream up the next round, so just relying on no warnings is extremely
unwise.

As was said before: It it is /really/ wrong, arrange for it not to compile
or not to link. If it isn't, well... then it wasn't that wrong anyway.
--
Dr. Horst H. von Brand User #22616 counter.li.org
Departamento de Informatica Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria +56 32 654239
Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513