Re: I request inclusion of reiser4 in the mainline kernel

Nikita Danilov
2005-09-19T11:39:43Z

Denis Vlasenko writes:
> On Friday 16 September 2005 20:05, Hans Reiser wrote:
> > All objections have now been addressed so far as I can discern.
>
> Random observation:
>
> You can declare functions even if you never use them.
> Thus here you can avoid using #if/#endif:
>
> #if defined(REISER4_DEBUG) || defined(REISER4_DEBUG_MODIFY) || defined(REISER4_DEBUG_OUTPUT)
> int znode_is_loaded(const znode * node /* znode to query */ );
> #endif

It's other way around: declaration is guarded by the preprocessor
conditional so that nobody accidentally use znode_is_loaded() outside of
the debugging mode.

>
> --
> vda
>

Nikita.