Re: I request inclusion of reiser4 in the mainline kernel

James Lamanna
2005-09-20T22:40:36Z

On 9/20/05, Stephen Pollei <stephen.pollei@gmai.com> wrote:
>On 9/20/05, Hans Reiser <reiser@namesys.com> wrote:
> > Horst von Brand wrote:
> > >Nikita Danilov <nikita@clusterfs.com> wrote:
> > >It is supposed to go into the kernel, which is not exactly warning-free.

> > Is that what this thread boils down to, that you guys think the compile
> > should fail not warn?

> > I don't care if it fails or warns at compile time, but you shouldn't
> > misuse/abuse a warning by potentialily introducing an unrelated bug.
>
> So if you had
>#if defined(DEBUG_THIS) || defined(DEBUG_THAT)
>int znode_is_loaded(const struct znode *z);
> #else
> int znode_is_loaded(const struct znode *z)
> __attribute__((__warn_broken__("unavailible when not debuging")));
> #endif
> That would be great with me.. except __warn_broken__ or the like
> doesn't exist AFAIK :-<
> Closest thing is __attribute((__deprecated__)) but thats not quite right.
> > > As was said before: It it is /really/ wrong, arrange for it not to compile
> > > or not to link. If it isn't, well... then it wasn't that wrong anyway.

What about #warning / #error in this case?

#if defined(DEBUG_THIS) || defined(DEBUG_THAT)
int znode_is_loaded(const struct znode *z);
#else
#error znode_is_loaded is unavailable when not debugging
#endif

That would certainly break the compile.

-- James Lamanna