From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBED61FCD12 for ; Mon, 27 Jan 2025 10:33:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737974033; cv=none; b=d/FGj6F2jkJXHD6sMpMXkztGpfUNNN6mzZ9a9KaMw/KIay5aE6gVL8Sukrpo70iB1VyBv9MK2uAfx5mohtr281azJEW2QRTHX0XkeaFs/mSfsFAKj9xoGnsVMqgle9/TPef2yEb7lc7HH/tJBdZXTT5jjUTqrLM6jZJpePQwrWw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737974033; c=relaxed/simple; bh=/2jpubJ76LTJrMU6CNiePQvY30kXVSm/q0TgYoXBqjQ=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=tQC2zrqtsOvRTS2YOQ7iLaHQ9nvC51/MvEGI6j6ez5/NETiqH6qSbIvvpj41TUB6ZgA2fOQFkzRpTlbv6lT9Vibw+g5npwF+ZiEGb0kupwovN6OLZ9HbTByRp4LqSiAKJn2vacHYjDWhcLWVQzHBTBMJrHB2keuFvVB9i+hoQ+Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IgfXBgRu; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IgfXBgRu" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50QNPD8f028181 for ; Mon, 27 Jan 2025 10:33:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XO2U/FigudNpheyHXoXOoPHFQtk40Wecm2MIHQ46a/o=; b=IgfXBgRuoBpyzHLm 87T/vhiyRMqeaMA8yDAoh2daETixNkgOlovwRezDOvWS62leBJ6onvmyP8/2W2Vs yaPhQkqGsrP0OxTjrYJ97Bius2/8L/kiC+YlOfB5g+/F8fD4KsgPJKlgd1hN4URI wesiJdh/lGXLr8P+/20hVMv4Nogm3FANwqXW6TJ3uzJVyQDlO6f0rbDIItiUCSI+ VOqOvWf+tiZsRKwysHBwobzu8bkC9JklHyePd9urGKC/u2hhPAl3UHLFi6Q/JPuI IoX2MRce2lT9eOU1Wqo6SYE498VlswjJeDMNGJQG8dhUXuOR995TqiEGMuRHaez9 w4/bmA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44dsav1akc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 27 Jan 2025 10:33:50 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-46e4842dbd0so14155921cf.1 for ; Mon, 27 Jan 2025 02:33:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737974029; x=1738578829; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XO2U/FigudNpheyHXoXOoPHFQtk40Wecm2MIHQ46a/o=; b=WZwpYMrEk0t4R128WLM1U5Xd7C2wINgYiWVAHnwepaCdWsepWWE4OM5IMf1EP7/dFc TmlshIGFANPyH3OIJHlK5KxHmwReOm0NeQw03zV3b8oqoNPO7y+pQq91iVZR/5x1YUhf dNvOBuAwUit4cyq5mvtVFfgHixTvtKDg2k3ZVCu2sKyAT6Lh4aSMWxEP9WEDcXNRaejI c63TxK2pm5CCBN/C3codzaF8XZVFPTPjVUzgOxQwSyiVx+Vaaga50wh5Ou6mQkQYNmrt gLV6mTIrJaCzX/0bcbzkLvm2bZR9NihehIamFQPmxXBicy0+izIM2w7IhnJhGPdrdW66 vb9A== X-Forwarded-Encrypted: i=1; AJvYcCXMjmaWKj2WqXJJoETdHwvayDu6zbbpHVezI1PzGEFzvSSWLy5vNb1yVCKdPvmsMni0igzR8LWUJ8oEDqA=@vger.kernel.org X-Gm-Message-State: AOJu0YyFtenRPZTIvM+axINowjosZMBpTiRd0qolFQXl/Juinklu3lkG wo0zf5BEM+2diTyX46ZEJ4VyPw+nGrXNsvFKmBgqXCMNr8RH9Polw1/UhiQMrptecUJgQ6XQJSE kUk9Kt8ZLrUEp2BOo7kRzO56XD6mm4RNrAARMiv84QhlVrVkmR22vaIgRGC1drg0= X-Gm-Gg: ASbGncvE3vqssBQYfEiVR1hSzsJweCTe5VeHqSgV0qtPRRPtmOEVOdhs+yrfBpE/dS3 vkq1NWM6Hh4OpmIuN4r38TzcpdfQONepbOt3k2jm2uxaKPLsY8myA28nWSat/2+cRcRsLt9wxdz srKOdYcow+Y5kze8kdZT2QGBihQAYyMc0kteXcGdHEW2pXXRd9pu4hNBYmhzY253HX020nAYRZy j1GR2BoqCINbXBaj0vlUu/G0egVv4libuDLHq7MPEztBrRu4ev1ctgoyQQ6MEpSvt4aCKTlaZG4 R67WrJ2z7eLV7g7i0EYU8GFfx8lE3r5IttpK7RTGQcfTR5UnNYKAHWQeV3g= X-Received: by 2002:a05:622a:1803:b0:464:af83:ba34 with SMTP id d75a77b69052e-46e12b66e5amr244210241cf.10.1737974028674; Mon, 27 Jan 2025 02:33:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IESlsEC/uSt6b1mkLIn8XmnzDYv15ZT2kv/xQfb7JQbhSlZz5OYDm9Co0pS+uRxerAZbiUQAQ== X-Received: by 2002:a05:622a:1803:b0:464:af83:ba34 with SMTP id d75a77b69052e-46e12b66e5amr244210171cf.10.1737974028369; Mon, 27 Jan 2025 02:33:48 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab67b28ad13sm513244266b.41.2025.01.27.02.33.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jan 2025 02:33:47 -0800 (PST) Message-ID: Date: Mon, 27 Jan 2025 11:33:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 4/7] arm64: dts: qcom: ipq9574: Reorder reg and reg-names To: Varadarajan Narayanan , bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com, manivannan.sadhasivam@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, kishon@kernel.org, andersson@kernel.org, konradybcio@kernel.org, p.zabel@pengutronix.de, dmitry.baryshkov@linaro.org, quic_nsekar@quicinc.com, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org References: <20250122063411.3503097-1-quic_varada@quicinc.com> <20250122063411.3503097-5-quic_varada@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250122063411.3503097-5-quic_varada@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: EYIwL01a_VHkjk832rZfXtyRl3crh87S X-Proofpoint-ORIG-GUID: EYIwL01a_VHkjk832rZfXtyRl3crh87S X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-27_04,2025-01-27_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 phishscore=0 clxscore=1015 mlxscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501270085 On 22.01.2025 7:34 AM, Varadarajan Narayanan wrote: > The 'reg' & 'reg-names' constraints used in the bindings and dtsi > are different resulting in dt_bindings_check errors. Re-order > them to address following errors. > > arch/arm64/boot/dts/qcom/ipq9574-rdp449.dtb: pcie@20000000: reg-names:0: 'parf' was expected > > Signed-off-by: Varadarajan Narayanan > --- > arch/arm64/boot/dts/qcom/ipq9574.dtsi | 52 +++++++++++++++++---------- > 1 file changed, 34 insertions(+), 18 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi > index 942290028972..d27c55c7f6e4 100644 > --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi > @@ -876,12 +876,16 @@ frame@b128000 { > > pcie1: pcie@10000000 { > compatible = "qcom,pcie-ipq9574"; > - reg = <0x10000000 0xf1d>, > - <0x10000f20 0xa8>, > - <0x10001000 0x1000>, > - <0x000f8000 0x4000>, > - <0x10100000 0x1000>; > - reg-names = "dbi", "elbi", "atu", "parf", "config"; > + reg = <0x000f8000 0x4000>, > + <0x10000000 0xf1d>, > + <0x10000f20 0xa8>, > + <0x10001000 0x1000>, > + <0x10100000 0x1000>; The unit address (the one after '@' in the node definition) is supposed to match the first 'reg' entry. So you need to update that and reorder the nodes accordingly. Krzysztof, is this acceptable to pick up given the reg entries are being shuffled around? Konrad