Re: [PATCH 3/4] ARM: dts: BCM5301X: Add DT for ASUS RT-AC3200

[Krzysztof Kozlowski <krzk@kernel.org>]

On 14/04/2024 18:59, Arınç ÜNAL wrote:
>>> +	};
>>> +
>>> +	memory@0 {
>>> +		device_type = "memory";
>>> +		reg = <0x00000000 0x08000000>,
>>> +		      <0x88000000 0x08000000>;
>>> +	};
>>> +
>>> +	nvram@1c080000 {
>>> +		compatible = "brcm,nvram";
>>> +		reg = <0x1c080000 0x00180000>;
>>
>> Why is this outside of soc? Both soc node and soc DTSI?
> 
> I don't maintain the SoC device tree files so I don't know. The nvram node
> doesn't exist on any of the device tree files included by this device tree.

There are two problems here:
1. This looks like SoC component and such should not be in board DTS.
Regardless whether you maintain something or not, you should not add
incorrect code. Unless this is correct code, but then please share some
details.

2. You cannot have MMIO node outside of soc. That's a W=1 warning.

Best regards,
Krzysztof