From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BF8D4A2E05 for ; Tue, 12 May 2026 10:04:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778580263; cv=none; b=G8ET8ES8NcnjcMvzYLmuEXON5CWgKGFoDMOtehKQagpI8Uo2dUHbzi/voRLW17smK4l0+Ovy40ohctLVMTWLT+zR4Oz2uVtY4xDrlYsVpvSNyKWOhfyFMqhBLVeWoGoRvAs9AdDvEYcmEHZo+0VGjZAyL6cLpDDbg8Occ7kHluo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778580263; c=relaxed/simple; bh=dH3eSM7f8VLLe5f6yZnNnzgC0LVj3cFbdyIYlGPbtGA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KNoW89K5soSO/eJ8FNjrsDoWEKhcaYFgRlXyvnrZt1NnC6MfZDaiyDoGyq2+NviCNzfoD86z4VyYT8D1e80+6nKBeziGzzzvfZ1XpnHytXcYgVhlAdlB4TY1WAtiuZD9qlndO6q83DISMjq3Ah1J3i+1dBf7mVXfwpgiDIiFKkk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HTy4Z3r1; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=nlZ2S0R7; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HTy4Z3r1"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="nlZ2S0R7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778580261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LlMuA9hwdFTP8K3r6A3IXWZ/9PMdiv8SdKkIEgo6+cU=; b=HTy4Z3r1cs0ih5AKTsNzQj9hAknzBxY15uK2Gz0wlI4dBA+uDv+P7scsCCmbtY2zhRFQWq /didr6y1pSI5OrkZsx3wib+WOLn4ADy3rVHt54rxlEL0OTq67N9Yk7ToRBPD5k8icJCpF2 Gube0hxPuT4g36A4VVRaUhgaR8jgZO0= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-433-6i4fjosBPxGQVZxp9KqYZw-1; Tue, 12 May 2026 06:04:20 -0400 X-MC-Unique: 6i4fjosBPxGQVZxp9KqYZw-1 X-Mimecast-MFC-AGG-ID: 6i4fjosBPxGQVZxp9KqYZw_1778580259 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-b940da8ec09so572638366b.1 for ; Tue, 12 May 2026 03:04:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778580259; x=1779185059; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LlMuA9hwdFTP8K3r6A3IXWZ/9PMdiv8SdKkIEgo6+cU=; b=nlZ2S0R7PKBll4SChjJASv6TTgx6jAgE/Ot6Trltd8yxt4Xk9hGtzQSUtdtUtWVB4C +jqtPUmsW3Edg7uw0i4yUd/M4O3xR9wtn/v/bXHqSGXno2ZeAGr93nwjRhV72mfbOo6I 0kUk23Th7mHHp35UaLNf8hI0mtWpIZvRkNnFV+JMG2oCUIPYpGT6zx/NfSQZBYpFa+lb Trek5EEqmWn2vYC3idP8zUKyCeBn9v18NCcHPcc2n5pvuNUphLR0qjnZkB+S6BjmpCfM S8xPXSw2XFla1XNJ5jB2mkB3QCEFc5Xj4xjrUqdJ/VbhKAJZKABJiO3Gh4Bc3s6OolU8 Fykg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778580259; x=1779185059; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LlMuA9hwdFTP8K3r6A3IXWZ/9PMdiv8SdKkIEgo6+cU=; b=G6wegss2vvFvIcR9y+mVNxhYwCKdyKYDanCXi7SdvLza9FkXd1mrWf4fIP3Vz8TdZJ Go7Ix2LcJBjwvwtLuZcFNB/mV9Oquh+aaQxlGr8pSaRMxvC7RT4B/WoTeecPVCkcUElx JY5RMm9jbKVrtMSW0bUNy050eZYCatihXlwLsDvsPkO91LKhNyVB3IzlaACKVJhyVdVl ar6WrjTDIufEOOKqF5Yp5Ouir9r0+QIpdP++wlya2j+J2BnryZEdREBtazNVS7acx6JJ nvfx4hztj6yuOx9BRNdjcqumSCyI8gwLMQ9ozQysCph/hYbKaZdqLx6CEfwQPXsMKs0N 7y6Q== X-Forwarded-Encrypted: i=1; AFNElJ/EIzRBWFEKkgdivFrHxEchUpIL+7OQyMz1Pm9uqvtLevPSZ3RJIIQGo4s10jE40Z3tAp0ho+6INSOQ67s=@vger.kernel.org X-Gm-Message-State: AOJu0YwMyIA2zfkiTYeeGryMsWy3O6ezsXTT0MuwrREcLZ/VEquMwCqn JElm7VM2rMZL6p4Py+Ojeuj+9xjEfT/OYAkTRbwAoykzXtMO8gpgzU5x2mnXUEnyO1FgaqtJvdR lfCf9xx7H7c0q0fkGLta0Ezjr9faUQh/gyRi8YH7Gyv+dgq7P9jfJ/9BBmFDkRoSK9w== X-Gm-Gg: Acq92OGOI42kF2OV3p9GIFHLeywdalXqSJvIMWb7qwdQmccsf+CTiUdVWWOIgDKQkhN Nr3vEmvjzGtLPjY9er5XLyh/8cXK+qToep8YB1Hh1wwJdpZ8uh5SxJ7hZhRWKx6lTe+rrv1rKDW QYsgZTMUis3TvGJkr8lcb84vxtn2akM4pENmU3iTCleySJXAADZ8JuYDWSex6rDFc7QGzwxWEVp wZ97bDs+5P/9wht3rhvj5OdnkoYDol8M0u/mEATRC7CQfq8e9PnilY2tLu8ZZrju0+NLmYgh7Ej XfcqxZC5CS0JYSeUq7oHAkKe1Zj4oVRt4bZ1H2w6oEUXcuQHzYEkYiXbsWGzeUOr2Zl+/dq+VBM Uvl9EtTZnSxnTHq5yyI47PXwrubBA78LX76fzamMzZK4RKR5fF0lDklg= X-Received: by 2002:a17:906:7310:b0:bd0:df77:98bb with SMTP id a640c23a62f3a-bd0df77c9d6mr433616666b.9.1778580259212; Tue, 12 May 2026 03:04:19 -0700 (PDT) X-Received: by 2002:a17:906:7310:b0:bd0:df77:98bb with SMTP id a640c23a62f3a-bd0df77c9d6mr433615266b.9.1778580258752; Tue, 12 May 2026 03:04:18 -0700 (PDT) Received: from [192.168.88.32] ([216.128.9.106]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bcac09c856asm656854166b.14.2026.05.12.03.04.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 May 2026 03:04:18 -0700 (PDT) Message-ID: Date: Tue, 12 May 2026 12:04:16 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 6/9] net: atlantic: implement AQC113 L2/L3/L4 RX filter management filter management management To: sukhdeeps@marvell.com, netdev@vger.kernel.org Cc: irusskikh@marvell.com, epomozov@marvell.com, richardcochran@gmail.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, vadim.fedorenko@linux.dev, linux-kernel@vger.kernel.org References: <20260506135706.2834-1-sukhdeeps@marvell.com> <20260508120156.3060-1-sukhdeeps@marvell.com> <20260508120156.3060-7-sukhdeeps@marvell.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260508120156.3060-7-sukhdeeps@marvell.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/8/26 2:01 PM, sukhdeeps@marvell.com wrote: > @@ -530,6 +580,35 @@ static int hw_atl2_hw_init_rx_path(struct aq_hw_s *self) > return aq_hw_err_from_flags(self); > } > > +static int hw_atl2_hw_mac_addr_set(struct aq_hw_s *self, const u8 *mac_addr) > +{ > + struct hw_atl2_priv *priv = self->priv; > + u32 location = priv->l2_filters_base_index; > + unsigned int h; > + unsigned int l; > + int err; Minor nit: please respect the reverse christmas tree above (and elsewhere) Side note: this patch is quite big, IMHO too much to be effectively reviewed without relying entirely on automated tools, please try split it into smaller chunks. Also, when posting the next revision please on avoid send the patch in reply to the previous iteration: it will foul both the tools and the human behind them. Finally please note that the patch subj contains repeated words, please drop them. /P