Re: [PATCH 07/10] iommu/vt-d: Replace Intel specific PASID allocator with IOASID

Jacob Pan
2019-11-18T18:45:35Z

On Mon, 18 Nov 2019 09:43:00 +0800
Lu Baolu <baolu.lu@linux.intel.com> wrote:

> Hi,
>
> On 11/16/19 7:09 AM, Jacob Pan wrote:
> > Make use of generic IOASID code to manage PASID allocation,
> > free, and lookup. Replace Intel specific code.
> > IOASID allocator is inclusive for both start and end of the
> > allocation range. The current code is based on IDR, which is
> > exclusive for the end of the allocation range. This patch fixes the
> > off-by-one error in intel_svm_bind_mm, where pasid_max - 1 is used
> > for the end of allocation range.
> >
> > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> > Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
>
> Two nit comments in line. With that fixed,
>
> Acked-by: Lu Baolu <baolu.lu@linux.intel.com>
>
Thanks, will fix below.
> Best regards,
> baolu
>
> [...]
>
> Nit - short line within 80 characters and align the new line with
> open parenthesis.
>
> [...]
>
> Nit - open parenthesis alignment.
>
> [...]

[Jacob Pan]