Re: [PATCH 03/10] iommu/vt-d: Reject SVM bind for failed capability check

Lu Baolu
2019-11-18T01:33:58Z

Hi,

On 11/16/19 7:09 AM, Jacob Pan wrote:
> Add a check during SVM bind to ensure CPU and IOMMU hardware capabilities
> are met.
>
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>

Acked-by: Lu Baolu <baolu.lu@linux.intel.com>

Best regards,
baolu

> ---
> drivers/iommu/intel-svm.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c
> index e9773d714862..924a4de84be1 100644
> --- a/drivers/iommu/intel-svm.c
> +++ b/drivers/iommu/intel-svm.c
> @@ -238,6 +238,9 @@ int intel_svm_bind_mm(struct device *dev, int *pasid, int flags, struct svm_dev_
> if (!iommu || dmar_disabled)
> return -EINVAL;
>
> + if (!intel_svm_capable(iommu))
> + return -ENOTSUPP;
> +
> if (dev_is_pci(dev)) {
> pasid_max = pci_max_pasids(to_pci_dev(dev));
> if (pasid_max < 0)
>