Re: [PATCH v1 1/3] dt-bindings: mmc: Add bindings for StarFive

Linus Walleij
2022-12-08T21:13:20Z

Hi William,

thanks for your patch!

On Wed, Dec 7, 2022 at 2:17 PM William Qiu <william.qiu@starfivetech.com> wrote:

> Add documentation to describe StarFive
> designware mobile storage host controller driver.
>
> Signed-off-by: William Qiu <william.qiu@starfivetech.com>

(...)

> + starfive,sys-syscon:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + description:
> + The desired number of times that the host execute tuning when needed.

This is not consistent with the use in the code of the attached driver.
There it is a phandle, and it has three cells, which I am critical of.
Also this description is hard to understand.

> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - interrupts

I don't think the syscon phandle is optional.

> + #include <dt-bindings/clock/starfive-jh7110.h>
> + #include <dt-bindings/reset/starfive-jh7110.h>
> + mmc@16010000 {
> + compatible = "starfive,jh7110-sdio";
> + reg = <0x16010000 0x10000>;

No syscon phandle in the example: this needs to be added.

Yours,
Linus Walleij