From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7F8818E377; Fri, 29 Aug 2025 06:55:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756450507; cv=none; b=TsZKSwOBZlilft2RNce1OKkvwct1EC54VcECgQpG5LoSqXeYkPwSjpH2IgBEzNoPgqozFIhfWbZuYoCTkDz+YXvpKx474GRGnzYj4YVZH+gzpKt++SxjPKqn2hL+8fUIpqqKKm1Gxhg48yh8PYYgBM7KEtBIUuUP3gYkRivEIIE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756450507; c=relaxed/simple; bh=v2HohlsHYo6pA7siTNEB6M/dNYVSNr2mWFTtHtWEkXY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Hfkuq4l7xIYQcf4vNifimPEjbVHMLHuEBqPdPU8QMtX928P4uQDHAiXCzs17iTUHliRI6cgMa15ELZ55cYzCRSSW4X90/L1y+a84LepxYUJZcodxA23pISGASW4gd3AMXMt17UvNCaV1T4ykmwbrnBfSTHhf9+Ij1S8OnuA89HA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mbqaHz2U; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mbqaHz2U" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43280C4CEF0; Fri, 29 Aug 2025 06:54:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756450506; bh=v2HohlsHYo6pA7siTNEB6M/dNYVSNr2mWFTtHtWEkXY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=mbqaHz2UQ/hJml+dSth4Qfs+j2RATzeSsy3V8Qb7EzvweX0l/Wh/14m7hMACiQ/cA bV89hs8pbMl7EX0bDgsAeyOYur9Ycy9obKqTRhihvv8QZrnudI0r3REVrAae8kLW8I 5G+hlldlluVt21h8o17AT8lxHAGIKEgfIVZApp+MBg4GKk+hcd72B0BUscFtWgBJdW PUkvRD2p5wOxMsFtPp2Gsh8icfT9Y+8UFys1eXsCya4Cey0P5d2aTRwuODTDMdRPK0 T//MWO4Wr847e1oEX5WbL0QoEMj2o6vvS0sNNt/Pnp77TVHIVdUHNMpVNqx888buIc WjEIKgM1U0yaw== Message-ID: Date: Fri, 29 Aug 2025 08:54:57 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 02/19] dt-bindings: clock: tegra20: Add IDs for CSI PAD clocks To: Mikko Perttunen , Thierry Reding , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter De Schrijver , Prashant Gaikwad , Michael Turquette , Stephen Boyd , Mauro Carvalho Chehab , Greg Kroah-Hartman , Dmitry Osipenko , Charan Pedumuru , Svyatoslav Cc: linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-staging@lists.linux.dev References: <20250819121631.84280-1-clamor95@gmail.com> <2451218.NG923GbCHz@senjougahara> <268A6593-1FAC-4A4D-925A-801FB6FEE9F6@gmail.com> <3173051.CbtlEUcBR6@senjougahara> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <3173051.CbtlEUcBR6@senjougahara> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 27/08/2025 12:27, Mikko Perttunen wrote: > On Wednesday, August 27, 2025 1:28 PM Svyatoslav wrote: >> 27 серпня 2025 р. 07:19:39 GMT+03:00, Mikko Perttunen > пише: >>> On Tuesday, August 19, 2025 9:16 PM Svyatoslav Ryhel wrote: >>>> Tegra30 has CSI PAD clock enable bits embedded into PLLD/PLLD2 registers. >>>> Add ids for these clocks. >>>> >>>> Signed-off-by: Svyatoslav Ryhel >>>> --- >>>> >>>> include/dt-bindings/clock/tegra30-car.h | 4 +++- >>>> 1 file changed, 3 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/include/dt-bindings/clock/tegra30-car.h >>>> b/include/dt-bindings/clock/tegra30-car.h index >>>> f193663e6f28..14b83e90a0fc >>>> 100644 >>>> --- a/include/dt-bindings/clock/tegra30-car.h >>>> +++ b/include/dt-bindings/clock/tegra30-car.h >>>> @@ -271,6 +271,8 @@ >>>> >>>> #define TEGRA30_CLK_AUDIO3_MUX 306 >>>> #define TEGRA30_CLK_AUDIO4_MUX 307 >>>> #define TEGRA30_CLK_SPDIF_MUX 308 >>>> >>>> -#define TEGRA30_CLK_CLK_MAX 309 >>>> +#define TEGRA30_CLK_CSIA_PAD 309 >>>> +#define TEGRA30_CLK_CSIB_PAD 310 >>>> +#define TEGRA30_CLK_CLK_MAX 311 >>>> >>>> #endif /* _DT_BINDINGS_CLOCK_TEGRA30_CAR_H */ >>> >>> The commit message refers to tegra20, but contents are tegra30. >> >> My, bad, it should be tegra30 >> >>> Regarding the CLK_MAX define, I agree that it would be better to get rid of >>> it. Perhaps you can check if it would be reasonable to calculate it >>> dynamically in the driver, but a define and sanity check in the driver >>> would work too, I think. >> >> It is not unreasonable, but moving this elsewhere may cause issues with >> adding new clocks. Addind new clocks would require updating not only header No, there are no such issues. >> but also a place where max clocks are moved to and ai am not sure how can I >> dinamically calculate amount of clocks in the driver without updating both >> header and driver with each new clock added. Maybe you can propose a >> method? > > Looking at the code, it's probably better to just move the CLK_MAX define into Just like every other driver. > the source code. We can leave a comment here as reminder to update the define > in the code if any new clocks are added. This happens so rarely that I don't > think it should be a problem. No, don't leave comments here. There is no single risk of breakage, there is no issue to fix with that comment. If you add clock to the driver WITHOUT binding, nothing, absolutely nothing bad will happen. You will just not have a way to use that clock in DTS. Best regards, Krzysztof