Re: [PATCH v2 3/8] dt-bindings: mips: realtek: Add rtl930x-soc compatible

[Krzysztof Kozlowski <krzk@kernel.org>]

On 24/06/2024 03:22, Chris Packham wrote:
> Add the rtl930x-soc and RTL9302C board to the list of Realtek compatible

930x or 9302?

> strings.
> 
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> 
> Notes:
>     Changes in v2:
>     - Use specific compatible for rtl9302-soc
>     - Fix to allow correct board, soc compatible
> 
>  Documentation/devicetree/bindings/mips/realtek-rtl.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mips/realtek-rtl.yaml b/Documentation/devicetree/bindings/mips/realtek-rtl.yaml
> index f8ac309d2994..05daa53417e5 100644
> --- a/Documentation/devicetree/bindings/mips/realtek-rtl.yaml
> +++ b/Documentation/devicetree/bindings/mips/realtek-rtl.yaml
> @@ -20,5 +20,9 @@ properties:
>            - enum:
>                - cisco,sg220-26
>            - const: realtek,rtl8382-soc
> +      - items:
> +          - enum:
> +              - realtek,rtl9302c

Why board has the name of SoC?

> +          - const: realtek,rtl9302-soc

Drop the -soc suffix. The rtl9302 is the soc.

>  
>  additionalProperties: true

Best regards,
Krzysztof