From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCEB13F076E for ; Tue, 4 Aug 2026 02:56:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785812166; cv=none; b=M77Oa7wQc7IDTCiL1cqKcSPTI2nvdN6oaO9X4IpxOypvvDmlD7gOogF9Rf6xo1R1stn/B3ITkC6064wmLg7odKB3IDW/g+iKFI+SV0a9CRslX0UlhDAXyIvWmKo1b2oCXMMufnD/uJr/W5a6aRXakMgJTmfE+EQwq8xDXL91Mvk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785812166; c=relaxed/simple; bh=3evm5utYl+pfb/FVlDlS66XtZOxOeOCr5q8i2t7DPd4=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=fvzG0rZ8FWxpvz1b9yluZ0J39/cC76SkN54n8H2fqs+VHx2nyWPlL7Utsvr4r2kxy9kkapjoE8akHUupM+1rdpWFrjZ1Hrv/kRV/2OC1hVdvzSWK2hpmDv5V3l1Dh7R6H4yqmPwLSPZzdbBLOCNk7Ccj7vE3ho3vOecbSAYGNT4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Bdu02aeb; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Bdu02aeb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C85B1F000E9; Tue, 4 Aug 2026 02:56:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785812163; bh=9fKWkyBXLwM7WyN7+yHyKvtPgNDr1bdwv61Pe/sas1Y=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=Bdu02aebURC/bLfarcWBkaRymeJ0Lpk7MbAvfjqwOmki4PDUxA6PQpifTb252GQ6G HCJddJ+H6k6DHysh59tYJZC3R1duhkUEbQlVwuOdL5LPiffkdqM14e2BZnlaHtTFAc 5yd+jWpnjfU7r2RmaaGMWaLcQESSQPmTS9oSRGRQ1dHD54SZeYVrF3llJW/qfzcLwu cZFbXMVwehMnShCMhJdTxdTufJP1ADjkVRUx2Y1uBAOSyYSj2jOV6FKTmviX+KiMx6 q6qQsJqKjxkhoDh3irquOWeVeOSAdwSl4ZlfMST6L54JBYVrZcmEzzyAX0URsdlOMz /ZOmCZq+pYyvQ== Message-ID: Date: Tue, 4 Aug 2026 10:56:00 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, stable@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, qiwenjie@xiaomi.com Subject: Re: [PATCH v4 2/2] f2fs: protect critical_task_priority updates with s_umount To: Wenjie Qi , jaegeuk@kernel.org References: <20260804014849.1942326-1-qiwenjie@xiaomi.com> <20260804014849.1942326-2-qiwenjie@xiaomi.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20260804014849.1942326-2-qiwenjie@xiaomi.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/4/26 09:48, Wenjie Qi wrote: > The sysfs store path already takes s_umount for GC thread control > entries, and ckpt_thread_ioprio is covered as well. > > critical_task_priority also updates checkpoint or GC kthread scheduling > state, but it is not covered by that serialization. It can race with > remount or teardown paths that are stopping those threads. > > Protect critical_task_priority sysfs writes with s_umount too. > > Fixes: 52190933c37a ("f2fs: sysfs: introduce critical_task_priority") > Cc: stable@kernel.org > Signed-off-by: Wenjie Qi Reviewed-by: Chao Yu Thanks,