From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19F663D9DDC for ; Tue, 28 Apr 2026 09:50:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777369822; cv=none; b=A999/b/5SwAqFrEshyOaSEWd0GN/sNZncZGonji4knOjaPPQe4s5Q0iBCZQ58sCSNmwGnjUuMrLDOPtvIsX2psl22wNHBAb4sen9UeiqEnGpfYekF6DNydK0feE0Gk6n0hreGriI7a2cQw8vUDIefebZ05RIa/LR4kZXUk1Thdw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777369822; c=relaxed/simple; bh=xJHqPBiTn94yBzMImM4YOFZy7uS41sjz0uqcdavPIHw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PqEqLKH3zJWHNJRiXAMN3G7IO3hfpRRhWyCBYs6WE4TlDo4ebXHVok5djmdaxwWXb8VkhtPKG9+I9MBaOLtswb5Z5BcxHVAZe2b5FypDy1HbkM68P34f3ywJynOMf97+KYTEO9llclounomy0lQyI8uFNF2TFsT2fSHYULJErnA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FcizD0zR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PDFUrll7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FcizD0zR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PDFUrll7" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63S7uxXa3968127 for ; Tue, 28 Apr 2026 09:50:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rSgFwP34wCo85AXhGbCR+4Z8PnplijHqeQr5lFbp24E=; b=FcizD0zRNxc6cpHg 57cp96c0X25V4Dg1/329BfSZWxMwjav9fnBsOhuvrLjRGlirvmTJgyxdzfEzU6aH CmH9V1X6eiZoBbOm9uvewtLkESS3c2Qlr20WZQ0BEvEpHqfaabvVYzq5dHjehO2z kPyD83i6EfmB5A+IiXuDh4LjbzYDjzVcfxWBuuntAx6drxwRwYpRHtiYjuDF0miz p8owDTw1csDLaJV6VpPFMMo7y3nKmz7JzG7jyDWkPf7YYMiYuCW9XQqS6BNp2yRu +pYwUNxn5uTZVyoJGNZCEPBBFzPTYJcELIyDyFabnwm33FUv3w8GFc4pypy75gC1 v8CCgw== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dtry0gevm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 28 Apr 2026 09:50:18 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8b047093195so21447026d6.3 for ; Tue, 28 Apr 2026 02:50:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777369818; x=1777974618; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rSgFwP34wCo85AXhGbCR+4Z8PnplijHqeQr5lFbp24E=; b=PDFUrll7DcQ8/zHxh5ZIoyNvbqxP3o7PPcXaAYyswwFWmFCnaaVksDiRVy0JqwvY+n Ub+JiEzs/wrxFuVCZL60nf7OzbtasJbHEOXH7vvBUrLko8CcDtGBrkCvlbsAwMy+dYzS bz2NKtMTISHoUCOZ64y14B+oNLo9LOsxoC8IB95DTHTXPf/miw5PunP3viYkjaLC9VuP vadMt91hpqVUobQXAft25qkyATMKfwGKP1GAA6HSYRDw4JQ29TljTR/k2T979zLsEkEY MsyXkL5Bh/rn+RP5+wSsXWS5IxliIjVn4f8vIq83ioWG9wLeIhXIIib7zQmSK2KszsVi Pt9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777369818; x=1777974618; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rSgFwP34wCo85AXhGbCR+4Z8PnplijHqeQr5lFbp24E=; b=rq37qos9bkzheqGk0BfA4cZQTCm8gXq2ETuM+0uCi+NF2fiH2bFcTO1adC2J7Y3qq5 O8DrdRDn0WUodrLq1B/8U8wGkK9bijP0Bqcvwl+jEkn6r7OtKxvRyNqeqWESlbhoLjs+ TifgmtPcj3FayhENR79MNjZSGreZ8M+pbZd3CXyrU4KUeOjARgP8OQaWu8NrxjamoWC6 GIVeGGe+c8TPgX8xk4QXqD95YowoaSh0BrQ5QLVDcLLJQlVU4Nn4iL/Zcv9rZmuWWiLk 42lgOJxXZxdF3BgB4Mxjopu9Q+o55b+t6rFSU4gfdmgB++6JN5KAQvEzw4tOHUsRZypV sKdg== X-Forwarded-Encrypted: i=1; AFNElJ/qWJasUZla/I9sBkXua477oOm+lmPEsReyAqLYGJl6WQdodTB1YQlta4nKXVIn18Gdd/CYhRZ7CACN2r4=@vger.kernel.org X-Gm-Message-State: AOJu0YwGCKBOzhxr6VKD0d9CoZno6rDtnidCNDtB1zSdM1pnvPXlJonZ 1QKbkHTZ7BDKs4BDnc7cg9o2yHbbSSUnvPJ8g8s5g7X3FdTl6Cax4oP0y75XA1e2L9I5esEjJca 2kYmd3knkJNIkPjgE3wQHasgvg5oxa4CLi1HYc4e7eAlfHk0ifTuBl29VZGaDe2+TpAk= X-Gm-Gg: AeBDies2YYlpiSzkm7x3rEcSvUddQSp718m+FRtksEZFL0Mdkg4IU95yUvhBNJcUFr7 mMYzXCiK7fYdFSawa2GuhO6bQbnyhEwvcLN0aVL+IaDWuB9cD2/2hI2wEzCf2G+Vj2CtC2e3o2H PXqW7cBJSLeQyhIYpt1g1U28JVzY9ewLry5RqBBc27K3jZEfkAtUagYqXoOAH19O2a9hvFND604 viS1E9Um2zHhWqwUba/pAaZtETQ5DbRt8CU98QAbAYcxNTHX4qN10fsO4+K4nJ6dwtxq4IrdDoq N5nGWjUGAIGZ1XCCS9nYh8Cr57X5ThgPhWHI09iKmbz4AHsQjKMHr2Z1nsrSG/pAiDGT8ZPBsS8 3schL0WiRlqlK2auCoQhcCYrU21HtiQiO/Y8iU/vPXyWqzz0EAnmLXsncc5miTsN3ghCsWeRlKY mn+X60bFIBMsifMw== X-Received: by 2002:a05:6214:caf:b0:89c:e371:2b42 with SMTP id 6a1803df08f44-8b3e283bb10mr30341436d6.2.1777369818285; Tue, 28 Apr 2026 02:50:18 -0700 (PDT) X-Received: by 2002:a05:6214:caf:b0:89c:e371:2b42 with SMTP id 6a1803df08f44-8b3e283bb10mr30341026d6.2.1777369817780; Tue, 28 Apr 2026 02:50:17 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bb80853e641sm77209466b.10.2026.04.28.02.50.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2026 02:50:16 -0700 (PDT) Message-ID: Date: Tue, 28 Apr 2026 11:50:13 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 11/14] dt-bindings: media: qcom,qcm2290-camss: Add OPE ISP subnode To: Krzysztof Kozlowski , Loic Poulain Cc: Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab , Kees Cook , "Gustavo A. R. Silva" , Bryan O'Donoghue , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, devicetree@vger.kernel.org, laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com References: <20260427-camss-isp-ope-v2-0-f430e7485009@oss.qualcomm.com> <20260427-camss-isp-ope-v2-11-f430e7485009@oss.qualcomm.com> <20260428-demonic-albatross-of-enrichment-aa6f26@quoll> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260428-demonic-albatross-of-enrichment-aa6f26@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=KuJ9H2WN c=1 sm=1 tr=0 ts=69f082db cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=axVsYsM61IUpGc0LCtEA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-GUID: eOP0HwKv5hxP4JSsj84TrHkrkONEDVU6 X-Proofpoint-ORIG-GUID: eOP0HwKv5hxP4JSsj84TrHkrkONEDVU6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI4MDA4NSBTYWx0ZWRfX0tr3q/JtErEb PcWYoQV4RUxJeUuNBIIP9/t5Qx0hW0z6QEgan807d19n/YkmhwhJwpPIr1PLWmgNflIqjJeGF5U xdQiGaZiZ0fVKaFLkbRyhWPjpoB3HWrMEldHmusDpi0j9tK8lQpdUpqs36KC4RWL8DRN+w/oR4o W2Zne4+8FR8Lo8mDknmkuYuknTO9QlRyx5TXjzC1uUFkdE/yOH3yu77nYKTOc/wpl16RHMfDNnP sJU7Mi9SHWzzmNl0N3RIeP+tkU1PyWgz1WAr4nW8zOThU771va1/FEEtHEQ0wU2wzOngwAYBP8k Ms2vcj+4JukNi411CoRFXafmgu1Du7/MAgM0SvJxVA2KfR6tryutq5MzkxIAReHVn3+2zVAfWaO n4jdFEwtlIbSaERwmoL17c4IsLoXqGspWRf0+pX23dc3LLNN0G3IFfWPwxMBLCnk51epD/fXVjk +kEb4Uf6MaF32skTKPg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-28_02,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 bulkscore=0 malwarescore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604280085 On 4/28/26 8:35 AM, Krzysztof Kozlowski wrote: > On Mon, Apr 27, 2026 at 02:43:38PM +0200, Loic Poulain wrote: >> Extend the qcm2290 CAMSS binding to describe CAMSS as a simple bus by >> allowing child ISP nodes. Add the required address and size cells, as >> well as ranges, and validate ISP subnodes against the existing >> qcom,qcm2290-camss-ope schema. >> >> On qcm2290 the OPE (Offline Processing Engine) is a memory-to-memory >> ISP (Image Signal Processor). >> >> Signed-off-by: Loic Poulain >> --- >> .../devicetree/bindings/media/qcom,qcm2290-camss.yaml | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml b/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml >> index 391d0f6f67ef5fdfea31dd3683477561516b1556..d8b356028e24c3c5b2e9b7f20e220db7d491ad68 100644 >> --- a/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml >> +++ b/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml >> @@ -52,6 +52,14 @@ properties: >> - const: vfe1 >> - const: vfe1_cphy_rx >> >> + '#address-cells': > > Please use consistent quotes, either ' or " > >> + const: 2 > > This means the child will use 64-bit addressing, but does it need that? > Or do you need that to have 36-bit DMA addressing? If there are true no > needs for above, usually recommendation is to use narrowe address space > for children, so only 32-bit. I can't find data for this platform, but on e.g. Hamoa, most camera components can address 36b Konrad