From: Florian Fainelli <f.fainelli@gmail.com>
To: Doug Berger <opendmb@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Al Cooper <alcooperx@gmail.com>
Cc: Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_bcm7271: Fix arbitration handling
Date: Thu, 9 Mar 2023 11:07:03 -0800 [thread overview]
Message-ID: <e75a1c0f-886e-fd89-0876-dc883f75c809@gmail.com> (raw)
In-Reply-To: <20230309190224.687380-1-opendmb@gmail.com>
On 3/9/23 11:02, Doug Berger wrote:
> The arbitration of the UART DMA is mishandled for a few
> exceptional cases when probing and releasing the driver.
>
> It is possible that the DMA register spaces are not defined in
> device tree for an instance of the driver, so attempts to access
> the registers in brcmuart_arbitration() would use NULL pointers.
>
> It is also possible for the probe function to return an error
> while still holding the UART DMA. This would prevent the UART
> DMA from being claimed by an instance that could use it.
>
> These errors are addressed by only releasing the UART DMA if it
> is held by this instance (i.e. priv->dma_enabled == 1) and
> directing early error paths in probe to this common release_dma
> handling.
>
> Fixes: 41a469482de2 ("serial: 8250: Add new 8250-core based Broadcom STB driver")
> Signed-off-by: Doug Berger <opendmb@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
prev parent reply other threads:[~2023-03-09 19:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 19:02 [PATCH] serial: 8250_bcm7271: Fix arbitration handling Doug Berger
2023-03-09 19:07 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e75a1c0f-886e-fd89-0876-dc883f75c809@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=opendmb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox