From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59EB9309DB1 for ; Fri, 8 May 2026 18:54:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778266449; cv=none; b=n8Nt78WI+niWcn23h+3q2Mk9je1xF98PCu7R+H6AQ5AO57sW46ay7XBI3K50bgS4ZVnxGTIhpkUrnw9Ov/MQThvixVgqdJa8vNiuX740PsoVQ2qOSRztAQ3nNsWqzMw81dMxJe/tCmUCz2aGlHy/ivHTGm/IgJlxA5dG2yprQCg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778266449; c=relaxed/simple; bh=L1E/blLI4k6UorZ+ID943dbIzAQ/avgGzddJ12FZNmk=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=IK5bEOgh8rMueufk1WUInB1CilkOjch10lO2IuZhAFhUnRADtwEFoJqFd8Dv9NvlUk9EPt+UwDZPx2kSrSLy1HKLYFZns/hIcYjZnOVdkJSU3ZRWfW3x7olwmqTVuY3XgB4USm4SwSBMqbizE2gDSBuzE9Hukwdgc+IRRwuw4js= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gfpA3bq1; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=HYDSurCo; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gfpA3bq1"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="HYDSurCo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778266447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nw5Hfi8KU2h83icRdaxsQgdWasba3ZiPDgOGZW2eFxA=; b=gfpA3bq1tgN7fb9Bg0y1p3BPqYBWwDEfiE/gvZlivXrgtR0ZWTrO3GW8SPOSHU16dkLFQ0 DE82FeUCnfXOmMdeXvVA4UYpg/20H4qtFVRQ6XIbA1eHJ+c4pFU+1kPmn0k0KIuJZ9fdqo KfJbb/q49tCmHIv6Fmwk3xImhpxHgmo= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-316-OBs_B611N-mhNCMPCgOkAg-1; Fri, 08 May 2026 14:54:04 -0400 X-MC-Unique: OBs_B611N-mhNCMPCgOkAg-1 X-Mimecast-MFC-AGG-ID: OBs_B611N-mhNCMPCgOkAg_1778266443 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50da529ff48so51468931cf.3 for ; Fri, 08 May 2026 11:54:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778266443; x=1778871243; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Nw5Hfi8KU2h83icRdaxsQgdWasba3ZiPDgOGZW2eFxA=; b=HYDSurCoUvckOhul5ApeA/jusnIZkJtRq9J8MR2k7KEbg0NW//NpPnvvmhcYHBIbX4 kCNpGI9MobqEjnzPGttOqtNR30gLMS/PszzTVSaaLzmzvxSpfBGt0t0UlLfx6vCoQSxo ylX/RisodsBGbBuUm5TxBjgdWfbRfBMHT2kPneMNoQ2ilNa/XwUsFKxIyRUC3c2Cw9zt lAIcvpzXTsyArX0NBhEVZoqNECH94eFEsgPTyhFLPMwSTsGpKR53rMrJS0n1iMD2xlzY 7t2IWoAD5HT61Ptc78rbwqP3gYhgRlxC7/OVwuvjxykzdlY8ba61YJWH3sXQAANMhifw vxHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778266443; x=1778871243; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Nw5Hfi8KU2h83icRdaxsQgdWasba3ZiPDgOGZW2eFxA=; b=W6+AsJPzLxBjnyY1X6rC5pSQJmmJwxpFp/HxBcrgFUMh9f24nIyrzEf+tvPtnAWXKu k38WWNB8ajO00YKRBjLraVJgB3U+87+IR1ONSWfOL5KIbEtZ/IcvSM5dia3mfS+Y7/C+ sqXyyJ3TQhZ8SgNXJFNu+CsfNBLKWV7FObRRTT4cyoCFo+V6+fZ+u1PZHO3Qdtb7vhHM /9Ka9ym3l7gUO+erla+y/B79V31lHnb9N9RPLCFj5VbgqaZKd1XoTFRn33/rKY4fzQpF j+sFiF3NT2DmBH7u+8LyvnjAJGglpB7Jqf9gzTDM37VQoWV+NRNQfnGGqH5eCuvVGpKs BTjg== X-Forwarded-Encrypted: i=1; AFNElJ9766FbZ9H4FMTeSsG8htwYtZTp/x3JKYLwRV7ZrF4PDahuQh3/BvKSLr3GMNcQUZXWR6jSqn6aDoQEfQw=@vger.kernel.org X-Gm-Message-State: AOJu0Yxmn8r5cdsiXJJWgWKAVnBDv6Tsf5ovFunjNdfMvqoBvNGdnqMR gjeLYceDv1fMpLgNlvcjf+PEelXe8ki+dGAb8VL/nIelxRC3DXfftUSS9xs1bW2Fmzxo7JiTzGJ Hm/IJq2zA1K2IDes9t+K7/Inhk3ZSjgbMXh68nLIgzqWi44XZE993nfS/mgqsLtm83A== X-Gm-Gg: AeBDieswtiemTi06Ga/SXR4pd2N/14/6gWXfY6EFWUJU8Qz95OiZ+xNamjHMdy5F3jq kQmzfLGmtICVrQpb/Qg51rCaQ0XLmmXl6s//I+uyyfpnd78UjGvYms4yt29V+bqlLm8NeAWX/UF SFpOtcK7y2G+XnxJ21Sej07JCtSb7YDYCA0WxYKX6SReBVqrwXCrn71SZruacCj1tUAE13m3iGC 4kpT/cj2BlqYy0vICFRRDUzqxzc1B/NvJVgMEPZjyxIFyvQGZqzGT9n6VJ/255EH1Ca9kkqPpdB Y5nySxCnkL7qVhZRQQ6udPhEkBRD2/Gvhqwmogv/o13nqOIPYLA2C8wCvQUAW4oBQfQ3DuwNZNN kascECzxD7ef4YOXR5Op8Y1t4edDJ X-Received: by 2002:ac8:59d3:0:b0:509:23ee:b9a5 with SMTP id d75a77b69052e-514619ddbddmr188659961cf.5.1778266443439; Fri, 08 May 2026 11:54:03 -0700 (PDT) X-Received: by 2002:ac8:59d3:0:b0:509:23ee:b9a5 with SMTP id d75a77b69052e-514619ddbddmr188659591cf.5.1778266442983; Fri, 08 May 2026 11:54:02 -0700 (PDT) Received: from [192.168.8.4] ([100.0.180.93]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5148e7c0289sm27365411cf.18.2026.05.08.11.54.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 11:54:02 -0700 (PDT) Message-ID: Subject: Re: [PATCH] drm/nouveau/gsp: Use kzalloc_flex() for r535 display funcs From: lyude@redhat.com To: Rosen Penev , nouveau@lists.freedesktop.org Cc: Danilo Krummrich , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" , open list Date: Fri, 08 May 2026 14:54:01 -0400 In-Reply-To: <20260508052056.1744665-1-rosenp@gmail.com> References: <20260508052056.1744665-1-rosenp@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reviewed-by: Lyude Paul There's one change to make below, but I will just handle it locally before pushing: On Thu, 2026-05-07 at 22:20 -0700, Rosen Penev wrote: > struct nvkm_disp_func ends with the user flexible array member. > Allocate the > r535 display function table with kzalloc_flex() instead of open- > coding the > size calculation with sizeof(). >=20 > This makes the allocation describe the object being allocated > directly and > keeps the fixed six user entries unchanged. >=20 I assume this was the AI talking, but this sentence seems like a nothing-burger. Will just drop it from the commit. > Assisted-by: Codex:GPT-5.5 > Signed-off-by: Rosen Penev > --- > =C2=A0drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/disp.c | 3 ++- > =C2=A01 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/disp.c > b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/disp.c > index 6e63df816d85..1155f079b0c3 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/disp.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/disp.c > @@ -1734,7 +1734,8 @@ r535_disp_new(const struct nvkm_disp_func *hw, > struct nvkm_device *device, > =C2=A0 struct nvkm_disp_func *rm; > =C2=A0 int ret; > =C2=A0 > - if (!(rm =3D kzalloc(sizeof(*rm) + 6 * sizeof(rm->user[0]), > GFP_KERNEL))) > + rm =3D kzalloc_flex(*rm, user, 6); > + if (!rm) > =C2=A0 return -ENOMEM; > =C2=A0 > =C2=A0 rm->dtor =3D r535_disp_dtor;