The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Niklas Schnelle <schnelle@linux.ibm.com>
To: Heiko Carstens <hca@linux.ibm.com>,
	Alexander Gordeev	 <agordeev@linux.ibm.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Vasily Gorbik	 <gor@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Gerd Bayer <gbayer@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] s390/pci: Enable CONTEXT_ANALYSIS
Date: Mon, 03 Aug 2026 16:55:23 +0200	[thread overview]
Message-ID: <e78a9a19faf21349e81d47026e6fb180eba67e00.camel@linux.ibm.com> (raw)
In-Reply-To: <20260803142907.1771509-1-hca@linux.ibm.com>

On Mon, 2026-08-03 at 16:29 +0200, Heiko Carstens wrote:
> v2:
> 
> - Address potential zdev reference leak (false positive) by adding a
>   comment, and moving get_zdev_by_fid() [Sashiko, Niklas]
> 
> - Note: this reveals a pre-existing bug: zpci_remove_reserved_devices()
>   calls zpci_device_reserved() without holding locks. It looks like
>   this can be fixed easily by adding a mutex_lock()/mutex_unlock()
>   pair in zpci_remove_reserved_devices(), but that is not within
>   the scope of this series, and up to the pci maintainers

I agree with this assessment and can provide a patch on top of this
series to address this.

Thanks,
Niklas

      parent reply	other threads:[~2026-08-03 14:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-03 14:29 [PATCH v2 0/3] s390/pci: Enable CONTEXT_ANALYSIS Heiko Carstens
2026-08-03 14:29 ` [PATCH v2 1/3] s390/pci: Rework __zpci_event_error() to remove conditional locking Heiko Carstens
2026-08-03 16:40   ` Niklas Schnelle
2026-08-03 14:29 ` [PATCH v2 2/3] s390/pci: Rework__zpci_event_availability() " Heiko Carstens
2026-08-05 11:32   ` Niklas Schnelle
2026-08-05 12:43     ` Heiko Carstens
2026-08-03 14:29 ` [PATCH v2 3/3] s390/pci: Enable CONTEXT_ANALYSIS Heiko Carstens
2026-08-05 13:22   ` Niklas Schnelle
2026-08-03 14:55 ` Niklas Schnelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e78a9a19faf21349e81d47026e6fb180eba67e00.camel@linux.ibm.com \
    --to=schnelle@linux.ibm.com \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=gbayer@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=svens@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox