PATA driver patch for 2.6.17

PATA driver patch for 2.6.17

[Alan Cox]

http://zeniv.linux.org.uk/~alan/IDE

This is basically a resync versus 2.6.17, the head of the PATA tree is
now built against Jeffs tree with revised error handling and the like.

Alan

Re: PATA driver patch for 2.6.17

[Marcus Furlong]

Alan Cox wrote:

> http://zeniv.linux.org.uk/~alan/IDE
> 
> This is basically a resync versus 2.6.17, the head of the PATA tree is
> now built against Jeffs tree with revised error handling and the like.
> 
> Alan

I get the following bug while booting:

Linux version 2.6.17 (root@collins) (gcc version 3.4.6 (Gentoo 3.4.6-r1,
ssp-3.4.5-1.0, pie-8.7.9)) #4 PREEMPT Mon Jun 19 20:29:48 IST 2006
BIOS-provided physical RAM map:
BIOS-e820: 0000000000000000 - 000000000009f000 (usable)
BIOS-e820: 000000000009f000 - 00000000000a0000 (reserved)
BIOS-e820: 0000000000100000 - 000000003ffda000 (usable)
BIOS-e820: 000000003ffda000 - 0000000040000000 (reserved)
BIOS-e820: 00000000e0000000 - 00000000f0007000 (reserved)
BIOS-e820: 00000000f0008000 - 00000000f000c000 (reserved)
BIOS-e820: 00000000fec00000 - 00000000fec10000 (reserved)
BIOS-e820: 00000000fed20000 - 00000000fee10000 (reserved)
BIOS-e820: 00000000ffb00000 - 0000000100000000 (reserved)
127MB HIGHMEM available.
896MB LOWMEM available.
DMI 2.3 present.
ACPI: PM-Timer IO Port: 0x1008
ACPI: LAPIC (acpi_id[0x00] lapic_id[0x00] enabled)
Processor #0 6:13 APIC version 20
ACPI: LAPIC (acpi_id[0x01] lapic_id[0x01] disabled)
ACPI: LAPIC_NMI (acpi_id[0x00] high edge lint[0x1])
ACPI: LAPIC_NMI (acpi_id[0x01] high edge lint[0x1])
ACPI: IOAPIC (id[0x01] address[0xfec00000] gsi_base[0])
IOAPIC[0]: apic_id 1, version 32, address 0xfec00000, GSI 0-23
ACPI: INT_SRC_OVR (bus 0 bus_irq 0 global_irq 2 dfl dfl)
ACPI: INT_SRC_OVR (bus 0 bus_irq 9 global_irq 9 high level)
Enabling APIC mode:  Flat.  Using 1 I/O APICs
Using ACPI (MADT) for SMP configuration information
Allocating PCI resources starting at 50000000 (gap: 40000000:a0000000)
Built 1 zonelists
Kernel command line: root=/dev/ram0
netconsole=@192.168.1.150/eth0,514@192.168.1.100/00:12:3f:94:14:0e
vga=0x317 real_root=/dev/sda3 init=/linuxrc video=vesafb:mtrr:3,ywrap
libata.atapi_enabled=1
netconsole: local port 6665
netconsole: local IP 192.168.1.150
netconsole: interface eth0
netconsole: remote port 514
netconsole: remote IP 192.168.1.100
netconsole: remote ethernet address 00:12:3f:94:14:0e
Enabling fast FPU save and restore... done.
Enabling unmasked SIMD FPU exception support... done.
Initializing CPU#0
CPU 0 irqstacks, hard=c0576000 soft=c0575000
PID hash table entries: 4096 (order: 12, 16384 bytes)
Detected 1862.367 MHz processor.
Using pmtmr for high-res timesource
Console: colour dummy device 80x25
Dentry cache hash table entries: 131072 (order: 7, 524288 bytes)
Inode-cache hash table entries: 65536 (order: 6, 262144 bytes)
Memory: 1033100k/1048424k available (2930k kernel code, 14572k reserved,
1408k data, 200k init, 130920k highmem)
Checking if this processor honours the WP bit even in supervisor mode... Ok.
Calibrating delay using timer specific routine.. 3727.80 BogoMIPS
(lpj=1863900)
Security Framework v1.0.0 initialized
Capability LSM initialized
Mount-cache hash table entries: 512
CPU: L1 I cache: 32K, L1 D cache: 32K
CPU: L2 cache: 2048K
Intel machine check architecture supported.
Intel machine check reporting enabled on CPU#0.
CPU: Intel(R) Pentium(R) M processor 1.86GHz stepping 08
Checking 'hlt' instruction... OK.
SMP alternatives: switching to UP code
Freeing SMP alternatives: 0k freed
ENABLING IO-APIC IRQs
..TIMER: vector=0x31 apic1=0 pin1=2 apic2=-1 pin2=-1
checking if image is initramfs... it is
Freeing initrd memory: 758k freed
NET: Registered protocol family 16
ACPI: bus type pci registered
PCI: Using MMCONFIG
Setting up standard PCI resources
ACPI: Subsystem revision 20060127
ACPI: Interpreter enabled
ACPI: Using IOAPIC for interrupt routing
ACPI: PCI Root Bridge [PCI0] (0000:00)
ACPI: Assume root bridge [\_SB_.PCI0] bus is 0
PCI quirk: region 1000-107f claimed by ICH6 ACPI/GPIO/TCO
PCI quirk: region 1080-10bf claimed by ICH6 GPIO
PCI: Ignoring BAR0-3 of IDE controller 0000:00:1f.2
PCI: Transparent bridge - 0000:00:1e.0
PCI: Bus #04 (-#07) is hidden behind transparent bridge #03 (-#04)
(try 'pci=assign-busses')
Please report the result to linux-kernel to fix this permanently
ACPI: PCI Interrupt Link [LNKA] (IRQs 9 10 *11)
ACPI: PCI Interrupt Link [LNKB] (IRQs 5 7) *10
ACPI: PCI Interrupt Link [LNKC] (IRQs *9 10 11)
ACPI: PCI Interrupt Link [LNKD] (IRQs 5 *7 9 10 11)
ACPI: PCI Interrupt Link [LNKE] (IRQs 3 4 5 6 7 9 10 11 12 14 15) *0,
disabled.
ACPI: PCI Interrupt Link [LNKF] (IRQs 3 4 5 6 7 9 10 11 12 14 15) *0,
disabled.
ACPI: PCI Interrupt Link [LNKH] (IRQs 3 4 5 6 7 9 10 11 12 14 15) *0,
disabled.
Linux Plug and Play Support v0.97 (c) Adam Belay
pnp: PnP ACPI init
pnp: PnP ACPI: found 11 devices
SCSI subsystem initialized
usbcore: registered new driver usbfs
usbcore: registered new driver hub
PCI: Using ACPI for IRQ routing
PCI: If a device doesn't work, try "pci=routeirq".  If it helps, post a
report
pnp: 00:02: ioport range 0x4d0-0x4d1 has been reserved
pnp: 00:02: ioport range 0x1000-0x1005 could not be reserved
pnp: 00:02: ioport range 0x1008-0x100f could not be reserved
pnp: 00:03: ioport range 0xf400-0xf4fe has been reserved
pnp: 00:03: ioport range 0x1006-0x1007 has been reserved
pnp: 00:03: ioport range 0x100a-0x1059 could not be reserved
pnp: 00:03: ioport range 0x1060-0x107f has been reserved
pnp: 00:03: ioport range 0x1080-0x10bf has been reserved
pnp: 00:03: ioport range 0x10c0-0x10df has been reserved
pnp: 00:08: ioport range 0x900-0x90f has been reserved
pnp: 00:08: ioport range 0x910-0x91f has been reserved
pnp: 00:08: ioport range 0x920-0x92f has been reserved
pnp: 00:08: ioport range 0x930-0x93f has been reserved
pnp: 00:08: ioport range 0x940-0x97f has been reserved
PCI: Bridge: 0000:00:01.0
IO window: d000-dfff
MEM window: dfd00000-dfefffff
PREFETCH window: d0000000-d7ffffff
PCI: Bus 4, cardbus bridge: 0000:03:01.0
IO window: 00002000-000020ff
IO window: 00002400-000024ff
PREFETCH window: 50000000-51ffffff
MEM window: 52000000-53ffffff
PCI: Bridge: 0000:00:1e.0
IO window: 2000-2fff
MEM window: dfc00000-dfcfffff
PREFETCH window: 50000000-51ffffff
ACPI: PCI Interrupt 0000:00:01.0[A] -> GSI 16 (level, low) -> IRQ 16
PCI: Enabling device 0000:03:01.0 (0000 -> 0003)
ACPI: PCI Interrupt 0000:03:01.0[A] -> GSI 19 (level, low) -> IRQ 17
NET: Registered protocol family 2
IP route cache hash table entries: 32768 (order: 5, 131072 bytes)
TCP established hash table entries: 131072 (order: 9, 2097152 bytes)
TCP bind hash table entries: 65536 (order: 8, 1310720 bytes)
TCP: Hash tables configured (established 131072 bind 65536)
TCP reno registered
Simple Boot Flag at 0x79 set to 0x1
IA-32 Microcode Update Driver: v1.14 <tigran@veritas.com>
highmem bounce pool size: 64 pages
NTFS driver 2.1.27 [Flags: R/W].
fuse init (API version 7.6)
Installing v9fs 9P2000 file system support
Initializing Cryptographic API
io scheduler noop registered
io scheduler cfq registered (default)
vesafb: framebuffer at 0xd0000000, mapped to 0xf8880000, using 3072k, total
131008k
vesafb: mode is 1024x768x16, linelength=2048, pages=84
vesafb: protected mode interface info at c000:5b0b
vesafb: pmi: set display start = c00c5b79, set palette = c00c5bb3
vesafb: pmi: ports = de10 de16 de54 de38 de3c de5c de00 de04 deb0 deb2 deb4 
vesafb: scrolling: ywrap using protected mode interface, yres_virtual=1536
vesafb: Truecolor: size=0:5:6:5, shift=0:11:5:0
Console: switching to colour frame buffer device 128x48
fb0: VESA VGA frame buffer device
ACPI: AC Adapter [AC] (on-line)
ACPI: Battery Slot [BAT0] (battery present)
ACPI: Lid Switch [LID]
ACPI: Power Button (CM) [PBTN]
ACPI: Sleep Button (CM) [SBTN]
ACPI: Video Device [VID] (multi-head: yes  rom: no  post: no)
ACPI: CPU0 (power states: C1[C1] C2[C2] C3[C3] C4[C3])
ACPI: Processor [CPU0] (supports 8 throttling states)
ACPI: Thermal Zone [THM] (57 C)
Real Time Clock Driver v1.12ac
Serial: 8250/16550 driver $Revision: 1.90 $ 4 ports, IRQ sharing enabled
RAMDISK driver initialized: 16 RAM disks of 4096K size 1024 blocksize
loop: loaded (max 8 devices)
b44.c:v1.00 (Apr 7, 2006)
ACPI: PCI Interrupt 0000:03:00.0[A] -> GSI 18 (level, low) -> IRQ 18
eth0: Broadcom 4400 10/100BaseT Ethernet 00:12:3f:ea:a4:a6
tun: Universal TUN/TAP device driver, 1.6
tun: (C) 1999-2004 Max Krasnyansky <maxk@qualcomm.com>
netconsole: device eth0 not up yet, forcing it
b44: eth0: Link is up at 100 Mbps, full duplex.
b44: eth0: Flow control is off for TX and off for RX.
netconsole: network logging started
ACPI: PCI Interrupt 0000:00:1f.2[B] -> 
GSI 17 (level, low) -> IRQ 19
ACPI: PCI interrupt for device 0000:00:1f.2 disabled
ahci: probe of 0000:00:1f.2 failed with error -12
ata_piix 0000:00:1f.2: MAP [
P0
P2
IDE IDE
]
ACPI: PCI Interrupt 0000:00:1f.2[B] -> 
GSI 17 (level, low) -> IRQ 19
ata1: SATA max UDMA/133 cmd 0x1F0 ctl 0x3F6 bmdma 0xBFA0 irq 14
BUG: unable to handle kernel NULL pointer dereference
at virtual address 00000000
printing eip:
00000000
*pde = 00000000
Oops: 0000 [#1]
PREEMPT 

Modules linked in:

CPU:    0
EIP:    0060:[<00000000>]    Not tainted VLI
EFLAGS: 00010246   (2.6.17 #4) 
EIP is at rest_init+0x3feffde0/0x40
eax: c19b635c   ebx: c03ee6c0   ecx: c19afe00   edx: c19b63d4
esi: c19b6454   edi: c10335e0   ebp: c193fef0   esp: c193fec8
ds: 007b   es: 007b   ss: 0068
Process ata/0 (pid: 310, threadinfo=c193f000 task=c193c070)

Stack: 
c02d8e6d 
00000200 
00000000 
c19afe00 
00000000 
c19b635c 
c19b64b8 
00000058 


c19b635c 
c19b6454 
c193ff14 
c02d91a6 
c04c7440 
c04c7440 
c193ff08 
c03dbd73 


c19b635c 
00000000 
c1986840 
c193ff28 
c02d9392 
c193ff28 
c19b6508 
c19b650c 

Call Trace:
<c0103f71> 
show_stack_log_lvl+0x91/0xc0

<c0104191> 
show_registers+0x191/0x210

<c01043b4> 
die+0x104/0x220

<c0116f2a> 
do_page_fault+0x38a/0x5f0

<c0103bb7> 
error_code+0x4f/0x54

<c02d91a6> 
ata_pio_block+0xc6/0x170

<c02d9392> 
ata_pio_task+0x72/0x80

<c012ced8> 
run_workqueue+0x78/0xf0

<c012d075> 
worker_thread+0x125/0x140

<c01304c5> 
kthread+0x95/0xe0

<c0101425> 
kernel_thread_helper+0x5/0x10


Code: 
Bad EIP value.

EIP: [<00000000>] 
rest_init+0x3feffde0/0x40
SS:ESP 0068:c193fec8

Re: PATA driver patch for 2.6.17

[Alan Cox]

Ar Llu, 2006-06-19 am 20:46 +0100, ysgrifennodd Marcus Furlong:
> Alan Cox wrote:
> 
> > http://zeniv.linux.org.uk/~alan/IDE
> > 
> > This is basically a resync versus 2.6.17, the head of the PATA tree is
> > now built against Jeffs tree with revised error handling and the like.
> > 
> > Alan
> 
> I get the following bug while booting: 

Sorry about that. I messed up a patch segment in the merge

--- drivers/scsi/ata_piix.c~	2006-06-19 21:38:43.746144712 +0100
+++ drivers/scsi/ata_piix.c	2006-06-19 21:38:43.747144560 +0100
@@ -360,6 +360,8 @@
 	.qc_prep		= ata_qc_prep,
 	.qc_issue		= ata_qc_issue_prot,
 
+	.data_xfer		= ata_pio_data_xfer,
+
 	.eng_timeout		= ata_eng_timeout,
 
 	.irq_handler		= ata_interrupt,

Re: PATA driver patch for 2.6.17

[Marcus Furlong]

Alan Cox wrote:

> Ar Llu, 2006-06-19 am 20:46 +0100, ysgrifennodd Marcus Furlong:
>> Alan Cox wrote:
>> 
>> > http://zeniv.linux.org.uk/~alan/IDE
>> > 
>> > This is basically a resync versus 2.6.17, the head of the PATA tree is
>> > now built against Jeffs tree with revised error handling and the like.
>> > 
>> > Alan
>> 
>> I get the following bug while booting:
> 
> Sorry about that. I messed up a patch segment in the merge
> 
> --- drivers/scsi/ata_piix.c~  2006-06-19 21:38:43.746144712 +0100
> +++ drivers/scsi/ata_piix.c   2006-06-19 21:38:43.747144560 +0100
> @@ -360,6 +360,8 @@
>  .qc_prep             = ata_qc_prep,
>  .qc_issue            = ata_qc_issue_prot,
>  
> +     .data_xfer              = ata_pio_data_xfer,
> +
>  .eng_timeout         = ata_eng_timeout,
>  
>  .irq_handler         = ata_interrupt,

That fixes it. Thanks! :)

Re: PATA driver patch for 2.6.17

[Fabio Comolli]

Hi Alan.

> Sorry about that. I messed up a patch segment in the merge
>
> --- drivers/scsi/ata_piix.c~    2006-06-19 21:38:43.746144712 +0100
> +++ drivers/scsi/ata_piix.c     2006-06-19 21:38:43.747144560 +0100
> @@ -360,6 +360,8 @@
>         .qc_prep                = ata_qc_prep,
>         .qc_issue               = ata_qc_issue_prot,
>
> +       .data_xfer              = ata_pio_data_xfer,
> +
>         .eng_timeout            = ata_eng_timeout,
>
>         .irq_handler            = ata_interrupt,
>
> -

Is this patch supposed to be applied also on systems with only PATA
drives? My laptop does not have SATA and does not show this bug.

thanks,
Fabio

Re: PATA driver patch for 2.6.17

[Alan Cox]

Ar Maw, 2006-06-20 am 07:41 +0200, ysgrifennodd Fabio Comolli:
> Is this patch supposed to be applied also on systems with only PATA
> drives? My laptop does not have SATA and does not show this bug.

The crash will only occur if you have SATA ports on a PIIX chip.
Applying it won't do any harm.

I'll put up a -ide2 today with it folded in

Re: PATA driver patch for 2.6.17

[Andrey Borzenkov]

Alan Cox wrote:

> http://zeniv.linux.org.uk/~alan/IDE
> 
> This is basically a resync versus 2.6.17, the head of the PATA tree is
> now built against Jeffs tree with revised error handling and the like.
> 

Running vanilla 2.6.17 + ide1 patch on ALi M5229 does not find CD-ROM.
Notice "ata2: command 0xa0 timeout" below.

ata1: PATA max UDMA/100 cmd 0x1F0 ctl 0x3F6 bmdma 0xEFF0 irq 14
ata1: dev 0 cfg 49:0f00 82:746b 83:49a8 84:4003 85:f469 86:0808 87:4003
88:103f
ata1: dev 0 ATA-5, max UDMA/100, 39070080 sectors: LBA
ata1: dev 0 configured for UDMA/33
scsi0 : ali
  Vendor: ATA       Model: IC25N020ATDA04-0  Rev: DA3O
  Type:   Direct-Access                      ANSI SCSI revision: 05
ata2: PATA max UDMA/100 cmd 0x170 ctl 0x376 bmdma 0xEFF8 irq 15
ata2: dev 0 cfg 49:0f00 82:0000 83:0000 84:0000 85:0000 86:0000 87:0000
88:0407
ata2: dev 0 ATAPI, max UDMA/33
ata2: dev 0 configured for UDMA/33
scsi1 : ali
ata2: command 0xa0 timeout, stat 0x58 host_stat 0x21
ata2: translated ATA stat/err 0x58/00 to SCSI SK/ASC/ASCQ 0xb/47/00
SCSI device sda: 39070080 512-byte hdwr sectors (20004 MB)
sda: Write Protect is off
sda: Mode Sense: 00 3a 00 00
SCSI device sda: drive cache: write back
SCSI device sda: 39070080 512-byte hdwr sectors (20004 MB)
sda: Write Protect is off
sda: Mode Sense: 00 3a 00 00
SCSI device sda: drive cache: write back
 sda: sda1 sda2
sd 0:0:0:0: Attached scsi disk sda

Otherwise I am pretty much impressed.

00:00.0 Host bridge: ALi Corporation M1644/M1644T Northbridge+Trident (rev
01)
00:01.0 PCI bridge: ALi Corporation PCI to AGP Controller
00:02.0 USB Controller: ALi Corporation USB 1.1 Controller (rev 03)
00:04.0 IDE interface: ALi Corporation M5229 IDE (rev c3)
00:06.0 Multimedia audio controller: ALi Corporation M5451 PCI AC-Link
Controller Audio Device (rev 01)
00:07.0 ISA bridge: ALi Corporation M1533 PCI to ISA Bridge [Aladdin IV]
00:08.0 Bridge: ALi Corporation M7101 Power Management Controller [PMU]
00:0a.0 Ethernet controller: Intel Corporation 82557/8/9 [Ethernet Pro 100]
(rev 08)
00:10.0 CardBus bridge: Texas Instruments PCI1410 PC card Cardbus Controller
(rev 01)
00:11.0 CardBus bridge: Toshiba America Info Systems ToPIC100 PCI to Cardbus
Bridge with ZV Support (rev 32)
00:11.1 CardBus bridge: Toshiba America Info Systems ToPIC100 PCI to Cardbus
Bridge with ZV Support (rev 32)
00:12.0 System peripheral: Toshiba America Info Systems SD TypA Controller
(rev 03)
01:00.0 VGA compatible controller: Trident Microsystems CyberBlade XPAi1
(rev 82)


And running "classical" IDE:

{pts/0}% sudo cat /proc/ide/hdc/model
TOSHIBA DVD-ROM SD-C2502
{pts/0}% sudo cat /proc/ide/hdc/identify
85c0 0000 0000 0000 0000 0000 0000 0000
0000 0000 3031 3030 3230 3839 3338 2020
2020 2020 2020 2020 0000 0100 0000 3133
3133 2020 2020 544f 5348 4942 4120 4456
442d 524f 4d20 5344 2d43 3235 3032 2020
2020 2020 2020 2020 2020 2020 2020 0000
0000 0f00 0000 0400 0200 0006 0000 0000
0000 0000 0000 0000 0000 0000 0007 0007
0003 0078 0078 0078 0078 0000 0000 0000
0000 0004 0009 0000 0000 0000 0000 0000
003c 0013 0000 0000 0000 0000 0000 0000
0407 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000

-andrey

Re: PATA driver patch for 2.6.17

[Alan Cox]

Ar Maw, 2006-06-20 am 21:12 +0400, ysgrifennodd Andrey Borzenkov:
> Running vanilla 2.6.17 + ide1 patch on ALi M5229 does not find CD-ROM.
> Notice "ata2: command 0xa0 timeout" below.

Not sure immediately but does the following help

--- ../libata-devo/drivers/scsi/pata_ali.c	2006-06-20 11:50:15.000000000 +0100
+++ drivers/scsi/pata_ali.c	2006-06-21 21:42:27.458542280 +0100
@@ -181,11 +181,12 @@
 	u8 fifo;
 	int shift = 4 * adev->devno;
 
-	/* Bits 3:2 (7:6 for slave) control the PIO. 00 is off 01
-	   is on. The FIFO must not be used for ATAPI. We preserve
-	   BIOS set thresholds */
+	/* ATA - FIFO on set nibble to 0x05, ATAPI - FIFO off, set nibble to
+	   0x00. Not all the docs agree but the behaviour we now use is the
+	   one stated in the BIOS Programming Guide */
+	   
 	pci_read_config_byte(pdev, pio_fifo, &fifo);
-	fifo &= ~(0x0C << shift);
+	fifo &= ~(0x0F << shift);
 	if (on)
 		fifo |= (on << shift);
 	pci_write_config_byte(pdev, pio_fifo, fifo);
@@ -261,10 +262,10 @@
 
 	/* PIO FIFO is only permitted on ATA disk */
 	if (adev->class != ATA_DEV_ATA)
-		ali_fifo_control(ap, adev, 0);
+		ali_fifo_control(ap, adev, 0x00);
 	ali_program_modes(ap, adev, &t, 0);
 	if (adev->class == ATA_DEV_ATA)
-		ali_fifo_control(ap, adev, 0x04);
+		ali_fifo_control(ap, adev, 0x05);
 
 }
 

Re: PATA driver patch for 2.6.17

[Andrey Borzenkov]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 22 June 2006 01:23, Alan Cox wrote:
> Ar Maw, 2006-06-20 am 21:12 +0400, ysgrifennodd Andrey Borzenkov:
> > Running vanilla 2.6.17 + ide1 patch on ALi M5229 does not find CD-ROM.
> > Notice "ata2: command 0xa0 timeout" below.
>
> Not sure immediately but does the following help
>

Not really. AFAIK lowest nibble bit has meaning only in DMA mode anyway.

Anything else I could try to help pinpoint the problem?

> --- ../libata-devo/drivers/scsi/pata_ali.c	2006-06-20 11:50:15.000000000
> +0100 +++ drivers/scsi/pata_ali.c	2006-06-21 21:42:27.458542280 +0100
> @@ -181,11 +181,12 @@
>  	u8 fifo;
>  	int shift = 4 * adev->devno;
>
> -	/* Bits 3:2 (7:6 for slave) control the PIO. 00 is off 01
> -	   is on. The FIFO must not be used for ATAPI. We preserve
> -	   BIOS set thresholds */
> +	/* ATA - FIFO on set nibble to 0x05, ATAPI - FIFO off, set nibble to
> +	   0x00. Not all the docs agree but the behaviour we now use is the
> +	   one stated in the BIOS Programming Guide */
> +
>  	pci_read_config_byte(pdev, pio_fifo, &fifo);
> -	fifo &= ~(0x0C << shift);
> +	fifo &= ~(0x0F << shift);
>  	if (on)
>  		fifo |= (on << shift);
>  	pci_write_config_byte(pdev, pio_fifo, fifo);
> @@ -261,10 +262,10 @@
>
>  	/* PIO FIFO is only permitted on ATA disk */
>  	if (adev->class != ATA_DEV_ATA)
> -		ali_fifo_control(ap, adev, 0);
> +		ali_fifo_control(ap, adev, 0x00);
>  	ali_program_modes(ap, adev, &t, 0);
>  	if (adev->class == ATA_DEV_ATA)
> -		ali_fifo_control(ap, adev, 0x04);
> +		ali_fifo_control(ap, adev, 0x05);
>
>  }
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQFEmspZR6LMutpd94wRApEgAJ4q7AQM09lZ/uTnSPJIM296LYnF9QCgp63W
5lygD8TmjYh+1QwOGTWbQkg=
=SDOQ
-----END PGP SIGNATURE-----

Re: PATA driver patch for 2.6.17

[Alan Cox]

Ar Iau, 2006-06-22 am 20:50 +0400, ysgrifennodd Andrey Borzenkov:
> Not really. AFAIK lowest nibble bit has meaning only in DMA mode anyway.

The BIOS docs are fairly confusing on that point referring to one bit as
the "PIO FIFO" bit.

> Anything else I could try to help pinpoint the problem?

Set the controller to support PIO only and see what happens. 

[ie set .udma_mask = 0 i nthe ali_init_one entries]

If that works it implies the DMA tuning may be involved. If that doesn't
change it what happens with a hard disk in the same place ?

Re: PATA driver patch for 2.6.17

[Andrey Borzenkov]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 23 June 2006 19:24, Alan Cox wrote:
> Ar Iau, 2006-06-22 am 20:50 +0400, ysgrifennodd Andrey Borzenkov:
> > Anything else I could try to help pinpoint the problem?
>
> Set the controller to support PIO only and see what happens.
>
> [ie set .udma_mask = 0 i nthe ali_init_one entries]
>
> If that works it implies the DMA tuning may be involved.

this works (sr is module)

libata version 1.20 loaded.
ACPI: PCI Interrupt 0000:00:04.0[A]: no GSI
ata1: PATA max PIO4 cmd 0x1F0 ctl 0x3F6 bmdma 0xEFF0 irq 14
ata1: dev 0 cfg 49:0f00 82:746b 83:49a8 84:4003 85:f469 86:0800 87:4003 
88:103f
ata1: dev 0 ATA-5, max UDMA/100, 39070080 sectors: LBA
ata1: dev 0 configured for PIO4
scsi0 : ali
  Vendor: ATA       Model: IC25N020ATDA04-0  Rev: DA3O
  Type:   Direct-Access                      ANSI SCSI revision: 05
ata2: PATA max PIO4 cmd 0x170 ctl 0x376 bmdma 0xEFF8 irq 15
ata2: dev 0 cfg 49:0f00 82:0000 83:0000 84:0000 85:0000 86:0000 87:0000 
88:0407
ata2: dev 0 ATAPI, max UDMA/33
ata2: dev 0 configured for PIO4
scsi1 : ali
  Vendor: TOSHIBA   Model: DVD-ROM SD-C2502  Rev: 1313
  Type:   CD-ROM                             ANSI SCSI revision: 05
SCSI device sda: 39070080 512-byte hdwr sectors (20004 MB)
sda: Write Protect is off
sda: Mode Sense: 00 3a 00 00
SCSI device sda: drive cache: write back
SCSI device sda: 39070080 512-byte hdwr sectors (20004 MB)
sda: Write Protect is off
sda: Mode Sense: 00 3a 00 00
SCSI device sda: drive cache: write back
 sda: sda1 sda2
sd 0:0:0:0: Attached scsi disk sda

next step? :)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQFEnCLlR6LMutpd94wRArNuAJ9gqT7pSW5GwKN7xHlKP6EwNAAE9wCdH2gt
cwtcRFOix65bcL6fm4AlnKA=
=eCqh
-----END PGP SIGNATURE-----

Re: PATA driver patch for 2.6.17

[Andrey Borzenkov]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 22 June 2006 01:23, Alan Cox wrote:
> Ar Maw, 2006-06-20 am 21:12 +0400, ysgrifennodd Andrey Borzenkov:
> > Running vanilla 2.6.17 + ide1 patch on ALi M5229 does not find CD-ROM.
> > Notice "ata2: command 0xa0 timeout" below.
>

I also tried the Tejun Heo patch for 2.6.17 (wihout PM) + pata_ali from Jeff 
Garik git tree with the same result; may be it gives more information about 
the error:

libata version 1.30 loaded.
ACPI: PCI Interrupt 0000:00:04.0[A]: no GSI
ata1: PATA max UDMA/100 cmd 0x1F0 ctl 0x3F6 bmdma 0xEFF0 irq 14
scsi0 : pata_ali
ata1.00: configured for UDMA/33
  Vendor: ATA       Model: IC25N020ATDA04-0  Rev: DA3O
  Type:   Direct-Access                      ANSI SCSI revision: 05
ata2: PATA max UDMA/100 cmd 0x170 ctl 0x376 bmdma 0xEFF8 irq 15
scsi1 : pata_ali
ata2.00: configured for UDMA/33
ata2.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata2.00: (BMDMA stat 0x21)
ata2.00: tag 0 cmd 0xa0 Emask 0x4 stat 0x40 err 0x0 (timeout)
ata2: soft resetting port
ata2.00: configured for UDMA/33
ata2: EH complete
ata2.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata2.00: (BMDMA stat 0x21)
ata2.00: tag 0 cmd 0xa0 Emask 0x4 stat 0x40 err 0x0 (timeout)
ata2: soft resetting port
ata2.00: configured for UDMA/33
ata2: EH complete
ata2.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata2.00: (BMDMA stat 0x21)
ata2.00: tag 0 cmd 0xa0 Emask 0x4 stat 0x40 err 0x0 (timeout)
ata2: soft resetting port
ata2.00: configured for UDMA/33
ata2: EH complete
ata2.00: limiting speed to UDMA/25
ata2.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen
ata2.00: (BMDMA stat 0x21)
ata2.00: tag 0 cmd 0xa0 Emask 0x4 stat 0x40 err 0x0 (timeout)
ata2: soft resetting port
ata2.00: configured for UDMA/25
ata2: EH complete
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQFEnmxDR6LMutpd94wRAk7tAJ42j1L2FENW05f5SgbfFvSY9PJWDwCgjdwn
0p11xgxTLdnddgjPtBHEGVM=
=sZeN
-----END PGP SIGNATURE-----

Re: PATA driver patch for 2.6.17

[Kevin Radloff]

On 6/19/06, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> http://zeniv.linux.org.uk/~alan/IDE
>
> This is basically a resync versus 2.6.17, the head of the PATA tree is
> now built against Jeffs tree with revised error handling and the like.
>
> Alan

Hrm, I finally tried a different CF card (Viking 256MB) from the one I
usually use in my camera, and it failed to work:

pccard: PCMCIA card inserted into slot 1
pcmcia: registering new device pcmcia1.0
ata6: PATA max PIO0 cmd 0x3100 ctl 0x310E bmdma 0x0 irq 3
ata6: dev 0 cfg 49:0200 82:0000 83:0000 84:0000 85:0000 86:0000 87:0000 88:0000
ata6: dev 0 ATA-0, max PIO0, 500736 sectors: LBA
ata6: failed to set xfermode (err_mask=0x1)
scsi6 : pata_pcmcia

Here's me sticking in my Sandisk Ultra II 1GB CF card and it working
immediately after:

pccard: card ejected from slot 1
pccard: PCMCIA card inserted into slot 1
pcmcia: registering new device pcmcia1.0
ata7: PATA max PIO0 cmd 0x3100 ctl 0x310E bmdma 0x0 irq 3
ata7: dev 0 cfg 49:0200 82:0000 83:0000 84:0000 85:0000 86:0000 87:0000 88:0000
ata7: dev 0 ATA-10, max PIO4, 2001888 sectors: LBA
ata7: dev 0 configured for PIO0
scsi7 : pata_pcmcia
  Vendor: ATA       Model: SanDisk SDCFH-10  Rev: HDX
  Type:   Direct-Access                      ANSI SCSI revision: 05
SCSI device sdb: 2001888 512-byte hdwr sectors (1025 MB)
sdb: Write Protect is off
sdb: Mode Sense: 00 3a 00 00
SCSI device sdb: drive cache: write through
SCSI device sdb: 2001888 512-byte hdwr sectors (1025 MB)
sdb: Write Protect is off
sdb: Mode Sense: 00 3a 00 00
SCSI device sdb: drive cache: write through
 sdb: sdb1
sd 7:0:0:0: Attached scsi removable disk sdb
sd 7:0:0:0: Attached scsi generic sg2 type 0

-- 
Kevin 'radsaq' Radloff
radsaq@gmail.com
http://thesaq.com/

Re: PATA driver patch for 2.6.17

[Kevin Radloff]

On 6/25/06, Kevin Radloff <radsaq@gmail.com> wrote:
> On 6/19/06, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > http://zeniv.linux.org.uk/~alan/IDE
> >
> > This is basically a resync versus 2.6.17, the head of the PATA tree is
> > now built against Jeffs tree with revised error handling and the like.
> >
> > Alan
>
> Hrm, I finally tried a different CF card (Viking 256MB) from the one I
> usually use in my camera, and it failed to work:
[...]

Ick, apparently I wasn't running what I was thought I was running. It
appears that the only reason pata_pcmcia was working at all was
because I was still using the 2.6.17-rc4-ide1 version of the patch (on
2.6.17 final). The 2.6.17-ide1 version of pata_pcmcia fails like so
(with my usual 1GB Sandisk card):

pccard: PCMCIA card inserted into slot 1
cs: memory probe 0x0c0000-0x0fffff: excluding 0xc0000-0xcffff 0xdc000-0xfffff
cs: memory probe 0x50000000-0x53ffffff: excluding 0x50000000-0x53ffffff
cs: memory probe 0x60000000-0x60ffffff: clean.
cs: memory probe 0xa0000000-0xa0ffffff: clean.
cs: memory probe 0xd0200000-0xd02fffff: excluding 0xd0200000-0xd021ffff
pcmcia: registering new device pcmcia1.0
ata3: PATA max PIO0 cmd 0x3100 ctl 0x310E bmdma 0x0 irq 11
setup_irq: irq handler mismatch
 <b012a19d> setup_irq+0x106/0x119  <b023fc25> ata_interrupt+0x0/0x13f
 <b012a21c> request_irq+0x6c/0x88  <b023f3e8> ata_device_add+0x2f8/0x599
 <f02a3514> pcmcia_init_one+0x4c2/0x522 [pata_pcmcia]  <f0193198>
pcmcia_device_probe+0x7f/0x117 [pcmcia]
 <b0231c3a> __driver_attach+0x0/0x59  <b0231b9d> driver_probe_device+0x42/0x8b
 <b0231c70> __driver_attach+0x36/0x59  <b02316c8> bus_for_each_dev+0x33/0x55
 <b0231b07> driver_attach+0x11/0x13  <b0231c3a> __driver_attach+0x0/0x59
 <b02313f2> bus_add_driver+0x64/0xfa  <f0192d1b>
pcmcia_register_driver+0x4a/0xab [pcmcia]
 <b0128311> sys_init_module+0x1215/0x13a2  <b0102ae7> syscall_call+0x7/0xb
BUG: unable to handle kernel NULL pointer dereference at virtual
address 00000000
 printing eip:
b0232280
*pde = 00000000
Oops: 0000 [#1]
PREEMPT
Modules linked in: pata_pcmcia rfcomm l2cap bluetooth ipt_LOG xt_limit
xt_state iptable_filter ip_conntrack i915 drm fuj02b1_acpi
snd_intel8x0 snd_intel8x0m snd_ac97_codec snd_ac97_bus pcmcia
firmware_class snd_pcm_oss snd_mixer_oss joydev snd_pcm sg ehci_hcd
uhci_hcd ohci1394 snd_timer yenta_socket snd sr_mod rsrc_nonstatic
pcmcia_core usbcore ieee1394 soundcore psmouse cdrom 8139too
snd_page_alloc evdev mii
CPU:    0
EIP:    0060:[<b0232280>]    Not tainted VLI
EFLAGS: 00010206   (2.6.17-ck1-ide1-fu #1)
EIP is at make_class_name+0x29/0x88
eax: 00000000   ebx: ffffffff   ecx: ffffffff   edx: 00000009
esi: b02eca8c   edi: 00000000   ebp: 00000000   esp: e6159b9c
ds: 007b   es: 007b   ss: 0068
Process modprobe (pid: 3094, threadinfo=e6159000 task=ef406070)
Stack: eb1451f8 eb1451f8 b02eca8c b02eca94 b02eca20 b0232459 00000000 00000000
       eb1451f8 00000246 eb145000 eb145028 b0232513 eb1450d0 b0235e0e eb145294
       e67cab80 00003100 0000310e b023cdf3 00000000 b023f612 e6159c4c e67cab80
Call Trace:
 <b0232459> class_device_del+0x6f/0x121  <b0232513>
class_device_unregister+0x8/0x10
 <b0235e0e> scsi_remove_host+0xdf/0xea  <b023cdf3> ata_host_remove+0xe/0x18
 <b023f612> ata_device_add+0x522/0x599  <f02a3514>
pcmcia_init_one+0x4c2/0x522 [pata_pcmcia]
 <f0193198> pcmcia_device_probe+0x7f/0x117 [pcmcia]  <b0231c3a>
__driver_attach+0x0/0x59
 <b0231b9d> driver_probe_device+0x42/0x8b  <b0231c70> __driver_attach+0x36/0x59
 <b02316c8> bus_for_each_dev+0x33/0x55  <b0231b07> driver_attach+0x11/0x13
 <b0231c3a> __driver_attach+0x0/0x59  <b02313f2> bus_add_driver+0x64/0xfa
 <f0192d1b> pcmcia_register_driver+0x4a/0xab [pcmcia]  <b0128311>
sys_init_module+0x1215/0x13a2
 <b0102ae7> syscall_call+0x7/0xb
Code: d0 c3 55 31 ed 57 56 53 83 cb ff 83 ec 04 89 d9 89 04 24 8b 40
44 8b 38 89 e8 f2 ae f7 d1 49 8b 04 24 89 ca 89 d9 8b 78 08 89 e8 <f2>
ae f7 d1 49 8d 44 0a 02 ba d0 00 00 00 e8 90 e4 f0 ff ba f4
EIP: [<b0232280>] make_class_name+0x29/0x88 SS:ESP 0068:e6159b9c

-- 
Kevin 'radsaq' Radloff
radsaq@gmail.com
http://thesaq.com/

Re: PATA driver patch for 2.6.17

[Alan Cox]

Ar Mer, 2006-06-28 am 11:25 -0400, ysgrifennodd Kevin Radloff:
> Ick, apparently I wasn't running what I was thought I was running. It
> appears that the only reason pata_pcmcia was working at all was
> because I was still using the 2.6.17-rc4-ide1 version of the patch (on
> 2.6.17 final). The 2.6.17-ide1 version of pata_pcmcia fails like so
> (with my usual 1GB Sandisk card):

Yep. There are some uglies with the pcmcia layer. Fixed in the devel
tree for a while

Alan