Re: [PATCH v3 4/7] iommu/vt-d: Fold dmar_remove_one_dev_info() into its caller

Baolu Lu
2022-11-16T04:43:33Z

On 11/16/22 11:53 AM, Tian, Kevin wrote:
>> From: Lu Baolu<baolu.lu@linux.intel.com>
>> Sent: Monday, November 14, 2022 9:41 AM
>> @@ -4562,7 +4538,10 @@ static void intel_iommu_release_device(struct
>> device *dev)
>> {
>> struct device_domain_info *info = dev_iommu_priv_get(dev);
>>
>> - dmar_remove_one_dev_info(dev);
>> + iommu_disable_pci_caps(info);
>> + domain_context_clear(info);
>> + device_block_translation(dev);
> clear context after blocking translation.

Unfortunately domain_context_clear() needs reference to info->domain
(for domain id when flushing cache), which is cleared in
device_block_translation().

Best regards,
baolu