From: Jiri Slaby <jirislaby@kernel.org>
To: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH] serial: 8250_fsl: fix handle_irq locking
Date: Tue, 28 Feb 2023 07:27:46 +0100 [thread overview]
Message-ID: <e7d9a975-69b8-0290-102e-ac3fce792952@kernel.org> (raw)
In-Reply-To: <20230227085046.24282-1-johan@kernel.org>
On 27. 02. 23, 9:50, Johan Hovold wrote:
> The 8250 handle_irq callback is not just called from the interrupt
> handler but also from a timer callback when polling (e.g. for ports
> without an interrupt line). Consequently the callback must explicitly
> disable interrupts to avoid a potential deadlock with another interrupt
> in polled mode.
>
> Fix up the two paths in the freescale callback that failed to re-enable
> interrupts when polling.
Huh.
Acked-by: Jiri Slaby <jirislaby@kernel.org>
--
js
suse labs
prev parent reply other threads:[~2023-02-28 6:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 8:50 [PATCH] serial: 8250_fsl: fix handle_irq locking Johan Hovold
2023-02-28 6:27 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7d9a975-69b8-0290-102e-ac3fce792952@kernel.org \
--to=jirislaby@kernel.org \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox