From: Mukesh Ojha <mojha@codeaurora.org>
To: Souptick Joarder <jrdr.linux@gmail.com>,
peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
alexander.shishkin@linux.intel.com, namhyung@kernel.org,
ak@linux.intel.com, eranian@google.com
Cc: linux-kernel@vger.kernel.org, sabyasachi.linux@gmail.com,
brajeswar.linux@gmail.com
Subject: Re: [PATCH] perf: Remove duplicate headers
Date: Sun, 7 Apr 2019 00:19:54 +0530 [thread overview]
Message-ID: <e7de2c3d-01cf-52fb-f00a-2c4321009d08@codeaurora.org> (raw)
In-Reply-To: <1554557789-9474-1-git-send-email-jrdr.linux@gmail.com>
On 4/6/2019 7:06 PM, Souptick Joarder wrote:
> Removed duplicate headers which are included twice.
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> tools/perf/util/data.c | 1 -
> tools/perf/util/get_current_dir_name.c | 1 -
> tools/perf/util/stat-display.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c
> index 6a64f71..509a41e 100644
> --- a/tools/perf/util/data.c
> +++ b/tools/perf/util/data.c
> @@ -8,7 +8,6 @@
> #include <unistd.h>
> #include <string.h>
> #include <asm/bug.h>
> -#include <sys/types.h>
> #include <dirent.h>
>
> #include "data.h"
> diff --git a/tools/perf/util/get_current_dir_name.c b/tools/perf/util/get_current_dir_name.c
> index 267aa60..ebb80cd 100644
> --- a/tools/perf/util/get_current_dir_name.c
> +++ b/tools/perf/util/get_current_dir_name.c
> @@ -5,7 +5,6 @@
> #include "util.h"
> #include <unistd.h>
> #include <stdlib.h>
> -#include <stdlib.h>
>
> /* Android's 'bionic' library, for one, doesn't have this */
>
> diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> index 6d043c7..7b3a16c 100644
> --- a/tools/perf/util/stat-display.c
> +++ b/tools/perf/util/stat-display.c
> @@ -12,7 +12,6 @@
> #include "string2.h"
> #include "sane_ctype.h"
> #include "cgroup.h"
> -#include <math.h>
> #include <api/fs/fs.h>
>
> #define CNTR_NOT_SUPPORTED "<not supported>"
next prev parent reply other threads:[~2019-04-06 18:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-06 13:36 [PATCH] perf: Remove duplicate headers Souptick Joarder
2019-04-06 18:49 ` Mukesh Ojha [this message]
2019-04-16 11:57 ` Souptick Joarder
2019-05-11 7:33 ` Souptick Joarder
-- strict thread matches above, loose matches on Subject: below --
2019-05-20 15:42 Souptick Joarder
2019-06-29 4:46 Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7de2c3d-01cf-52fb-f00a-2c4321009d08@codeaurora.org \
--to=mojha@codeaurora.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=brajeswar.linux@gmail.com \
--cc=eranian@google.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=sabyasachi.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox