From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 140B512B73 for ; Sat, 1 Feb 2025 07:17:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738394226; cv=none; b=qdy3QP7zdizeWW4KxF6Bqxgkjlf+ntgtBAyQD8upxCbsYI0tNdf9YbPDNNQmrSJtNCQEzKHJjyTiv8rEqW5uGbF2b66HFxMUzfdE5u6Y+DL/Cf6lonHaxKN2MIR9BL2o/fQvNzRHMMiH6sbyPBmGlBU325EKZDTvcTg9D7jzrQE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738394226; c=relaxed/simple; bh=NcOAQ0YNivDZlRkPlytp7VKky1fz3WA9K9yZMf+nNxs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YDxPghqP2DkPkgQd3CcNTQBSGLLzdAZjS60n/yERVuukff2YYr/xrp6jhG81HbFGDRs65OAJqXiyi5IcHHetJqwgHXXrF+InzwkbWr8S+JZPyRUItNTueSJyOvpPp4rx8nviGsT+WKX8GYy3XgiRHqjBv8NQ4wGx5+zMsgOrt9I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=NGdlSk2C; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="NGdlSk2C" Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5115P2Cd023403; Sat, 1 Feb 2025 07:16:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=D0TqJr PFaCXJx1YuFrFi+B5yfQlPzZfk7qSonBtEN+c=; b=NGdlSk2CCbM5ZtHVxYY0su oY+VLN7+m6hmEuDFS46fDLuzGlIHoLNLAtXba3nV45KEI1T8ITmUjwXxqS82ipFx hAXjhzf2rNEGnCn62mnICY/PX7M8FTESnNka6ewtxJvyPJv5CqQok4RzxvHgforK kXxzMwSinHjOJQxu1NdIyjYVk8g956pKcNVeCOPrn6+9jKPFUCixKt4cUNaSX3QH vVfDO2JrW8jyBReVw5keuBF/4CyyfcgPEz91oDwf5K/5vvoshDYCcib9FJ6fl/Va JFjnwlm1Rd37fEHSuQSqakpwJGovNIhOGz+klu6spxVjigHNxzUFeFDlw9WBfVZQ == Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 44hdce886b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 01 Feb 2025 07:16:48 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5115Cr40029818; Sat, 1 Feb 2025 07:16:48 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 44hd92rb7k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 01 Feb 2025 07:16:47 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 5117GiRX37880182 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 1 Feb 2025 07:16:44 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3A73620094; Sat, 1 Feb 2025 07:16:44 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5713D20092; Sat, 1 Feb 2025 07:16:41 +0000 (GMT) Received: from [9.43.103.42] (unknown [9.43.103.42]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Sat, 1 Feb 2025 07:16:41 +0000 (GMT) Message-ID: Date: Sat, 1 Feb 2025 12:46:34 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/7] crash: Let arch decide usable memory range in reserved area To: Baoquan he Cc: linuxppc-dev@lists.ozlabs.org, Andrew Morton , Hari Bathini , Madhavan Srinivasan , Mahesh Salgaonkar , Michael Ellerman , kexec@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250131113830.925179-1-sourabhjain@linux.ibm.com> <20250131113830.925179-4-sourabhjain@linux.ibm.com> Content-Language: en-US From: Sourabh Jain In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: IxliJALJ4rLAy8ZlFpwTVM7tGofSRKlj X-Proofpoint-GUID: IxliJALJ4rLAy8ZlFpwTVM7tGofSRKlj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-01_02,2025-01-31_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 clxscore=1015 mlxscore=0 priorityscore=1501 suspectscore=0 adultscore=0 phishscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 mlxlogscore=779 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502010059 Hello Baoquan, On 01/02/25 09:52, Baoquan he wrote: > On 01/31/25 at 05:08pm, Sourabh Jain wrote: >> Although the crashkernel area is reserved, on architectures like >> PowerPC, it is possible for the crashkernel reserved area to contain >> components like RTAS, TCE, OPAL, etc. To avoid placing kexec segments >> over these components, PowerPC has its own set of APIs to locate holes >> in the crashkernel reserved area. >> >> Add an arch hook in the generic locate mem hole APIs so that >> architectures can handle such special regions in the crashkernel area >> while locating memory holes for kexec segments using generic APIs. >> With this, a lot of redundant arch-specific code can be removed, as it >> performs the exact same job as the generic APIs. >> >> To keep the generic and arch-specific changes separate, the changes >> related to moving PowerPC to use the generic APIs and the removal of >> PowerPC-specific APIs for memory hole allocation are done in a >> subsequent patch titled "powerpc/crash: Use generic APIs to locate >> memory hole for kdump. >> >> Cc: Andrew Morton >> Cc: Baoquan he >> Cc: Hari Bathini >> Cc: Madhavan Srinivasan >> Cc: Mahesh Salgaonkar >> Cc: Michael Ellerman >> Cc: kexec@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Sourabh Jain >> --- >> include/linux/kexec.h | 9 +++++++++ >> kernel/kexec_file.c | 12 ++++++++++++ >> 2 files changed, 21 insertions(+) > LGTM, > > Acked-by: Baoquan He Thanks for the Ack! - Sourabh Jain