From: Hau <hau@realtek.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
nic_swsd <nic_swsd@realtek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next] r8169: add support for rtl8168h(revid 0x2a) + rtl8211fs fiber application
Date: Fri, 22 Jul 2022 15:22:49 +0000 [thread overview]
Message-ID: <e7f31872f7e54970b99b5a3df94cb1f1@realtek.com> (raw)
In-Reply-To: <20220721184243.31ace75f@kicinski-fedora-PC1C0HJN>
> On Thu, 21 Jul 2022 22:45:50 +0800 Chunhao Lin wrote:
> > rtl8168h(revid 0x2a) + rtl8211fs is for fiber related application.
> > rtl8168h will control rtl8211fs via its eeprom or gpo pins.
> > Fiber module will be connected to rtl8211fs. The link speed between
> > rtl8168h and rtl8211fs is decied by fiber module.
>
> Compiler says:
>
> drivers/net/ethernet/realtek/r8169_main.c:614:24: warning: symbol
> 'rtl_sfp_if_eeprom_mask' was not declared. Should it be static?
> drivers/net/ethernet/realtek/r8169_main.c:617:24: warning: symbol
> 'rtl_sfp_if_gpo_mask' was not declared. Should it be static?
>
I will change code to use static my next patch.
------Please consider the environment before printing this e-mail.
prev parent reply other threads:[~2022-07-22 15:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 14:45 [PATCH net-next] r8169: add support for rtl8168h(revid 0x2a) + rtl8211fs fiber application Chunhao Lin
2022-07-21 20:35 ` Heiner Kallweit
2022-07-22 3:27 ` Andrew Lunn
2022-07-22 15:26 ` Hau
2022-07-22 15:21 ` Hau
2022-07-22 1:42 ` Jakub Kicinski
2022-07-22 15:22 ` Hau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7f31872f7e54970b99b5a3df94cb1f1@realtek.com \
--to=hau@realtek.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox