From: Tejun Heo <tj@kernel.org>
To: Daejun Park <daejun7.park@samsung.com>
Cc: Daejun Park via B4 Relay
<devnull+daejun7.park.samsung.com@kernel.org>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
Mikulas Patocka <mpatocka@redhat.com>,
Benjamin Marzinski <bmarzins@redhat.com>,
dm-devel@lists.linux.dev, Brian Foster <bfoster@redhat.com>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] dm: fail a REQ_PREFLUSH bio with data when its preflush fails
Date: Fri, 13 Nov 2026 09:35:10 -1000 [thread overview]
Message-ID: <e7facb8344bb662b82266f9f96b7e70e@kernel.org> (raw)
In-Reply-To: <20261112-dm-flush-data-error-v1-1-c83d3f8f3ac4@samsung.com>
On Thu, Nov 12, 2026 at 10:35:29AM +0900, Daejun Park wrote:
> For a bio with REQ_PREFLUSH and data, dm core may send an empty flush
> first. If the flush fails, __dm_io_complete() still reissues the bio
> without REQ_PREFLUSH and drops the error. When that write succeeds,
> the XFS log keeps running and fsync() can return 0.
>
> End the bio with the flush error instead of writing the data, as
> blk-mq does.
>
> Fixes: 6a8736d10cb4 ("dm: relax ordering of bio-based flush implementation")
> Cc: stable@vger.kernel.org
> Signed-off-by: Daejun Park <daejun7.park@samsung.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
prev parent reply other threads:[~2026-11-13 19:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 1:35 [PATCH] dm: fail a REQ_PREFLUSH bio with data when its preflush fails Daejun Park via B4 Relay
2026-11-13 19:35 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7facb8344bb662b82266f9f96b7e70e@kernel.org \
--to=tj@kernel.org \
--cc=agk@redhat.com \
--cc=bfoster@redhat.com \
--cc=bmarzins@redhat.com \
--cc=daejun7.park@samsung.com \
--cc=devnull+daejun7.park.samsung.com@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox