From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3CBE3803CC for ; Tue, 10 Feb 2026 15:06:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770735996; cv=none; b=GOMclE3j+7bWEgwN9sYso6726+JvhMN4AgXdxoyTACqLikhP3fYpaLi4w+DmMMKL7yZ6Hp7eQYyGOG13w5P3KT4Vp9jPnMWwOhwC5V0uTGvL3h18p2fCnrjlDT//XjFdWOTqiv7jIlbaCNcC0pnLqQhfd5ZFLfgr1xczHSI48s4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770735996; c=relaxed/simple; bh=jCgQrHdndYbRHvch+HSK6fr85wEuWYJLUBJMG22268U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ro1v+HEdC7iugW0HYBjc9DpmaE/ngjcV418UfMDY24GjYNfMny2S3Pecjecyc4u7v+1yl3GPJ83EWgPaNpjqOIYj4QZ+V3PU9XBbgpE3dN8PF1rkkOnO3lZXZnye1j1oG9h6RbHASCLVWUYGw5cgCqLBYgGUoPlGF8awxmbTvXM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=eilvap6/; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=C/CnvC5H; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eilvap6/"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="C/CnvC5H" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770735994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VIYPGwfOoEaEyqnciztuxGtw1vWvuiq5QQc4XTYgyEo=; b=eilvap6/1RgynRIIBnerWBwhRyYyYSUjlaDB6W61dZ/RyxOsQorOBhyzTSmnZZdnV9cqSe WCbevtk6Jn+/ADzZJtTcj3zH40t6htCHuq/7gbeMRrQyS2i5IH6344MqcuzurJ1B5OAf3X scLc3Fln3IRJIWbvHADuiAJNig6nEi4= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-480-8mmTvfHvORyl7iy5km0QZA-1; Tue, 10 Feb 2026 10:06:31 -0500 X-MC-Unique: 8mmTvfHvORyl7iy5km0QZA-1 X-Mimecast-MFC-AGG-ID: 8mmTvfHvORyl7iy5km0QZA_1770735990 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-4376ecafb7fso503646f8f.2 for ; Tue, 10 Feb 2026 07:06:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1770735989; x=1771340789; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VIYPGwfOoEaEyqnciztuxGtw1vWvuiq5QQc4XTYgyEo=; b=C/CnvC5HEZ0/PzIPhE2t8H+5gu8mxxZP/8e5R6JlizJWDzUW77AqBCqVE3qJV/HLo1 wPE4z94PM1cLnKzENjxoS37LYJUg3wBKZw4cvhPPz6SisQ7+bPr0Aicf0y+GDfs7J3JI 07r/vghhDxFiazYZn/h+CqWBNDPXbqe0Qh/4FqpmJSsniAbSPYbIYliKUHTgphgTcPnz 5N3+9mlcfIG8c+vcBeZKWfG7/3gPPWF7XXQEl44jZEvtRGPWqPA2/8YiiHpkdbrtwSCa e0Enif9g049hshCSAqsLWRrycozr4apCbkBlzYTEyCuhVowQqPrTfLtvZQV8PvB+NM9C 1+RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770735989; x=1771340789; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VIYPGwfOoEaEyqnciztuxGtw1vWvuiq5QQc4XTYgyEo=; b=s6TGrmbUQCiOQafpBHl91LJ5zLua+RK6GbaoBkCVhUwH8ZMCUKnGUNiWf3dZDCQZ/B 4vFzKev56YqwTQAJLQMNKYBwDVMwP5+wzBqMVG04wXsfLm8SamfPBgd1T+VRuWHiukNl /reLbz3TV0aBRyUdXzzlJtR0L6qGWVrrjNBGPcy+NNe0Qid4jzCDwGTohCCPqY4WfTH+ fqQGVWPQU984rOZjeJ7SjxuqRH4mE2OPnlFPbNktUx0iJAc1RwVVW5oZCeKdxY03aLZu /sbkQ0MQ2j+PAJmgS0OzIHm4KZiMzMNtNDVEmzZnbRvzmgrITJB7ZJlq2aCLL++Tsn9l VFtw== X-Forwarded-Encrypted: i=1; AJvYcCWHdPGAj9Z7OsFSRpGEfPDaBxJtWsPpeD4UYeWMgwHGxZMZ9Nk5uyjNDPEnbg5nUCyEGq9mZne3ndQ6pH0=@vger.kernel.org X-Gm-Message-State: AOJu0YyGgKrM5po4AgpaLoPhKehIwxss/Eg79HSwVuuYRElrPe7xpQKD IgWzQNuzgSErcTuZVGv6mVZ359Acu2ANLmYAiXP7e/gD/5ZTDdnKxbty2vg55N8dMD7MFF5fFht oPkt8MhcFKRc/cQg4kpEIZm3203DvvV2/pXlxrYYCIIbTGpPSvtON0coHKtx5O2sXHA== X-Gm-Gg: AZuq6aLW/G0apzw+3PxRUVd+9NeZSX+wAJUqUr22FApUXe4L9d3y1mQIyHN9JAEEfxG q7VGYuL4DPyR992Q3mK6PvtvQA26sOm0h/27dCl7OfHI/GWxQN0LX3+Z6Nv93M5yqP3QwZFXDlT y6XMkTgzVwioWnzaR6w8EChVVMPLp1n05VBbWjhHnInSF5Rvnk2j2qNSuFZ6SWmpV+VkI0QhNUt mbjWQZvIIzAFqAn8c5BIBBxm45U8w9buIrL/nExkzza0lwoLFOheKsVBqzDTyNErB78qixCeWjR pP1LkqC7KvFrppk0sjSDESGiTFJXpOo/IOv1dUKc2mpzVWjOtzj4t3HZZnq9L83AUqdyETUNba8 /UI6TyRBtTjMkfWCNYO84Du0= X-Received: by 2002:a05:600c:4449:b0:480:32da:f33e with SMTP id 5b1f17b1804b1-48320216075mr250117325e9.17.1770735989518; Tue, 10 Feb 2026 07:06:29 -0800 (PST) X-Received: by 2002:a05:600c:4449:b0:480:32da:f33e with SMTP id 5b1f17b1804b1-48320216075mr250116695e9.17.1770735988987; Tue, 10 Feb 2026 07:06:28 -0800 (PST) Received: from [192.168.88.32] ([150.228.25.31]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4834d7d55c9sm62697045e9.8.2026.02.10.07.06.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Feb 2026 07:06:28 -0800 (PST) Message-ID: Date: Tue, 10 Feb 2026 16:06:23 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v12 3/5] eth fbnic: Add msix self test To: mike.marciniszyn@gmail.com, Alexander Duyck , Jakub Kicinski , kernel-team@meta.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Simon Horman , Russell King , Jacob Keller , Mohsin Bashir , Lee Trager , Dan Carpenter , Pei Xiao , Stanislav Fomichev , Kuniyuki Iwashima , Samiullah Khawaja , Ahmed Zaki , Alexander Lobakin Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260206154246.814-1-mike.marciniszyn@gmail.com> <20260206154246.814-4-mike.marciniszyn@gmail.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260206154246.814-4-mike.marciniszyn@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/6/26 4:42 PM, mike.marciniszyn@gmail.com wrote: > +/** > + * fbnic_msix_test - Verify behavior of NIC interrupts > + * @fbd: device to test > + * > + * This function is meant to test the global interrupt registers and the > + * PCIe IP MSI-X functionality. It essentially goes through and tests > + * test various combinations of the set, clear, and mask bits in order to > + * verify the behavior is as we expect it to be from the driver. > + * > + * Return: non-zero on failure. > + **/ > +int fbnic_msix_test(struct fbnic_dev *fbd) > +{ > + struct pci_dev *pdev = to_pci_dev(fbd->dev); > + struct fbnic_msix_test_data *test_data; > + int result = 0; > + u32 mask = 0; > + int i; > + > + /* Allocate bitmap and IRQ vector table */ > + test_data = kzalloc(sizeof(*test_data), GFP_KERNEL); > + > + /* Result = 5 for memory allocation failure */ > + if (!test_data) > + return 5; Instead of magic numbers you could define some macros, or simply return a boolean success/failures value (as the caller ignores the error code). /P