Re: [PATCH 2/2] dt-bindings: arm: cpus: Add compatible qcom,oryon-1-5

Krzysztof Kozlowski
2026-04-13T12:40:23Z

On 13/04/2026 14:36, Shawn Guo wrote:
> On Mon, Apr 13, 2026 at 12:02:48PM +0200, Krzysztof Kozlowski wrote:
>> On 13/04/2026 11:16, Shawn Guo wrote:
>>> Qualcomm Oryon 1-5 is found on Nord SoC. Add compatible for it.
>>>
>>> $ cat /proc/cpuinfo
>>> ...
>>> CPU implementer : 0x51
>>> CPU architecture: 8
>>> CPU variant : 0x5
>>> CPU part : 0x001
>>> CPU revision : 4
>>>
>>> Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
>>> ---
>>> Documentation/devicetree/bindings/arm/cpus.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>
>> No. I said many times. Bindings come with the user. We don't care what
>> is in cpuinfo of some non-upstream board (and lack of user means it is
>> non-upstream currently).
>
> I was not aware of this requirement, and I see many bindings that

I am not saying anything new here.

> currently do not have any in-tree users, e.g. qcom,oryon-2-3 in cpus.yaml.

And what is the reason for having oryon-2-3 in the kernel? I treat
arguments "I found a code like this, so I can do the same" as proof of
lack of actual technical arguments.

>
>> Please organize your patchset correctly.
>
> Are you asking for a big series that consists of all the new bindings
> used by Nord DTS and DTS itself? Unless this big series gets applied as
> one-go, there are still chances that bindings get into a kernel release
> without any users, e.g. subsystem maintainers pick up bindgins being
> reviewed, but DTS requires more iterations and thus misses the release.

Please follow existing rules, communicated multiple times on the mailing
list. Qualcomm also has internal guideline clarifying this.

Below are some upstream discussion clarifying this:
https://lore.kernel.org/linux-samsung-soc/CADrjBPq_0nUYRABKpskRF_dhHu+4K=duPVZX==0pr+cjSL_caQ@mail.gmail.com/T/#m2d9130a1342ab201ab49670fa6c858ee3724c83c
https://lore.kernel.org/all/49258645-d4d8-44a5-a4fc-b403c926a5d1@kernel.org/

And how to do it:
https://lore.kernel.org/all/20231121-topic-sm8650-upstream-dt-v3-0-db9d0507ffd3@linaro.org/

Best regards,
Krzysztof